Robin Gareus
77844b1d09
Speedup deletion of Busses, specifically the monitor section
...
Deleting sends to busses now only takes the process lock once.
2026-01-27 00:24:12 +01:00
Robin Gareus
6c93112a7e
Fix crash when removing sends/listen
...
When removing the monitor section, or any route that has sends
to it, Session::remove_routes will remove those sends. Despite
Route::remove_processor taking the process lock and removing
the send safely. The send itself will only be destroyed later.
Furthermore the send first calls ~BufferSet() on its
BufferSet mixbufs, before it itself is destroyed.
It was possible to still respond to CycleStart signal which
accessed the mixbufs from the RT thread, causing a heap-use-after-free.
2026-01-27 00:12:42 +01:00
Robin Gareus
20722ce852
Do not override the system's default locale
2026-01-26 21:56:04 +01:00
Paul Davis
6da3b431b5
fix thinko with comment editor logic when opening
2026-01-26 12:32:20 -07:00
Robin Gareus
eab1380fbb
Escape markdown in search paths
...
This fixes an issue when trying to show the Session Properties
Dialog with Sessions using non ASCII chars while using the "C"
locale.
2026-01-26 20:05:09 +01:00
Paul Davis
43cc867e9d
remove SpacebarAction action; all "toggle roll"-like actions should check for clip recording
...
This will require clearing/resetting any customized bindings, but since we haven't released 9.0 yet,
that's what you get :)
2026-01-26 11:57:03 -07:00
Paul Davis
4071ade443
fix problems with triggers not stopping (amend d54c8e7fb0)
2026-01-26 09:45:08 -07:00
Paul Davis
85d5043a69
improve DEBUG::Triggers DEBUG_TRACE output
2026-01-26 09:44:41 -07:00
Paul Davis
fb621f188f
use a bold font for major mark labels on rulers
2026-01-25 22:53:24 -07:00
Paul Davis
fb1eb00796
define a very small bold font
2026-01-25 22:53:24 -07:00
Robin Gareus
31bd0caf31
a-fluidsynth: pick drums on channel 10 when available
...
This is compatible with using CHANNEL_TYPE_DRUM on channel 10,
as was the default until the last commit.
2026-01-25 22:29:20 +01:00
Robin Gareus
47c6639015
a-fluidsynth: allow MMA style bank select an all channels
2026-01-25 21:28:18 +01:00
Paul Davis
34e86474fc
fix crash when setting clip launch style to toggle
2026-01-25 13:23:03 -07:00
Robin Gareus
ae830cd07d
Remove copy-mixer session utility, superseded by built-in import state
2026-01-25 02:49:19 +01:00
Martin Vlk
faeb56c762
Czech translation updates for v 9.0-rc2
2026-01-24 16:32:22 +01:00
John Emmas
fa977bc54d
Fix an issue with commit # 192a976cf9 by removing an unneeded environment variable (MSVC builds only)
...
For a normal Windows build it looks like ARDOUR_DLL_PATH got abandoned quite a long time ago (it's only needed these days by ardev)
2026-01-24 09:52:10 +00:00
Paul Davis
dd823c7b31
NO-OP: braces, please
2026-01-23 15:33:12 -07:00
Robin Gareus
6e64838296
Atomically setup/update bundle list
...
Previously bundles were added one at a time, each taking a
RCUWriter. This lead to issues when another thread concurrently
reads the list.
This fixes an issue with LiveTrax, auto-connecting the monitor bus.
2026-01-23 23:03:26 +01:00
Robin Gareus
872f6869a7
NO-OP: set spacing only once
2026-01-23 16:03:14 +01:00
Robin Gareus
c50547f0a6
Add Lua bindings for modifier Keys
2026-01-23 03:32:59 +01:00
Robin Gareus
b774b71b8c
Add Lua documentationfor static data
2026-01-23 03:22:45 +01:00
Robin Gareus
d249b5014f
Use proper modifier (amend fb0bb5aafa)
2026-01-23 03:13:20 +01:00
Robin Gareus
6e05ab30fb
Ignore fine-grained modifier when using modified X-axis scroll in the summary
2026-01-23 01:14:50 +01:00
Robin Gareus
8f97ecbc62
No Lua scripts for LiveTrax
2026-01-22 23:45:46 +01:00
Paul Davis
3814840cbc
remove debug output
2026-01-22 15:34:55 -07:00
Paul Davis
814f48ef21
tired: while wired: whole inspired: wheel!
2026-01-22 15:14:45 -07:00
Paul Davis
d5e9d888f6
triggerbox: in order to get peakfiles to work, TriggerBox::set_from_path() must create whole-file regions
2026-01-22 15:08:53 -07:00
Robin Gareus
bc6c02e4ea
Fix bashism in 21533227e7
2026-01-22 20:48:17 +01:00
Paul Davis
2766be0846
SMF import: fix behavior when splitting by track & channel
2026-01-22 11:19:36 -07:00
Paul Davis
eafae122ee
add missing method to triggerbox
2026-01-22 08:37:24 -07:00
Robin Gareus
21533227e7
Update VBM and LiveTrax packaging, exclude MIDNAM
2026-01-22 00:37:07 +01:00
Paul Davis
d54c8e7fb0
modify 823b088a4 so that the logic to handle scene-switching doesn't touch other cases
2026-01-21 16:34:12 -07:00
Robin Gareus
84428bab62
Fix SNAFU, setting active dropdown item
2026-01-21 23:28:13 +01:00
Todd Naugle
192a976cf9
Fix dll path when running from source with msys
...
For ardev to work on windows (msys) the enviroment variable for the
DLL path needs to be used.
Without this, ardour fails to find the VST(3) scanner programs.
2026-01-21 21:30:28 +01:00
Paul Davis
823b088a45
triggerbox: when switching between triggers explicitly, don't allow retrigger()
...
If the currently playing trigger has follow action set to Again, when it stops the previous code state
would cause use to simply retrigger it, causing a lot of things to break. Now, in ::begin_switch() we
set _explicitly_stopped to true, so that ::when_stopped_in_run() can do the right thing and simply
shutdown the trigger completely
2026-01-21 11:15:30 -07:00
Paul Davis
af760070cb
triggerbox: add DEBUG_TRACE message to top of ::when_stopped_during_run()
2026-01-21 11:15:30 -07:00
Paul Davis
6fc76e0970
code rearrangement to follow "early return" code style principle
2026-01-21 11:15:30 -07:00
Robin Gareus
01a92de5f8
Remove unused defunct API
2026-01-20 23:30:25 +01:00
Robin Gareus
ec850d9582
Fix loading existing session from running instance
2026-01-20 23:26:32 +01:00
Robin Gareus
3813793ff1
Fix inflating sessions from running instance
...
When inflating a session from a running instance, not using the
startup FSM, loading the inflated session failed.
set_provided_session() calling
existing_session_chooser.set_current_folder()
failed (despite the folder existing).
2026-01-20 23:25:02 +01:00
Robin Gareus
bac1d69e56
Properly escape session-loading errors
...
Previously only the error message was escaped, and some dialogs
were not configured for escaped text.
2026-01-20 21:52:00 +01:00
Paul Davis
5240e3af32
delete route comment editor in RouteUI rather than a delete this lambda
...
Also, no need to reset the stripable's color picker - the destructors for both color pickers
and comment editors do this themselves
2026-01-20 10:32:08 -07:00
Paul Davis
ed984ec3b2
delete stripable color picker in RouteUI rather than a delete this lambda
2026-01-20 10:22:42 -07:00
Paul Davis
f331a0f940
refactor color dialog code to separate generic from stripable-related
2026-01-20 10:09:46 -07:00
Paul Davis
420c383fd0
route group dialog uses ArdourColorButton (again, sort of)
2026-01-20 09:51:21 -07:00
Paul Davis
01a1829451
PaletteDialog -> ArdourColorDialog; add back ArdourColorButton
...
This time, the class heirarchy is cleaner: ArdourColorDialog and ArdourColorButton have
nothing to with Stripables
2026-01-20 09:51:00 -07:00
Paul Davis
169e81773c
trigger UI uses the palette-bearing ArdourColorDialog
2026-01-20 08:39:59 -07:00
Paul Davis
4aeba817b9
introduce ArdourColorDialog, a Gtk::ColorSelectionDialog with a palette
2026-01-20 08:39:27 -07:00
Paul Davis
e6bf82f37f
remove unnecessary #include
2026-01-19 22:00:35 -07:00
Paul Davis
236a9bf73b
just delete RouteCommentEditor directly, not via an idle callback
...
Using an idle callback delays desctruction for too long, and the dangling reference
to a stripable causes havoc
2026-01-19 22:00:04 -07:00
