smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-23 13:47:24 +01:00
Code Issues Projects Releases Wiki Activity

just delete RouteCommentEditor directly, not via an idle callback

Browse source 
Using an idle callback delays desctruction for too long, and the dangling reference
to a stripable causes havoc
This commit is contained in:
Paul Davis 2026-01-19 22:00:04 -07:00
parent 3f17381d49
commit 236a9bf73b
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gtk2_ardour/route_comment_editor.cc
View file

@ -23,7 +23,6 @@
#include "ardour/session_configuration.h"
#include "gtkmm2ext/utils.h"
#include "gtkmm2ext/doi.h"
#include "gui_thread.h"
#include "option_editor.h"
@ -58,7 +57,7 @@ RouteCommentEditor::RouteCommentEditor (std::shared_ptr<Route> r)
_route = r;
_route->set_comment_editor (this);
_route->comment_changed.connect (_connections, invalidator (*this), std::bind (&RouteCommentEditor::comment_changed, this), gui_context ());
_route->DropReferences.connect (_connections, invalidator (*this), std::bind (&delete_when_idle<RouteCommentEditor>, this), gui_context ());
_route->DropReferences.connect (_connections, invalidator (*this), [this] { delete this; }, gui_context ());
Gtkmm2ext::container_clear (_vbox, false);
_vbox.pack_start (_comment_area);