smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-30 17:03:06 +01:00
Code Issues Projects Releases Wiki Activity

remove SpacebarAction action; all "toggle roll"-like actions should check for clip recording

Browse source 
This will require clearing/resetting any customized bindings, but since we haven't released 9.0 yet,
that's what you get :)
This commit is contained in:
Paul Davis 2026-01-26 11:57:03 -07:00
parent 4071ade443
commit 43cc867e9d
3 changed files with 3 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gtk2_ardour/ardour.keys.in
View file

@ -118,7 +118,7 @@ This mode provides many different operations on both regions and control points,
@eep|Editor/edit-cursor-to-previous-region-sync| apostrophe|EP to prev region sync
@eep|Editor/edit-cursor-to-next-region-sync| semicolon|EP to next region sync
@trans|Transport/SpacebarAction| space|toggle roll
@trans|Transport/ToggleRoll| space|toggle roll
@trans|Transport/PlaySelection| <@SECONDARY@>space|play edit range
@edit|Editor/play-from-edit-point-and-return| <@PRIMARY@><@TERTIARY@>space|play from EP \& return
@trans|Transport/ToggleRollMaybe| <@PRIMARY@><@SECONDARY@>space|stop (keep loop/range play)

13
gtk2_ardour/ardour_ui.cc
View file

@ -1858,9 +1858,8 @@ ARDOUR_UI::get_smart_mode() const
return ( editor->get_smart_mode() );
}
void
ARDOUR_UI::spacebar_action (bool with_abort, bool roll_out_of_bounded_mode)
ARDOUR_UI::toggle_roll (bool with_abort, bool roll_out_of_bounded_mode)
{
if (!_session) {
return;
@ -1873,16 +1872,6 @@ ARDOUR_UI::spacebar_action (bool with_abort, bool roll_out_of_bounded_mode)
return;
}
toggle_roll (with_abort, roll_out_of_bounded_mode);
}
void
ARDOUR_UI::toggle_roll (bool with_abort, bool roll_out_of_bounded_mode)
{
if (!_session) {
return;
}
if (_session->is_auditioning()) {
_session->cancel_audition ();
return;

3
gtk2_ardour/ardour_ui_ed.cc
View file

@ -335,10 +335,9 @@ ARDOUR_UI::install_actions ()
ActionManager::session_sensitive_actions.push_back (act);
ActionManager::transport_sensitive_actions.push_back (act);
act = ActionManager::register_action (transport_actions, X_("SpacebarAction"), _("Start/Stop"), sigc::bind (sigc::mem_fun (*this, &ARDOUR_UI::spacebar_action), false, false));
ActionManager::session_sensitive_actions.push_back (act);
act = ActionManager::register_action (transport_actions, X_("ToggleRoll"), _("Start/Stop"), sigc::bind (sigc::mem_fun (*this, &ARDOUR_UI::toggle_roll), false, false));
ActionManager::session_sensitive_actions.push_back (act);
ActionManager::transport_sensitive_actions.push_back (act);
act = ActionManager::register_action (transport_actions, X_("alternate-ToggleRoll"), _("Start/Stop"), sigc::bind (sigc::mem_fun (*this, &ARDOUR_UI::toggle_roll), false, false));
ActionManager::session_sensitive_actions.push_back (act);
ActionManager::transport_sensitive_actions.push_back (act);