smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-22 21:27:22 +01:00
Code Issues Projects Releases Wiki Activity

triggerbox: when switching between triggers explicitly, don't allow retrigger()

Browse source 
If the currently playing trigger has follow action set to Again, when it stops the previous code state
would cause use to simply retrigger it, causing a lot of things to break. Now, in ::begin_switch() we
set _explicitly_stopped to true, so that ::when_stopped_in_run() can do the right thing and simply
shutdown the trigger completely
This commit is contained in:
Paul Davis 2026-01-21 11:15:17 -07:00
parent af760070cb
commit 823b088a45
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
libs/ardour/triggerbox.cc
View file

@ -949,6 +949,7 @@ Trigger::begin_switch (TriggerPtr nxt)
stop, but wait for quantization first.
*/
_state = WaitingToSwitch;
_explicitly_stopped = true;
_nxt_quantization = nxt->_quantization;
DEBUG_TRACE (DEBUG::Triggers, string_compose ("%1 begin_switch() requested state %2\n", index(), enum_2_string (_state)));
send_property_change (ARDOUR::Properties::running);
@ -1306,7 +1307,12 @@ Trigger::when_stopped_during_run (BufferSet& bufs, pframes_t dest_offset)
_loop_cnt,
_follow_count));
if ((_state == Stopped) && !_explicitly_stopped && (launch_style() == Trigger::Gate || launch_style() == Trigger::Repeat)) {
if ((_state == Stopped) && _explicitly_stopped) {
DEBUG_TRACE (DEBUG::Triggers, string_compose ("%1 explicitly stopped\n", index()));
shutdown (bufs, dest_offset);
} else if ((_state == Stopped) && !_explicitly_stopped && (launch_style() == Trigger::Gate || launch_style() == Trigger::Repeat)) {
jump_start ();
DEBUG_TRACE (DEBUG::Triggers, string_compose ("%1 was stopped, repeat/gate ret\n", index()));