Paul Davis
6ba8feed15
triggerui: work on colors, fonts and legato button
2021-10-03 09:09:01 -06:00
John Emmas
808bfe0916
A small experiment to try '#pragma GCC warning'
...
MSVC is happy to ignore the above pragma although it aborts the build if it encounters #warning
#pragma GCC warning seems to work fine here for Clang - so start by changing just 1 x file to see if there's any detrimental effect for the other builds.
2021-10-03 13:29:07 +01:00
Paul Davis
b598750c2a
triggerui: use new table attach API
2021-10-02 17:45:57 -06:00
Paul Davis
747a49006c
canvastable: finish comment
2021-10-02 17:45:43 -06:00
Paul Davis
a8cc0be45c
canvastable: change some variable names; don't add per-col/row spacing twice
2021-10-02 17:09:01 -06:00
Paul Davis
df5699b03e
canvastable: fix comment to reflect split row/col homogeneity
2021-10-02 16:24:04 -06:00
Paul Davis
8130d265fd
canvas table: separate out row & col homogeneity
2021-10-02 16:19:49 -06:00
Paul Davis
590866f8c1
canvas table; move computation of bounding box
2021-10-02 16:19:49 -06:00
Paul Davis
88443586ef
canvas table: clean up attach API; improve comments; move use of padding.right outside loop
2021-10-02 16:19:49 -06:00
Robin Gareus
56056f5590
Remove unused code
...
It that was apparently accidentally added in a git-rebase
in 6fd791423b .
2021-10-02 23:41:28 +02:00
Paul Davis
c550a400b1
triggerbox: more properties
2021-10-01 18:39:06 -06:00
Paul Davis
8cd8e23bef
triggerUI: continue extending trigger launch editor
2021-10-01 18:38:42 -06:00
Paul Davis
cc09576ef5
canvas table: dramatic fixes/extensions of table packing algorithm
2021-10-01 18:38:18 -06:00
Paul Davis
9fe0c3912e
triggerui: control and respond to trigger quantization changes
2021-09-29 18:01:19 -06:00
Paul Davis
e265b27f5d
triggerbox: add quantization property and notify on changes
2021-09-29 18:00:55 -06:00
Paul Davis
55e7d70fca
triggerui: start adding more elements to launch settings dialog
2021-09-29 11:20:50 -06:00
Paul Davis
0e779fbec9
canvastable: if a cell is empty, still adjust horiz/vert coordinates so subsequent cells are aligned
2021-09-29 11:20:50 -06:00
Paul Davis
378e4e7a03
canvastable: fix typo that led to mis-sized table (row/col mixup)
2021-09-29 11:20:50 -06:00
Paul Davis
27ca49efd3
canvas: generic Item::_size_allocate() must adjust allocated space to parent-relative coords
2021-09-29 11:20:50 -06:00
Paul Davis
b5c0f55831
triggerboxui: start connecting more widgets to trigger API
2021-09-29 11:20:50 -06:00
Paul Davis
542424e27d
triggerbox: minor fixes to get properties working more correctly
2021-09-29 11:20:50 -06:00
Robin Gareus
ef30c3dc8d
Allow to edit group from the RouteGroupMenu
2021-09-28 07:11:37 +02:00
Robin Gareus
0dcf7d54e5
Fix --no-nls compilation 2/2 -- #8802
2021-09-27 16:28:44 +02:00
Robin Gareus
ed3d374f47
Fix --no-nls compilation 1/2 -- #8802
...
pbd/i18n.h MUST NEVER be included from header files and always be
the last include. This is because `_` is declared other headers
notably boost and some apple headers.
leading to issues like
../libs/pbd/gettext.h:58:27: error: expected unqualified-id before ‘const’
58 | # define gettext(Msgid) ((const char *) (Msgid))
2021-09-27 16:28:44 +02:00
Paul Davis
2000bc6ea0
triggerbox: add use_follow and start using actual Properties for trigger properties
2021-09-26 21:59:15 -06:00
Paul Davis
754230921d
there is no Properties::position any more (GUI)
...
Position is a part of a length property (a duple specifying
"duration AT position", and there is no distinct property
for just the position itself
2021-09-25 16:49:51 -06:00
Paul Davis
cc6c0f1263
there is no Properties::position any more
...
Position is a part of a length property (a duple specifying
"duration AT position", and there is no distinct property
for just the position itself.
2021-09-25 16:49:51 -06:00
Paul Davis
64db1367bb
Change name of Stateful::apply_changes (PropertyBase) to the singular form.
...
Makes it slightly easier to read+parse what is happening. Yes, for a
Sequence property, the call could apply several changes, but overwhelmingly
it is used to apply a single change.
2021-09-25 16:49:51 -06:00
Paul Davis
30a00c5e9f
Fix implementation of timecnt_t::operator==() to compare both duration and position
2021-09-25 16:49:51 -06:00
Paul Davis
43c7a39f18
Additional removal of a PropertyTemplate::call() site
2021-09-25 16:49:51 -06:00
Paul Davis
2ed1bdd243
Remove PropertyTemplate::call() and replace with code that uses ::set()
...
This makes undo/redo work correctly.
2021-09-25 16:49:51 -06:00
Paul Davis
66595ae60e
a more correct fix (partial reversion) for Drag::adjusted_time()
2021-09-25 16:49:51 -06:00
Robin Gareus
b209827d10
Lua script button to immediately record
...
For all guests who do not like keyboard shortcuts :)
2021-09-26 00:03:52 +02:00
Robin Gareus
5287bbb31e
Fix horiz meter expose
2021-09-25 00:01:23 +02:00
Robin Gareus
1c34a3dcbb
Add missing includes
2021-09-25 00:01:23 +02:00
Robin Gareus
e165e92268
Remove annoying debug message
2021-09-25 00:01:23 +02:00
Robin Gareus
e145a67ed6
Remove unused UI config (hiding-groups activation is a RC)
2021-09-25 00:01:20 +02:00
Paul Davis
3a1d8c48df
Fix implementation of Drag::adjusted_time() to behave like the pre-nutempo version
2021-09-24 15:46:11 -06:00
Paul Davis
5ee2c91864
triggerui: return to normal packing
2021-09-23 11:48:29 -06:00
Paul Davis
368e98336f
gtkmm2ext: if a CairoWidget is used in the canvas, we do not need to realize the Gtk::EventBox
...
This may be a breaking change, but seems ok from superficial testing.
2021-09-23 11:48:29 -06:00
Paul Davis
d07436b15d
canvas: much more work on table layout
2021-09-23 11:48:29 -06:00
Robin Gareus
c11fadf884
Handle missing case TriggerTrack
2021-09-20 04:41:05 +02:00
Robin Gareus
747b24f063
Change LuaWindow into an ArdourWindow
...
* remember window visibility, size and position
* Show as toggle in the window-menu (rather than show action)
* reduce specialization, use WM and ArdourWindow infrastructure
(transient parent, window-type, etc)
2021-09-20 04:26:24 +02:00
Robin Gareus
23c5793173
Remove duplicate calls to set_session
...
Windows managed as Proxy do not need direct calls to set_session().
This is already handled by WM::Manager::instance().set_session()
Also WM set_session() called it twice.
2021-09-20 04:21:21 +02:00
Robin Gareus
851fab7ec3
Print g_log messages to stdout as well
...
This handles an edge-case in case the message arrives
before the UI is up, there is still a message printed,
before Ardour crashes (e.g. when setup_windows() fails).
2021-09-20 04:16:09 +02:00
Robin Gareus
5a1201f05b
Fix duplicate libs
2021-09-19 23:39:51 +02:00
Robin Gareus
29f96ad13e
Fix cross-compile (undefined references for canvas-tests)
2021-09-19 23:38:44 +02:00
Robin Gareus
bcb9487c39
Only setup Editor tooltips once
...
ArdourUI::setup_tooltips() calls editor->setup_tooltips() already.
2021-09-19 18:51:56 +02:00
Robin Gareus
5fb54c008d
Fix shortcut display in editor tooltips #8798
...
After the editor is attached as tab to the main window,
looking up keyboard bindings using get_toplevel() no longer
works.
This uses the widget-hierarchy just like ARDOUR_UI does.
2021-09-19 18:46:06 +02:00
Robin Gareus
0b2b361b32
Dis/reconnect to session signals for each session
...
This allows to load a session from a running instance.
Prior to this change this caused a crash (_session = null)
```
#1 ARDOUR::Session::session_directory() const (this=0x0) at ../libs/ardour/ardour/session.h:257
#2 EditorSources::populate_row(Gtk::TreeRow, boost::shared_ptr<ARDOUR::Region>) (this=0x555559836900, row=..., region=...) at ../gtk2_ardour/editor_sources.cc:433
#3 EditorSources::regions_changed
[ .. signal propagation ..]
#20 ARDOUR::Region::send_change
#21 PBD::Stateful::resume_property_changes
#22 ARDOUR::AudioRegion::_set_state
#23 ARDOUR::AudioRegion::set_state
#24 ARDOUR::RegionFactory::create
#25 ARDOUR::Session::XMLAudioRegionFactory
#27 ARDOUR::Session::load_regions
#28 ARDOUR::Session::set_state
#29 ARDOUR::Session::post_engine_init
#30 ARDOUR::Session::Session
#31 ARDOUR_UI::load_session_stage_two
#32 ARDOUR_UI::load_session
#33 ARDOUR_UI::open_recent_session
```
2021-09-19 04:56:13 +02:00