smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-10 07:26:32 +01:00
Code Issues Projects Releases Wiki Activity
28638 commits 104 branches 145 tags 325 MiB
Commit graph

15278 commits

Author SHA1 Message Date
Robin Gareus
dc0037230e
Fix stackoverflow, endless recursion on ComparableSharedPtr assignment 
boost::shared_ptr & operator=(shared_ptr const & r);
is not declared virtual and cannot safely be overloaded.
 2019-12-12 03:57:58 +01:00
Robin Gareus
0a5837ec71
Fix loading plugin state from sessions 
While loading a session XML state, set_state must use
`Stateful::loading_state_version`.

When later copying processor state,
`Stateful::current_state_version` is correct.
 2019-12-11 16:25:08 +01:00
Robin Gareus
dd18be15fb
Remove hardcoded session-state versions 2019-12-11 13:56:44 +01:00
Paul Davis
3dafaaf2df should probably resolve MIDI notes when loop bounds change 
We don't really need to do this if the bounds have moved "outwards", but
at present we don't know if that is the case, so be safe and resolve in
case the loop bounds moved "inwards" and we would otherwise get stuck notes
caused by the now-missing noteOffs
 2019-12-10 21:27:10 -07:00
Paul Davis
e46c45f6f0 fix unnecssary disruption of MIDI stream when disabling loop 2019-12-10 19:30:37 -07:00
Paul Davis
963f2a470a use PlayistChanged appropriately to fix MIDI output 
We didn't render the MIDI data when a playlist was set, only when modified.
 2019-12-10 12:22:05 -07:00
Paul Davis
af2d0dfb15 use bitmask values for OverwriteReason, as was intended 2019-12-10 12:21:28 -07:00
Paul Davis
c3e3930f14 revert to single buffer for disk playback, and 5.x-style overwrite 
Also address issues with MIDI and also atomicity of _pending_overwrite
 2019-12-10 09:29:22 -07:00
David Robillard
941aa20148 Fix font size on Push2 
At least on my machine, the fonts on the Push display were ridiculously large,
making everything overlapping and unusable.  I suspect this is because
pango_cairo_font_map_get_default() inherits DPI from the system, so the
monitor scaling factor got applied to the Push display as well.

This commit instead creates a new plain font map, and sets the resolution to
96, which looks like what the UI was designed for.  Some more tweaking of the
Pango context might make things more optimal on the Push, but just setting the
resolution makes things look reasonable to me anyway.
 2019-12-09 23:38:10 +01:00
David Robillard
8ec3e5fb54 Fix deprecated-copy warnings 
It's long been a guideline (and IIRC a Weff-c++ warning) that either all, or
none, of the copy methods should be defined, but this became a standard warning
in GCC9.  Presumably to account for a later language change though I'm not sure
which.

I don't remember why the ChanMapping copy constructor can't just be a simple
copy (it's just a map of POD), but figure it's safer to just copy what that
does.
 2019-12-09 23:25:59 +01:00
David Robillard
39bdde4250 Use labs() for long instead of abs() 2019-12-09 23:25:51 +01:00
David Robillard
21e9c41d96 Fix catch of polymorphic type by value 2019-12-09 22:58:08 +01:00
David Robillard
184bf7fd25 Remove unused variable 2019-12-09 22:56:14 +01:00
Robin Gareus
21f682164e
Fix automation alignment for latent plugins 
This also solves bi-stable automation for plugins where latency
can change due to automation. e.g.

cycle 1: run (t): automation (t) = on: -> increase latency
cycle 2: run (t-latency): automation (t-latency) = off -> decrease latency
repeat.
 2019-12-09 18:54:44 +01:00
Paul Davis
cf7bfae926 fix error when continuing to refill audio playback buffers after a buffer switch 
The file_sample[AUDIO] member was not updated to reflect the last-read sample in the
switched-to buffer.

Also move several methods and members from DiskIO to DiskReader where they belong.
 2019-12-08 22:39:31 -07:00
Robin Gareus
b1b29a6317
Fix two compiler warnings 2019-12-09 01:10:50 +01:00
Paul Davis
e291948dcb more debug output 2019-12-08 17:01:17 -07:00
Paul Davis
109486419e avoid a locate-to-loop-start from cancelling looping 2019-12-08 17:01:17 -07:00
Paul Davis
2543a60f88 correct logic errors related to roll-after-locate in TransportFSM 
This might have broken some other subtle behavior, but testing hasn't shown it thus far
 2019-12-08 17:01:17 -07:00
Paul Davis
cc8c139a57 fix missing SessionEvent when **all** tracks need a buffer overwrite 2019-12-08 17:01:17 -07:00
Robin Gareus
581dd40db0
Better, more consistent fix for d0dcca109 2019-12-09 00:07:33 +01:00
Robin Gareus
d0dcca1093
Fix Pan automation when using "Touch" 
Pan->touching was left uninitialized, and usually non-zero.
So pan automation was assumed to be currently touched,
and hence never interpolated.
 2019-12-08 23:52:48 +01:00
John Emmas
09d34abaa9 MSVC project changes needed to support the new 'mp3 import' stuff 2019-12-08 15:04:02 +00:00
John Emmas
e510a8555d Minor changes needed to make the 'mp3 import' sources build with MSVC 
(MSVC project changes to follow...)
 2019-12-08 15:01:59 +00:00
Robin Gareus
7253f304e2
Add support for LV2 state:freePath feature 
This fixes a memory-leak issue for Windows builds.
see also https://github.com/drobilla/lilv/issues/14
 2019-12-08 15:22:00 +01:00
Robin Gareus
dca3f7dd97
NO-OP: whitespace 2019-12-08 15:20:53 +01:00
Paul Davis
dec355e83d fix behavior when pressing l to loop (not in loop-is-mode) and the required stop-during locate cancels looping 2019-12-07 10:30:38 -07:00
Paul Davis
238cc8ed5f functional double buffering when using DiskReader::overwrite_existing_buffers 2019-12-07 10:30:38 -07:00
Paul Davis
1008ac20ff a few parameter changes, and flesh out code to switch rbufs in DiskReader 2019-12-07 10:30:38 -07:00
Paul Davis
8d05f6d4b7 initial conversion to double buffering inside DiskReader 
Second buffer is not used (or allocated) yet.
 2019-12-07 10:30:38 -07:00
Robin Gareus
386f69ae32
Fix 64bit OSX/MacOS builds 2019-12-07 15:46:20 +01:00
Robin Gareus
642bfc4c9a
Do not allow to embed ogg/vorbis files, require import 2019-12-07 15:38:55 +01:00
Robin Gareus
c7c40f6f3d
Remove #ifdef'ed format-specific error-log messages 
With inclusion of Mp3FileSource, this would get tricky.
On MacOS, the SndFileSource's sf_error_str message is never displayed,
anyway, also calling methods all handle failed-constructor.
So error-log is less important.
 2019-12-07 15:38:53 +01:00
Robin Gareus
9040fd4670
Flatten nested try/catch clauses 
This also consistently throws a failed_constructor() when instantiating
a CoreAudioSource fails, regardless of the actual exception
 2019-12-07 15:38:48 +01:00
Robin Gareus
78337c9a7e
Remove unused API, reduce sndfile/coreaudio specialization 2019-12-07 11:32:07 +01:00
Robin Gareus
052f3a6836
Speed up seeking in mp3s 2019-12-06 23:13:20 +01:00
Robin Gareus
9aa887fa65
Fix issues with VBR mp3s, detect duration by decoding 2019-12-06 21:53:03 +01:00
Robin Gareus
0700cb8165
Clear TransportAbort flag after stop 
This fixes an issue with unresponsive transport controls after
an abort (e.g. post-export).
 2019-12-06 21:28:48 +01:00
Robin Gareus
a664a50ab7
Fix Windows build 2019-12-06 20:22:00 +01:00
Robin Gareus
d73734af78
Mark .mp2 and .mp3 as valid file-extensions 2019-12-06 18:30:53 +01:00
Robin Gareus
d0b6c437ce
Implement mp3 import, using minimp3 2019-12-06 18:18:54 +01:00
Robin Gareus
bef74c267e
Add "seekable" SoundFile info (in prep for mp3 import) 2019-12-06 18:18:18 +01:00
Robin Gareus
227de8c1b0
Flatten nested try/catch clauses 
This also consistently throws a failed_constructor() when instantiating
SoundFile fails, regardless of the actual exception
 2019-12-06 18:16:10 +01:00
Robin Gareus
6d99e1b162
VKeybd: Set default MIDI port flags 2019-12-05 23:40:29 +01:00
Paul Davis
9eac4936dc remove mistakenly left in session event enum 2019-12-05 13:13:16 -07:00
Paul Davis
8b4e714006 changes to use overwrite-buffers when loop is disabled or loop range changed 2019-12-05 13:13:16 -07:00
Robin Gareus
551702b9e9
Fix for-loop condition (comma has no effect) 2019-12-05 18:23:49 +01:00
Robin Gareus
7d94e1e1f9
Fix well-known control LPF/HPF order. 2019-12-05 16:43:20 +01:00
Robin Gareus
fa6a21f94e
Ardour 6.0 Alpha - Enterprise Edition 
Its 5 year mission
To explore strange new sounds
To seek out new bugs and new users
To boldly go where no Ardour session has gone before
 2019-12-04 23:07:42 +01:00
Robin Gareus
d8c63568a5
Clear AudioEngine Error at app start 2019-12-04 19:02:16 +01:00