smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-03 12:19:33 +01:00
Code Issues Projects Releases Wiki Activity

Fix stackoverflow, endless recursion on ComparableSharedPtr assignment

Browse source 
boost::shared_ptr & operator=(shared_ptr const & r);
is not declared virtual and cannot safely be overloaded.
This commit is contained in:
Robin Gareus 2019-12-12 03:57:58 +01:00
parent a92dddda25
commit dc0037230e
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libs/ardour/ardour/comparable_shared_ptr.h
View file

@ -42,7 +42,10 @@ class /*LIBARDOUR_API*/ ComparableSharedPtr : public boost::shared_ptr<T>
ComparableSharedPtr (ComparableSharedPtr const & r) : boost::shared_ptr<T> (r) {}
ComparableSharedPtr& operator=(const ComparableSharedPtr& r) { *this = r; return *this; }
ComparableSharedPtr& operator=(ComparableSharedPtr const& r) BOOST_SP_NOEXCEPT {
boost::shared_ptr<T>(r).swap(*this);
return *this;
}
template<class Y>
ComparableSharedPtr(ComparableSharedPtr<Y> const & r) : boost::shared_ptr<T> (r) {}