Robin Gareus
d627e00ff6
NO-OP: whitespace
2021-04-27 23:40:45 +02:00
Robin Gareus
d279e2d333
Avoid accents in master-bus port-name translations
2021-04-26 23:20:27 +02:00
Robin Gareus
a679a2bd42
Retain PBD::Ids when reloading sessions (2/2)
...
Load send gain control state
2021-04-26 19:43:42 +02:00
Robin Gareus
2db53a4c3e
Retain PBD::Ids when reloading sessions (1/2)
...
Monitor/Listen sends panners are not restored, and hence do
not need to be saved. The panner-shell is bypassed anyway.
2021-04-26 19:43:42 +02:00
Robin Gareus
bc8258b234
Remove 6.0-pre0 workaround for missing InlineControl
2021-04-26 19:43:36 +02:00
Paul Davis
fc9a4754bc
allow <PRIMARY>-w to close the preferences window, just other dialogs
...
Preferences is a tabbable, a leftover artifact of when it was, in fact, intended to be a tabbable. Rather than
re-engineer this right now, add a key event handler so that Primary-w works for this just like other dialogs
2021-04-26 10:50:30 -06:00
Paul Davis
cce41ee15b
no need for 2nd argument in OptionEditorContainer constructor call
2021-04-26 10:49:23 -06:00
Paul Davis
3f1e4ceaaa
remove unused argument to OptionEditorContainer constructor
2021-04-26 10:48:53 -06:00
Paul Davis
6db261d566
libgtkmm2ext: modify Keyboard handling of close-current-dialog
...
1) if there is no current dialog, allow some other window to handle the keyboard event
2) make the binding (which is hard coded) visible as static members of Keyboard
2021-04-26 10:48:20 -06:00
Paul Davis
54c135c8b9
fix "trim to loop" region edit operation so that it applies to any region that intersects the loop, not just those spanning it
2021-04-25 09:42:06 -06:00
Robin Gareus
3e99bc5f54
Tweak silence trim threshold configuration
...
Amend, correct fe8418ffea
2021-04-24 16:42:22 +02:00
Robin Gareus
6da997ef30
Revert "use -90dB as default threshold for silence trim during export, rather than -inf dB"
...
This reverts commit fe8418ffea ,
which had no effect, since the default c'tor argument is not used.
2021-04-24 16:42:17 +02:00
Paul Davis
d26d8c91a0
fix per-processor latency to reflect transport direction
2021-04-23 17:38:16 -06:00
Paul Davis
8080a14537
fix Route::latency_preroll() for reverse playback
2021-04-23 17:07:47 -06:00
Paul Davis
fe8418ffea
use -90dB as default threshold for silence trim during export, rather than -inf dB
2021-04-23 11:03:17 -06:00
Paul Davis
4abfcca8b6
rewind/ffwd from GUI needs to start transport, not just set speed
2021-04-23 11:02:54 -06:00
Paul Davis
0cec44ca4b
diskreader: avoid double conditional, use else{} instead
2021-04-21 22:51:06 -06:00
Paul Davis
5ebe78ad2d
diskreader: fix decrement of start before zero ( #8647 )
2021-04-21 22:50:26 -06:00
Paul Davis
4c1a82a153
fix URL for VST3 plugin locations specs ( #8659 )
2021-04-21 18:00:41 -06:00
Robin Gareus
eeadf5087d
Shuttle wheel context-menu: max speed only applies to percentage
2021-04-20 14:26:30 +02:00
Robin Gareus
80405e41b0
Fix shuttle wheel unit granularity
...
When switching to Semitones, round speed to nearest semitone.
This fixes an issue when rolling forward at < 25% which is
less that -24st and then scrolling right (increase pitch).
The result may still be < -24st and playback reverses.
When changing max-speed, directly constrain speed.
2021-04-20 14:14:45 +02:00
Robin Gareus
2c8746eda9
Fix shuttle wheel semi-tone mode
...
Previously it was not possible to return from reverse playback
since left-scroll decreased pitch, even during reverse playback.
This also fixes an edge-case when quickly scrolling through
zero. use_shuttle_fract() ignores rapid events, map_transport_state()
can round speed to zero and next scroll-event set the default +1st
speed (really should have been 0st).This is solved by starting at
-24st, similar to how percentage does not start at 100%.
2021-04-20 13:53:35 +02:00
Paul Davis
62f47e75c9
fix double semi-colon
2021-04-19 16:38:23 -06:00
Paul Davis
180f333cd7
export needs to start transport, not just set speed
2021-04-19 16:14:09 -06:00
Paul Davis
f94aec5a59
fix/improve BasicUI's methods for rewind/ffwd/play (used by various surfaces)
2021-04-19 16:14:09 -06:00
Paul Davis
4b095aad62
additional debugging for TransportFSM events
2021-04-19 16:14:09 -06:00
Paul Davis
48f3719661
correctly initialize transport FSM's last speed request
2021-04-19 16:14:09 -06:00
Paul Davis
5f2d043ca4
update macro and call site for sending a TransportFSM::SetSpeed event
2021-04-19 16:14:09 -06:00
Paul Davis
12d361f43d
clear clicks when starting transport
2021-04-19 16:14:08 -06:00
Paul Davis
fc6cf7ddac
simplify, improve and correct logic in Session::set_transport_speed()
2021-04-19 16:14:08 -06:00
Paul Davis
14c2fdccf4
use correct API in a do-nothing-but-forced locate to start rolling
2021-04-19 16:14:08 -06:00
Paul Davis
b8c7ad6a9b
better/correct logic (and macro) to reset default speed at stop (when relevant)
...
This also resets things after rewind/ffwd
2021-04-19 16:14:08 -06:00
Paul Davis
3fa027f19d
correctly use a valid out-of-bounds value for Session::_requested_transport_speed
2021-04-19 16:14:08 -06:00
Paul Davis
eb1468718a
fix ambiguity in TransportFSM Event constructors
2021-04-19 16:14:08 -06:00
Paul Davis
dc19aa866b
change API for Session::set_transport_speed() to include "at-next-start" option
2021-04-19 16:14:08 -06:00
Paul Davis
81c08b6efb
restore sprung shuttle behavior (mistakenly altered in a recent commit
2021-04-19 16:14:08 -06:00
Paul Davis
0bc5f88a65
fix logic error in transport FSM (compare with adjacent conditionals)
2021-04-19 16:14:08 -06:00
Paul Davis
48e5607f7c
use Session::request_roll() instead of request_transport_speed (1.0, ...)
2021-04-19 16:14:08 -06:00
Paul Davis
52b7e68102
use new Session transport API calls in GUI
2021-04-19 16:14:08 -06:00
Paul Davis
0bccc4bffd
fix mispelling of actual in shuttle control code
2021-04-19 16:14:08 -06:00
Paul Davis
cc8dcb9859
use StartRoll and EndRoll events in request_start() and request_roll()
...
Rather than ::request_transport_speed
2021-04-19 16:14:08 -06:00
Paul Davis
6d5cafb3b6
move various transport logic chunks into Session::realtime_stop(), Session::stop_transport() and Session::start_transport
2021-04-19 16:14:08 -06:00
Paul Davis
79f1ff3df3
fix thinko in TransportFSM's handling of deferred events
...
If a deferred event was used in process_event() but was deferred again, we deleted it. That was wrong,
it should remain in the deferred_events queue.
2021-04-19 16:14:08 -06:00
Paul Davis
11416bf9d1
improve/fix/simplify logic for TransportFSM speed handling
2021-04-19 16:14:08 -06:00
Paul Davis
c65daaa3d6
libardour: change API for Session::set_transport_speed()
...
We no longer need the abort/clear_state arguments because this method only controls speed,
not transport state
2021-04-19 16:14:08 -06:00
Paul Davis
229ea31f34
transport masters: use Session::request_stop() rather than Session::request_transport_speed()
2021-04-19 16:14:08 -06:00
Paul Davis
e5790c6b70
incoming MIDI: use Session::request_stop() rather than Session::request_transport_speed()
2021-04-19 16:14:08 -06:00
Paul Davis
6b7be1083b
no need to request stop if locating with MustStop
2021-04-19 16:14:08 -06:00
Paul Davis
5a159abe1f
new SessionEvents for start/stop transport
2021-04-19 16:14:08 -06:00
Paul Davis
aeed50b1cc
add Session::reset_transport_speed()
2021-04-19 16:14:08 -06:00