Paul Davis
d230efec22
fix crash caused by missing return; add explanatory comments
2015-06-25 10:49:06 -04:00
Paul Davis
938613c123
fix typo in Tracks build
2015-06-25 10:49:06 -04:00
Paul Davis
2cbd841b2c
include Tracks engine state controller header for Tracks build
2015-06-25 10:49:06 -04:00
Paul Davis
de8877c98a
add required profile header
2015-06-25 10:49:06 -04:00
Paul Davis
cb1dee0ea5
change names for scene I/O port connection methods
2015-06-25 10:49:06 -04:00
Paul Davis
8d9e846b40
avoid redundant IO port reconnections in Tracks runtime case
2015-06-25 10:49:06 -04:00
Paul Davis
40b3c06dd7
noop: more style guide fixes
2015-06-25 10:49:06 -04:00
Paul Davis
0ca8ea5792
noop: fix indentation to match style guide
2015-06-25 10:49:06 -04:00
Paul Davis
760e495296
add EngineStateController code from Tracks
2015-06-25 10:49:05 -04:00
Paul Davis
f714d026ee
Fixed issue with crash when invalid get_connections request is made on invalid port handle. (Grygorii)
2015-06-25 10:49:05 -04:00
Paul Davis
1df394e027
add in more Tracks-related auto-(re)connect changes
2015-06-25 10:49:05 -04:00
Paul Davis
f063a1aa8a
add in more Tracks-related auto-(re)connect changes, all conditionalized by Profile
2015-06-25 10:49:05 -04:00
Paul Davis
f16df22da4
initial incorporation of Tracks' automatic reconnect features, based on current Tracks code
2015-06-25 10:49:05 -04:00
Paul Davis
063397a5c0
merge several of the trickiest Tracks- and platform-specific RC configuration variables
2015-06-25 10:49:05 -04:00
Paul Davis
82948f64d5
no-op: indentation and whitespace fixes
2015-06-25 10:49:05 -04:00
GZharun
f6311fecd2
[Summary] Added export cleanup
...
[Reviewed by] Andriy Mishyn
2015-06-25 10:49:05 -04:00
Paul Davis
9598d99b97
indentation and formatting cleanup
2015-06-25 10:49:05 -04:00
GZharun
32c3e0edf2
[Summary] Fixed issue with export built on Mavericks. There was not check on empty sets in ExportFormatSpecification class.
...
C standard, section 6.5.6.8 says:
"...if the result points one past the last element of the array object, it shall not be used as the operand of a unary * operator that is evaluated..."
So GCC compiler and CLANG compiler (Mavericks) process this operation different way. GCC returns 0 on an attempt to dereference end iterator when CLANG returns a non 0 value.
2015-06-25 10:49:05 -04:00
Greg Zharun
3ef372fc6c
[Summary] Fixed windows build
2015-06-25 10:49:05 -04:00
Paul Davis
94c2ad0959
add channel_count() to audio source API
2015-06-25 10:49:05 -04:00
Paul Davis
0fb148fe95
another signal related to record state added from Tracks.
...
This doesn't appear to have obviously distinct semantics from RecordStateChanged
but Tracks is using it and I can't verify instantly that it could be replaced
by RecordStateChanged.
2015-06-25 10:49:05 -04:00
Paul Davis
a032df0b6f
distribute use of RouteAddedOrRemoved to appropriate places.
...
It might be wise to use this rather than GUIIdle but that needs further investigation
2015-06-25 10:49:05 -04:00
Paul Davis
aba2ceda23
include emission of RouteAddedOrRemoved in Session::add_audio_track()
2015-06-25 10:49:05 -04:00
Paul Davis
da6139bdb0
integrate Session::remove_routes() from Tracks and replace Session::remove_route() internal implementation.
...
The singular case replicated (and was the model for) the plural case.
2015-06-25 10:49:04 -04:00
Paul Davis
09c5bb9ada
re-do previous commit with less variables
2015-06-25 10:49:04 -04:00
Paul Davis
8841a43d23
Tracks calls tracks "Tracks"; Ardour uses type-names
2015-06-25 10:49:04 -04:00
Paul Davis
202ddbfdb5
Session::reconnect_midi_scene_ports() is a Tracks thing.
...
It requires the EngineStateController which is not merged at this time
2015-06-25 10:49:04 -04:00
Paul Davis
87d81cf85c
add missing profile header
2015-06-25 10:49:04 -04:00
GZharun
2e58b7ad44
fix bank ID when MIDI Scene change handles a program change message
2015-06-25 10:49:04 -04:00
Paul Davis
3b38b0fe1b
add Session::reconnect_midi_scene_ports()
2015-06-25 10:49:04 -04:00
Paul Davis
bdf8c37306
add comment
2015-06-25 10:49:04 -04:00
Paul Davis
8bdc54cc67
totally bizarre and incorrect solo/mute behaviour for Tracks (ONLY)
2015-06-25 10:49:04 -04:00
nikolay
149c8271c6
[Summary] Changed function name update_route_active_state() on update_route_record_state()
...
[Reviewed] GZharun
Conflicts:
libs/ardour/ardour/session.h
libs/ardour/session.cc
libs/ardour/session_state.cc
2015-06-25 10:49:04 -04:00
Paul Davis
a92c61194e
provide Session::have_rec_disabled_track()
2015-06-25 10:49:04 -04:00
Paul Davis
51baaaaf7e
add the Tracks version of Track::monitoring_state()
...
This drastically-stripped down version of the Ardour original is used only when USE_TRACKS_CODE_FEATURES
is defined. It doesn't respond to many aspects/features of libardour.
2015-06-25 10:49:04 -04:00
Paul Davis
31d664c58a
adding routes no longer saves session but leaves it marked dirty (Tracks semantics for add_routes() retained)
2015-06-25 10:49:04 -04:00
Paul Davis
324a9512ec
fix indentation
2015-06-25 10:49:04 -04:00
GZharun
bb85d56db7
[Summary] Region changes will make session dirty
2015-06-25 10:49:04 -04:00
Paul Davis
64a0cd6c06
mark session dirty when markers/ranges are changed
2015-06-25 10:49:03 -04:00
Paul Davis
14393f9790
fixed previous commit from Tracks to work correctly in all cases
2015-06-25 10:49:03 -04:00
Valeriy Kamyshniy
a9274cd3a1
[Summary] BUG FIXED: New name of a session saved with “save as”, was not stored in the session recent list.
...
[Reviewed] YPozdnyakov
2015-06-25 10:49:03 -04:00
Valeriy Kamyshniy
b9106d4304
[Summary] Adding informative message to failed file copy exception in Session::save_as.
...
[Review required] Paul Davis
2015-06-25 10:49:03 -04:00
Paul Davis
65c6ee7791
save recent templates analogously to recent sessions
2015-06-25 10:49:03 -04:00
Paul Davis
01bb1785a4
Tracks-specific handling of template dir
2015-06-25 10:49:03 -04:00
Paul Davis
79759e63f8
fix cherry-pick logic failure with Session::save_template() - Tracks case already taken care of
2015-06-25 10:49:03 -04:00
Valeriy Kamyshniy
72c7df716d
[Summary] a) On MAC OS, .DS_Store files are ignored when saving a session by “Save As”.
...
b) plugins folder is not created for Templates.
[Required review] Paul Davis, YPozdnyakov
Conflicts:
libs/ardour/session_state.cc
2015-06-25 10:49:03 -04:00
Valeriy Kamyshniy
0583cefa1c
[Summary] For tracks when saving templates, we need stored the Auto Loop Range and all MIDI markers. As well, just to follow canonical rule: dealing with a pointer (_location in Session::state) check it for NULL prior to any operation (s), accessing the pointer.
...
[Review required] YPozdnyakov, GZharun, Paul Davis
2015-06-25 10:49:03 -04:00
Paul Davis
c12220f81a
emit SessionSaveUnderWay signal during template save
2015-06-25 10:49:03 -04:00
Paul Davis
b66e06d7c5
improved error handling and checking for Session::save_template()
2015-06-25 10:49:03 -04:00
Paul Davis
5d6dfe0c37
set micro_version, used for tracks builds
2015-06-25 10:49:03 -04:00