Commit graph

36615 commits

Author SHA1 Message Date
Robin Gareus
cd7c981e6e Use macOS API to open finder at given path 2022-12-08 02:15:29 +01:00
Robin Gareus
201617f03b Fix macOS URI open
curl_easy_escape() escapes slashes, which fails with openURL on modern macOS.
Also add missing call to curl_easy_cleanup().
2022-12-08 02:12:15 +01:00
Robin Gareus
ea50799ce2 Remove duplicate implementation
`bool cocoa_open_url (const char*)` is implemented in 
libs/pbd/cocoa_open_uri.mm
2022-12-08 01:32:41 +01:00
Robin Gareus
d3e736f7d3
Consistent audio/MIDI monitor modes
Now that both Audio And MIDI tracks support all three record
modes. Monitoring should be consistent. When recording
"Sound on Sound" does cue monitoring, while "layered" (opaque).
and "non-layered" monitors only the input.

Two differences remain: (1) when not recording MIDI tracks still
monitor both Input and Disk (unless Non-layered is set), and
a final special case is that MIDI tracks always monitor input
as fallback. the latter ties in with (2) audio tracks can
use hardware monitoring.
2022-12-07 22:49:08 +01:00
Paul Davis
b9f9531fa1 duration clocks: fix display when mode is changed 2022-12-07 12:11:31 -07:00
Paul Davis
ad9757e73c fix nudge/duration clocks when scrolling in BBT mode 2022-12-07 11:13:49 -07:00
Paul Davis
9f85a0aaba fix behavior of duration clocks when scrolling in all modes except BBT 2022-12-07 11:13:49 -07:00
Paul Davis
4beca98e28 temporal: fix various incorrect uses of ::samples() in audio time arithmetic
It is a wonder that this has not caused more visible issues since 7.0
2022-12-07 11:13:49 -07:00
Robin Gareus
313f7ad344
Use new API to compare export format/spec 2022-12-07 17:57:56 +01:00
Robin Gareus
e28e079c9f
Consolidate Export Format/Spec comparision 2022-12-07 17:56:07 +01:00
Robin Gareus
1005fc5716
Allow to import opus files 2022-12-07 13:36:57 +01:00
Robin Gareus
85a1c463e5
Add Lua method to show system env
`for v in ARDOUR.LuaAPI.env():iter() do print(v) end`
2022-12-07 00:28:21 +01:00
Robin Gareus
0abbe651ea
Remove debug output 2022-12-07 00:28:21 +01:00
Paul Davis
f37687a985 various fixes for AudioClock duration/!duration confusion 2022-12-06 11:11:08 -07:00
Paul Davis
716501defa potential fix for "/bus/... master ..." target in MIDI binding maps failing 2022-12-06 11:11:08 -07:00
Paul Davis
7850628f6f fix manual drawing of MIDI automation (avoid offset) #9142
Change assumption that the "pos" argument to AutomationRegionView::add_automation_event is region-relative, by
making it global.

This did not affect non-MIDI automation because that used
AutomationTimeAxisView::add_automation_view() instead.
2022-12-06 11:11:08 -07:00
Robin Gareus
32b6db092c
NO-OP: whitespace and comment 2022-12-06 17:30:59 +01:00
Robin Gareus
89d8dc26dd
Resolve export format ambiguities
This fixes an issue when switching formats.
ExportFormatDialog::update_selection iterates e.g. WAV BWV.
If BWV was selected and a user selects WAV the following happpens

1. WAV is selected
2. BWV is deselected
3. Since BWF and WAV are the same format, ExportFormatManager
   deselects WAV
2022-12-06 17:30:43 +01:00
Robin Gareus
e7b0df0231
Export Format Dialog: constrain sample-rates 2022-12-06 06:35:47 +01:00
Robin Gareus
d2212cbfb9
Add 24kHz as export rate, and limit opus to 8,24,48 per spec 2022-12-06 06:35:44 +01:00
Robin Gareus
c8b39094ca
Opus has no sample-formats 2022-12-06 06:35:40 +01:00
Robin Gareus
4d05c7add9
Map sndfile/opus quality to bitrate 2022-12-06 06:35:15 +01:00
Robin Gareus
4acc458a78
GUI support for OPUS encoding 2022-12-05 23:43:50 +01:00
Robin Gareus
211ff64e7d
Prepare for ogg/opus encoding 2022-12-05 23:43:34 +01:00
Robin Gareus
8a7684bd2f
Use 1|1|0 for new BBT markers, always use dialog for new markers
Amend b972301a3b
2022-12-05 19:18:26 +01:00
Paul Davis
c505024a4b temporal: when resetting the map, position BBT markers in beat time (and stop reset there) 2022-12-05 10:01:49 -07:00
Paul Davis
12b672492e tempomap: fix and improve efficiency and readability in ::get_grid() 2022-12-05 10:01:49 -07:00
Robin Gareus
8f257e1b2e
Thin MIDI automation when combining regions #9117 2022-12-04 12:12:12 +01:00
Robin Gareus
ddf894a1dd
Attempted fix for idle_drop_window random crashes (2/2) 2022-12-03 19:27:53 +01:00
Robin Gareus
2bca6395cc
Attempted fix for idle_drop_window random crashes (1/2) 2022-12-03 19:27:45 +01:00
Robin Gareus
1736b1d424
Avoid .sh file extension 2022-12-03 15:03:44 +01:00
Robin Gareus
30efb2f178
NO-OP: clang-format 2022-12-03 14:46:45 +01:00
Robin Gareus
2338e25d31
Fix automation thinning
For consistency, samples need to be used a unit.
Currently the calculated area is orders of magnitude larger
than the default thinning_factor (20).
2022-12-03 14:46:45 +01:00
John Emmas
1592b95031 Minor change - incorrect return type (in Windows build) 2022-12-03 12:21:12 +00:00
Robin Gareus
a3fdb544ee
Fix copying MIDI regions w/automation
This fixes a bug introduced in d06a0d9c9d. The MIDI data
has to be written first, otherwise the CC-event do not exit
and MidiModel::source_interpolation_changed() crashes.
2022-12-02 21:44:22 +01:00
Robin Gareus
b972301a3b
Add action to noninteractively add BBT marker at playhead 2022-12-02 21:31:56 +01:00
Robin Gareus
d808315e2a
Offer dedicated alternatives for Delete/Backspace
This follows Processor Box:
 <Binding key="Delete" action="ProcessorMenu/delete"/>
 <Binding key="BackSpace" action="ProcessorMenu/backspace"/>
2022-12-02 19:50:39 +01:00
Robin Gareus
899cacdf86
Delete/BackSpc clears selected trigger-clos 2022-12-02 19:19:20 +01:00
Robin Gareus
753d395bb3
NO-OP: add comment for mdns 2022-12-02 18:01:21 +01:00
Robin Gareus
7d928bf265
Announce OSC via mDNS 2022-12-02 17:34:10 +01:00
Robin Gareus
c53b19c039
Add zeroconf/mdns support 2022-12-02 17:32:11 +01:00
Robin Gareus
aae15e3c90
Fix Wreorder, initialize variables 2022-12-02 13:13:13 +01:00
Robin Gareus
81ccb685b2
Update CD marker Lua script, use new API 2022-12-02 13:06:29 +01:00
Robin Gareus
5d42509a21
Report error to user in startupFSM
StartupFSM does not catch SessionException from Session::load_state,
but bails out early, after checking `get_info_from_path` instead.
So we have to explicitly report errors.
2022-11-29 20:03:44 +01:00
Robin Gareus
23a0efc286
Indicate error when parsing session fails 2022-11-29 20:00:15 +01:00
Paul Davis
c312d570f4 move twist-tempo drag from tempo ruler to BBT ruler
Behavior remains unchanged, just the location/ruler for the start of the drag.
2022-11-29 10:09:39 -07:00
Paul Davis
cd86521c65 rulers: improve labelling of non-quarter note beats in tempo ruler 2022-11-29 10:09:39 -07:00
Paul Davis
8b06eb9878 editor rulers: do not try to generate "fill" ticks/lines for the grid
We now generate a grid from the TempoMap of appropriate "density". Doing this
in the editor just gets things wrong (and partially duplicates the (complex)
logic already present in the TempoMap).
2022-11-29 10:09:39 -07:00
Paul Davis
e3dc0a24f2 canvas ruler: use second font description appropriately 2022-11-29 10:09:39 -07:00
Paul Davis
148dfdd23c editor tempodisplay: use new TempoMap::get_grid() argument to get a finer grid 2022-11-29 10:09:39 -07:00