Commit graph

30559 commits

Author SHA1 Message Date
Robin Gareus
c54b36c3ff AU: only set render callbacks for connected busses
This fixes an issue with Renoise Redux. The plugin reports the following:

Reported Channel Capabilities (explicit):
      [2, 2]  [1, 2]  [0, 2]

When it is added to an Arodur MIDI track, the 0 in, 2 output variant is
chosen, since Ardour MIDI tracks don't have audio by default.

However the render callback was set uncondionally for all busses. This
lead to issues with this specific plugin.
2020-08-06 20:30:44 +02:00
Robin Gareus
357095b920
AU scan: only update config when discovering new plugins
When reading cached info only, crash protection is not needed.
2020-08-06 17:59:16 +02:00
Robin Gareus
56934284e7
Start engine for plugin scan test
This is needed for various cases. The sample-rate needs to be known,
and reading/writing config includes TFSM state, which needs an engine.
2020-08-06 17:56:08 +02:00
Robin Gareus
c6a8b848c9
Do not run plugin discovery for unit-tests
This fixes issues on MacOS (and Windows) unit-tests. The
unit-test run readless without proper UI thread. Discovering new
AU or VST can stall the app indefinitely or cause crashes.

NB. LADSPA, LV2 (and Lua) plugins are scanned regardless. Also
VST and AU cache files are read. The unit-test however only lists
LADSPA plugins.
2020-08-06 16:51:27 +02:00
Robin Gareus
6742a0961c
Ask LuaProc to drop references
This fixes a circular shared_ptr<> reference that prevents
plugin destruction.

LuaProc may hold references to Route that contains the plugin
or the PluginInsert of the LuaPlugin. These are only dropped
when the interpreter collects garbage.

Previously this happened in the d'tor or LuaProc, but while the
Plugin has a reference to the Insert, the Insert is not deleted
and the d'tor is never called.
2020-08-05 22:39:06 +02:00
Robin Gareus
c2618903ae
Allow to overload drop_references()
This is useful in cases where an object owns child objects
which in turn hold a reference to the parent.

In this case PluginInsert has-a Plugin, which may have a reference
to the insert or the Route.
2020-08-05 22:35:35 +02:00
Robin Gareus
bfccf7ba18
Don't clutter up recent list with test sessions 2020-08-05 21:55:36 +02:00
Robin Gareus
5218c104f9
Fix off by one (Lua arrays are 1-based) 2020-08-05 20:28:14 +02:00
Robin Gareus
73165aae95
Fix XMLTree double-free
XMLTree's d'tor frees all child element of the document root
2020-08-05 20:27:53 +02:00
Robin Gareus
57ef7334ef
Fix invalid iterator reference when removing plugins
processors.erase (i); invalidates the iterator and references
to the object, so we first need to try-cast and disconnect.
2020-08-05 20:24:13 +02:00
Robin Gareus
6b9a0f923b
Add a no-gain loudness preset 2020-08-04 23:36:29 +02:00
Robin Gareus
72adf2844e
Consistent naming of LAN UI elements -- #8318 2020-08-04 21:33:53 +02:00
Robin Gareus
189faf557f
Rename Loudness Volume Ctrl to LAN Amp 2020-08-04 21:32:57 +02:00
Robin Gareus
9a508735bf
Loudness Dialog: tweak button alignment and focus 2020-08-04 21:22:05 +02:00
bachstudies2020
bc84562699
Simplify initial loudness information and fix typo 2020-08-03 22:54:52 +02:00
Robin Gareus
973d52b949
Plenty of space for "Mute" on narrow master-bus 2020-08-03 22:28:46 +02:00
Robin Gareus
3bb374a473
Update Harrison plugin URL, use the resource server. 2020-08-03 17:04:26 +02:00
Robin Gareus
e486904884
Loudness Dialog: add some presets 2020-08-03 15:11:25 +02:00
Robin Gareus
6224bd7e7a
Add Volume Ctrl position to processor-box context menu
This makes it easier to discover the option, compared to hiding
it in the context menu of the slider itself.
2020-08-03 14:59:05 +02:00
bachstudies2020
b290191d75
Update loudness_dialog.cc 2020-08-02 08:57:00 -07:00
bachstudies2020
70831f6ad3
Update loudness_dialog.cc 2020-08-02 08:37:06 -07:00
Robin Gareus
40fd205566
Increase contrast of yellow alert text on bg
Interpolate lightness between alert:red (95%) and alert:green (80%).
2020-08-01 10:21:30 +02:00
Robin Gareus
34d6e02d65
Tweak Loudness dialog labels 2020-08-01 10:14:38 +02:00
Robin Gareus
8b5737b8d2
Increase precision of numeric dB entry
This follows 5a41ca8fdf and df1e6fda2d.
Even though this kind of precision is rarely needed, rounding
to a single digit is inconsistent with various places that display
more than one digit, or allow more accurate control.
2020-08-01 09:57:18 +02:00
Robin Gareus
c2ffa07e28
Pre-seed scripts: add "List Plugins" 2020-08-01 01:17:39 +02:00
Robin Gareus
0c6d369434
Tweak list-plugins script & add icon 2020-08-01 01:15:57 +02:00
Robin Gareus
7e5e9e46a1
Consolidate calls to IO::latency 2020-08-01 00:17:54 +02:00
Robin Gareus
41c503768b
NO-OP: comment formatting
Use asterisks to separate indent (tabs) and alignment (spaces)
in comments. Also remove trailing whitespace.
2020-08-01 00:17:23 +02:00
Nikolaus Gullotta
13f041536d
Honor "Auto Play" setting when locating from Session::goto_start
Because TransportFSM's MotionState is `WaitingForLocate` when calling
Session::goto_start, transport_was_stopped was set incorrectly
2020-07-29 10:33:29 -05:00
Ben Loftis
76894b0ac3 When consolidating a Range of midi, the resulting region should fill the Range (not stop at the end of midi content) 2020-07-28 12:29:27 -05:00
Robin Gareus
591292da0f
a-amp: special case empty pin-mapping mode 2020-07-27 22:03:53 +02:00
Robin Gareus
60062e6b43
Allow to toggle main-out volume custom position from the mixer-strip
(this is not necessarily click-free)
2020-07-27 22:02:09 +02:00
Robin Gareus
185bd62117
Loudness Dialog: use MainOut-Volume instead of a-amp 2020-07-27 22:00:08 +02:00
Robin Gareus
2b7b36be3e
Special case MainOutVolume Amp processor in ProcBox
Do not allow to delete or disable the processor.
2020-07-27 21:58:57 +02:00
Robin Gareus
e9ff843bb1
Implement master/loudness volume processor
This provides for a better user-experience than using a-amp.
Particularly since a-amp only has a 20dB range and can be automated.
2020-07-27 21:56:41 +02:00
Robin Gareus
5b734e819c
Loudness dialog: implement conformance check 2020-07-27 20:00:17 +02:00
Robin Gareus
44fc824128
Update Lua script to use new bounce API 2020-07-26 17:17:49 +02:00
Robin Gareus
22ab752924
NO-OP: whitespace 2020-07-26 17:17:33 +02:00
Robin Gareus
b49656213d
Prefer const reference (amend f564c92493) 2020-07-26 17:15:15 +02:00
Ben Loftis
aca062505b Region List: do not show empty MIDI regions 2020-07-26 09:53:48 -05:00
Ben Loftis
5cdaa5f935 Source list: some tweaks to match Region list 2020-07-26 09:53:48 -05:00
Ben Loftis
dc2fe9edbe Region List: add a dedicated column for channelcount 2020-07-26 09:53:47 -05:00
Ben Loftis
d0abe7e742 Consolidate action adds a whole-file region (for the Source list) AND a region on the timeline (just as if you recorded it) 2020-07-26 09:53:47 -05:00
Ben Loftis
a8c29991d6 Assign a take_id to Bounced regions, so a multitrack bounce can be sorted/recognized in a list 2020-07-26 09:53:47 -05:00
Ben Loftis
af4ab3708b Source List: allow Name field to be edited 2020-07-26 09:53:47 -05:00
Ben Loftis
cdee15b780 Source List: Add captured_for as a column. 2020-07-26 09:53:47 -05:00
Ben Loftis
4f6c71f275 Use the Track name in captured_for property (was processor:playlist which was obtuse) 2020-07-26 09:53:47 -05:00
Ben Loftis
d98d3f25d8 Source List: Add channel-count as a separate column 2020-07-26 09:53:47 -05:00
Ben Loftis
80a7d32e07 Prompt user for name of Range and Region bounces (gtk part) 2020-07-26 09:53:47 -05:00
Ben Loftis
f564c92493 Prompt user for name of Range and Region bounces (libardour part) 2020-07-26 09:53:47 -05:00