Commit graph

33565 commits

Author SHA1 Message Date
Paul Davis
c0720c7a4c don't show standalone triggerbox window after adding tracks with a triggerbox 2021-10-10 13:53:45 -06:00
Paul Davis
187ef1c214 triggerbox: better implementation of mono/stereo/nchannels mapping fix 2021-10-10 13:53:24 -06:00
Paul Davis
c2004772c4 triggerbox: map available channels across all output channels
This means that mono regions get played in stereo (or higher)
2021-10-10 13:10:20 -06:00
Paul Davis
cf8f0b4702 triggerbox: respond to changes in default trigger input port (GUI) 2021-10-09 16:59:07 -06:00
Paul Davis
55209b5df7 triggerbox: respond to changes in default trigger input port 2021-10-09 16:58:58 -06:00
Paul Davis
52decdd1b4 push2: prevent crash caused by missing per-thread tempo map ptr 2021-10-09 11:47:13 -06:00
Paul Davis
3475350d7c push2: session button should be lit 2021-10-09 11:46:53 -06:00
Paul Davis
4031a03588 triggerbox: start some attempts at complexifying MIDI note -> trigger mapping 2021-10-08 20:35:25 -06:00
Paul Davis
af02413aef derive TriggerPortSelectionOption for trigger default input port preference (incomplete) 2021-10-08 17:04:07 -06:00
Paul Davis
e677863424 refactor LTC port option element to make it re-usable 2021-10-08 16:34:08 -06:00
Paul Davis
9792901376 add new rc config var to identify the default trigger input port 2021-10-08 14:40:44 -06:00
Paul Davis
9ca287dbdb triggerboxUI: hide/show trigger play/stop buttons when entering/leaving trigger (logic-y experiment 2021-10-08 13:45:27 -06:00
Paul Davis
305c9ba6e9 triggerboxGUI: use new API and tweak add route dialog to allow choice to add triggerbox 2021-10-08 13:45:27 -06:00
Paul Davis
6326222a48 triggerbox: change APIs so that we can add a triggerbox to either type of track 2021-10-08 13:45:27 -06:00
Paul Davis
7e35714886 triggerbox: change default MIDI note triggers to match first vertical row of Push 2 2021-10-08 13:45:26 -06:00
Robin Gareus
13168bb5b2
Disambiguate error message 2021-10-08 04:13:06 +02:00
Robin Gareus
8e5af55ae5
Prevent identical port-names when renaming tracks
Audio ports are sorted using PBD::naturally_less.
PBD::naturally_less is also used as compare function
for port-lists, port-sets, and port-maps.

So in sets and maps, the function is used to test
for uniqueness. This lead to issues since naturally_less
treats whitespace and underscores as identical.

While it was possible to have routes named "Audio_1",
and "Audio 1", this resulted in missing ports for one
of the routes.

see also 60ff3ef764
2021-10-08 04:12:55 +02:00
Robin Gareus
ba2a2cb654
Implement natural-sort spaceship operator 2021-10-08 04:12:32 +02:00
Paul Davis
97f323137c triggerbox: initial (incorrect) attempt at handling tempo map changes 2021-10-07 08:03:46 -06:00
Paul Davis
3ddfdbc790 triggerboxUI: start adding per-slot event handling 2021-10-07 07:57:47 -06:00
Paul Davis
6daf0f0451 triggerbox UI: fix usual ambiguity on macOS etc. when using "Rect" 2021-10-07 07:48:07 -06:00
Paul Davis
7e2dd8a718 triggerbox: add follow count support 2021-10-07 07:48:07 -06:00
Robin Gareus
05df62ed79
Amend fdf1c1aba2, don't unconditionally show plugin-manager 2021-10-07 03:47:00 +02:00
Robin Gareus
fdf1c1aba2
Show plugin-manager when missing plugins are found 2021-10-07 03:10:48 +02:00
Robin Gareus
1c1f48fd98
VST: Remove accidentally added factory reference 2021-10-07 01:46:44 +02:00
Robin Gareus
789949ed8e
VST3: properly take references, ignore controll == component cases
This is mainly motivated by DPF's new VST3 implementation, but
also takes a leaf out of JUCE's book, unconditionally initializing
the VST::IEditController even if it is-a VST::IComponent.
and likewise calling terminate().
2021-10-07 01:08:27 +02:00
Paul Davis
28784a0da7 triggerboxUI: change progress display to partial width, thin horizontal line 2021-10-06 15:21:44 -06:00
Paul Davis
0bace97916 triggerboxUI: shrink font size 2021-10-06 15:21:44 -06:00
Paul Davis
d4d4298320 triggerbox: add Chris Cannam's minibpm and use to determine tempo and thus stretch 2021-10-06 15:21:44 -06:00
Paul Davis
1c4e1d01a7 triggerbox: an attempt at parameterizing the expected trigger duration 2021-10-06 15:21:44 -06:00
Paul Davis
0199a4e561 triggerbox: basic stretch test using assumption that slot holds s 4 bar region 2021-10-06 15:21:44 -06:00
Robin Gareus
bbbfadb832
VST3: initialize controller even if it is-a component 2021-10-06 21:35:08 +02:00
Robin Gareus
cc084ef0a7
Fix setting custom path to the video monitor on macOS 2021-10-06 05:06:39 +02:00
Paul Davis
89c17dfe7d remove debug output 2021-10-05 14:00:34 -06:00
Paul Davis
dadf530243 temporal: change loading of session format 3x tempo maps
We were attempting to add the initial tempo and meter twice, which was unwise
2021-10-05 13:57:10 -06:00
Paul Davis
248d7e5980 prevent trim-dragging that doesn't change region duration from incorrectly resetting fades 2021-10-05 10:43:24 -06:00
Paul Davis
8bdb8f51fd remove debug output 2021-10-04 17:47:55 -06:00
Paul Davis
0acc1a3fec temporal: use correct implementation of timepos_t::operator+ (timecnt_t) (and +=)
If time domains differ, it is necessary to first convert the argument duration into a duration
at the position of "this", in the correct time domain. Then we recursively call the operator
again, but this time we will use the fast path that just adds two timepos_t values.
2021-10-04 17:45:02 -06:00
Robin Gareus
5925ee0b7c
Prevent processing until buffersize change is complete
This fixes async callback from CoreAudio via
AudioDeviceAddPropertyListener. Apparently in rare cases it can
happen that the property listener calls back concurrently with
processing on M1 machines using Rosetta.

https://pastebin.com/upvc9LTc Thread 44 vs. Thread 32

May also be caused by plugin(s) taking a long time to
change buffersize. Processing continues even though the
buffersize callback has not yet completed.

PS. I have not been able to reproduce this on an Intel
machine, even with excessive buffersize changes. However
since buffersize changes cannot (usually) happen concurrently
with processing, taking the lock is reasonable.
2021-10-04 22:30:08 +02:00
Robin Gareus
e2efb698e0
VST3: fix discrete parameters
Some plugins have a min/max range of 1, for stepwise enumerated
values of a control. e.g. waves maps note-names this way.
https://discourse.ardour.org/t/106429/
2021-10-04 17:07:53 +02:00
Robin Gareus
877f56e575
Add Lua binding for ParameterDescriptor::rangesteps 2021-10-04 17:07:53 +02:00
Paul Davis
949e3eadc9 triggerui: fix map/unmap confusion 2021-10-04 01:30:32 -06:00
Paul Davis
dc4d94b4ee triggerui: basic progress bar for trigger slots 2021-10-03 23:47:47 -06:00
Paul Davis
5caed9b0a6 trigger: add method to get position while playing as a fraction 2021-10-03 22:44:03 -06:00
Paul Davis
a1699ff612 canvas: size_allocate() from GTK gives origin in parent coordinates.
Convert to canvas-relative origin when passing to root group for allocation
2021-10-03 19:47:18 -06:00
Paul Davis
b5c584befa triggerbox UI: make it respond to size_allocate() 2021-10-03 16:46:39 -06:00
Paul Davis
e670acbb0d canvastable: fix logic error in ::compute_bounding_box()
Since the bbox is determined by ::compute(), do not unconditionally clear it here
2021-10-03 16:46:25 -06:00
Paul Davis
bfc3c51052 triggerUI: somewhat functioning inline trigger box UI 2021-10-03 12:29:26 -06:00
Paul Davis
7d0c67e376 Revert "A small experiment to try '#pragma GCC warning'"
This reverts commit 808bfe0916.

This pragma syntax is not compatible with gcc
2021-10-03 09:10:14 -06:00
Paul Davis
acac302063 first steps in displaying triggerbox UI inside mixer strip (non-functional) 2021-10-03 09:09:01 -06:00