David Robillard
b4fcdbb100
Don't add origin value to MIDI controller regions on initial insert.
...
This should probably hijack the same modifier as the guard points and work the
same on all automation tracks, but I did it this way to not change behaviour of
track automation where a default is much more reasonable.
2014-11-16 22:35:45 -05:00
David Robillard
d63161426f
Add "maybe" rounding modes for rounding only if necessary.
2014-11-16 22:35:45 -05:00
David Robillard
fd9ccc7058
Use an enum for RoundMode instead of magic numbers.
...
No functional changes in this one (for easier auditing), but towards having
round up/down only if necessary modes, rather than kludging around that
situation with a double round as we do currently.
2014-11-16 22:35:45 -05:00
David Robillard
9d4f43fa7d
Make ControlList::paste const-correct.
2014-11-16 22:35:45 -05:00
Robin Gareus
df40782b62
prevent segfault if in/out property is missing
2014-11-17 04:05:00 +01:00
Robin Gareus
ad739cd018
add some assert() messages.
...
as hints clang static analyzer "Called C++ object pointer is null"
2014-11-17 03:49:19 +01:00
David Robillard
333c776e0e
Fix MIDI region keyboard editing (add key handling to canvas).
2014-11-15 02:04:28 -05:00
David Robillard
b52407043c
Fix crash when copying MIDI regions with midi-copy-is-fork is on ( #6002 ).
2014-11-14 23:53:59 -05:00
David Robillard
94954f852e
Fix out of order event errors on save with overlapping notes.
...
Another consequence of fuzzy Sequence timing, but if the difference is less
than a tick this should handle things correctly. If the difference is more
than a tick, something's wrong, and it might be okay to just bump forward
anyway, but I can't reproduce this and it could lead to corruption so I'm
leaving that case noisy.
2014-11-14 21:19:09 -05:00
Robin Gareus
6b3a8915f3
add abort() to non-reached code
...
This cleans up a lot of false-positives in static analysis
and also helps compilers to optimize code paths in general.
(tagging the fatal stingstream operator as ‘noreturn’ is
far less trivial)
2014-11-14 11:30:08 +01:00
David Robillard
8907477271
Fix crashes on various MIDI editing operations.
...
Assertions assumed old strict ordering, no longer reflecting reality of fuzzy
time comparison (introduced in 86f1b8).
2014-11-13 22:34:20 -05:00
Robin Gareus
4ba4677b45
yet another copy/paste typo :(
2014-11-13 22:19:22 +01:00
Robin Gareus
9301ffafab
fix typo in b9fc616538
2014-11-13 21:46:30 +01:00
Robin Gareus
b376f6bc45
auto-initialize weak-jack
...
(not needed with ardour - but keep code in sync with
https://github.com/x42/weakjack )
2014-11-13 21:31:09 +01:00
Robin Gareus
b9fc616538
prepare for JACK meta-data API
2014-11-13 21:30:13 +01:00
Robin Gareus
65fa38103d
make new jack thread API functions optional
2014-11-13 21:29:34 +01:00
Robin Gareus
7b39e0893a
add symbol debug information to weak-jack
2014-11-13 21:28:33 +01:00
Robin Gareus
cb38034334
install all additional binaries in $libdir
2014-11-13 19:57:40 +01:00
Robin Gareus
9a9a8f78ef
fix define
2014-11-13 19:05:58 +01:00
John Emmas
0689a2976e
Don't iterate in 'ARDOUR::Route::get_control()' unless a ReaderLock was successfully obtained
2014-11-13 13:07:34 +00:00
John Emmas
e59e8f6ab9
Make sure we can't execute 'ARDOUR::Route::meter()' unless a ReaderLock was successfully obtained
2014-11-13 12:13:16 +00:00
Robin Gareus
3e702c5520
yet another build fix
...
on x86_64 weak_libjack.c needs -fPIC which needs cflags which need 'c' :)
2014-11-13 01:02:09 +01:00
Robin Gareus
533b545295
add popup message and error log for AU crash reports
2014-11-12 13:35:15 +01:00
Robin Gareus
5624301a31
Prepare AU-discovery crashlog.
...
stopgap solution to allow a user to detect which plugin caused a crash during discovery.
2014-11-12 13:34:46 +01:00
Robin Gareus
1bc04ae351
failsafe AU scanning part one:
...
Don’t scan for AU plugins unless users explicitly starts a
plugin scan. Disable automatic scanning if Ardour crashes
during AU plugin discovery.
2014-11-12 04:58:53 +01:00
Paul Davis
9254e80c39
refactor MIDISceneChange color property addition by moving it into SceneChange to anticipate other types of SceneChange objects (e.g. OSC)
2014-11-10 23:17:27 -05:00
Paul Davis
e27651d315
when creating a new MIDI scene change, check existing scene changes for equality and reuse their color (which may or may not be set)
2014-11-10 23:17:19 -05:00
Paul Davis
0f243d5f7c
serialize/deserialize MIDISceneChange color; put out of bounds color into static const
2014-11-10 23:17:08 -05:00
Paul Davis
70960a5a00
add color property to MIDISceneChange
2014-11-10 23:16:59 -05:00
Paul Davis
3d0efb8bf7
add operator== to ARDOUR::MidiSceneChange
2014-11-10 23:16:53 -05:00
Paul Davis
12b715e6fa
tweak canvas on_expose_event() handler to avoid unnecessary save/paint/restore
2014-11-10 20:34:20 -05:00
Paul Davis
fdcb792358
further work on new color manipulation code
2014-11-10 20:33:54 -05:00
Robin Gareus
929d3fe6ed
fix signed/unsigned compiler warning
2014-11-10 22:21:39 +01:00
Robin Gareus
a37ffd1f0c
improve random seed (for dummy generators)
2014-11-10 22:20:36 +01:00
Paul Davis
1317b57221
add required header for compilation
2014-11-10 11:46:17 -05:00
Paul Davis
ef56948d4a
add background color property to Canvas::Canvas ; rearrange expose handling and include background fill
...
Conflicts:
libs/canvas/canvas.cc
libs/canvas/canvas/canvas.h
2014-11-10 10:43:25 -05:00
John Emmas
9cf5b23392
Modifications needed to build ReasonableSynth with MSVC
2014-11-09 08:11:46 +00:00
John Emmas
373caeede8
Add some newly introduced source files to our MSVC project (cairocanvas)
2014-11-08 10:48:26 +00:00
David Robillard
bb12c750bb
Just rename problematic Variant::VOID type.
2014-11-07 17:21:43 -05:00
Paul Davis
4260d0ca0e
use new canvas colors header as necessary
2014-11-07 14:24:27 -05:00
Paul Davis
69fd25f6f4
move canvas colors code into its own file(s)
2014-11-07 14:24:13 -05:00
Paul Davis
a441de1a18
when drawing only part of a Canvas::Rectangle outline, we only need to do the cairo-pixel alignment math for the axis perpendicular to the edge
2014-11-07 12:58:56 -05:00
Robin Gareus
87cd481a7d
VOID is a windows define (not MSVC specific)
2014-11-07 17:04:11 +01:00
Robin Gareus
0fedfab593
tentative fix for canvas background/image surface
2014-11-07 16:50:21 +01:00
Robin Gareus
159cb4d2f9
another hack for windows timers, DSP load calculation
2014-11-07 12:17:15 +01:00
Paul Davis
7670e463cc
add API to extract color from ArdourCanvas::Text and tidy up member declarations
...
Conflicts:
libs/canvas/canvas/text.h
2014-11-06 20:38:02 -05:00
Paul Davis
787f9748b6
changing the clamp_width of an ArdourCanvas::Text needs to potentially provoke an entire redraw
...
This fixes missing range marker text in sessions where the initial zoom value causes an initial clamp_width of zero
2014-11-06 20:38:02 -05:00
Robin Gareus
6cda13fad4
possible fix for DSP load calculation on windows
2014-11-06 17:29:35 +01:00
Paul Davis
c9c4a5c29d
raising/lowering canvas items should trigger a redraw
2014-11-06 10:58:37 -05:00
Paul Davis
ecd618c343
correct the rendering of Rectangle outlines, and the computation of their bounding box
2014-11-05 19:45:23 -05:00