Commit graph

40059 commits

Author SHA1 Message Date
agfline
a70a2a2bbb
AAF: fix NULL pointer dereference 2024-11-27 01:38:37 +01:00
Robin Gareus
32df0a8ff6
Postpone RoutePropertiesBox plugin refill until idle
This fixes an issue with some plugin UIs being initially
empty. e.g. GMSynth.lv2 or ACE-Fluidsynth. The UI depends
on the plugin provided MIDNAM and bank/patch information
which is only loaded after the plugin is instantiated.
2024-11-27 01:07:52 +01:00
Robin Gareus
09216ef5d5
Add API to report if plugin UI has any controls 2024-11-27 00:50:00 +01:00
Robin Gareus
9095f2fde3
Tweak property box plugin UI layout 2024-11-26 23:08:36 +01:00
Paul Davis
2096ff7876 cue editor end dragging operational 2024-11-26 13:11:17 -07:00
Paul Davis
af0162c73c add colors for cue editor end boundary 2024-11-26 11:54:16 -07:00
Paul Davis
c90b19a954 add colors for cue editor start boundary and use them 2024-11-26 11:35:30 -07:00
Paul Davis
73847a9b42 use correct Region API for adjusting the start position in the cue editor 2024-11-26 08:39:32 -07:00
Paul Davis
2eece78718 stop leftward drags from corrupting clip start 2024-11-25 21:37:55 -07:00
Paul Davis
bbdc87b6fa midi cue editor: Trigger::current_pos() is relative to the region start, so fix playhead position 2024-11-25 21:37:31 -07:00
Paul Davis
ecd3cf8766 improved ("working") clip start drag 2024-11-25 21:16:15 -07:00
Paul Davis
9243dcf961 draw clip rect correctly after it is reset\n 2024-11-25 18:30:01 -07:00
Paul Davis
efc153d880 actually set trigger start to where mouse was released when dragging 2024-11-25 18:16:56 -07:00
Paul Davis
5ef4f8973f somewhat sort of working clip start drag (GUI edition) 2024-11-25 17:54:15 -07:00
Paul Davis
8c0c9cc115 somewhat sort of working clip start drag 2024-11-25 17:54:15 -07:00
Robin Gareus
7874cc74e5
Fix Mixbus builds 2024-11-25 23:21:43 +01:00
Paul Davis
c39de501a3 triggerbox: significantly re-design MIDI Triggers to allow for bounds editing 2024-11-24 13:25:58 -07:00
Paul Davis
7af9442098 NO-OP: add explanatory comment 2024-11-24 13:25:58 -07:00
Paul Davis
53773bb8cb send correct property change for MIDI trigger when region changes
This may need an adjustment in the GUI
2024-11-24 13:25:58 -07:00
Paul Davis
83f501f084 send correct property change for audio trigger when region changes
This may need an adjustment in the GUI
2024-11-24 13:25:58 -07:00
Robin Gareus
dac39fd8cb
Skip Channelstrip plugins in Route Property Box 2024-11-23 22:03:14 +01:00
Robin Gareus
263faa09ae
Set size-request for generic preset plugin UIs 2024-11-23 21:53:12 +01:00
Robin Gareus
345337da35
Return to some sane automation control point size
Default size was increased from 4 to 12 during 90c8726c6d,
apparently a copy/edit accident. This slightly increases point
size when increasing lane height.
2024-11-23 21:17:36 +01:00
Paul Davis
465f39e5bf create nonfunctional clip boundary drags when appropriate 2024-11-23 09:06:38 -07:00
Paul Davis
3feaf2046c fix inadvertent partial line deletion 2024-11-23 09:06:38 -07:00
Paul Davis
8064353a82 fix/remove on the current #warnings arising from the pianorule refactor 2024-11-23 09:06:38 -07:00
Robin Gareus
448914b4cc
Change default file-format to wav compatible RF64 2024-11-23 17:04:25 +01:00
Robin Gareus
9f6d3baa93
Use key bindings for region property (Fx) box
This is required to allow to delete RegionFX plugins
when the region-editor is shown in the main window, rather
than its own window.

Otherwise the Editor would handle delete/backspace and
instead remove the region.
2024-11-23 16:35:10 +01:00
Ben Loftis
23ba0f8338 fix for 'green' canvas redraws: cairo expects x,y,w,h not x,y,x+,y+ 2024-11-23 08:43:44 -06:00
Robin Gareus
e701bee270
Fix small typo in build script 2024-11-23 10:56:16 +01:00
Robin Gareus
d28a13c9cc
Make route selections idempotent 2024-11-23 10:56:16 +01:00
Robin Gareus
98d8455098
Fix crash when selecting VCA 2024-11-23 10:56:16 +01:00
Paul Davis
9ab42f8d14 fix error in hastily introduced DEBUG_TRACE statement 2024-11-22 09:34:45 -07:00
Paul Davis
d5cc1b5efc initial steps to trigger start/end point display and editing 2024-11-22 09:33:38 -07:00
Paul Davis
a162250682 fix MIDI triggers where region start/end are not the source start/end 2024-11-22 09:33:38 -07:00
Robin Gareus
4e55570934
mac: mitigate "device busy" chances when ejecting DMG 2024-11-22 16:23:03 +01:00
Paul Davis
4fbdf0d680 macOS: catch spurious full redraw calls to NSView:drawRect and act appropriately 2024-11-21 14:07:31 -07:00
Robin Gareus
04fe2b5aa8
Push default cursor at the top of the stack
see also f598f4e4e0
2024-11-20 19:01:22 +01:00
Robin Gareus
940e1bc2df
NO-OP: rename layout widgets for clarity 2024-11-20 18:56:20 +01:00
Robin Gareus
218b264c60
Use evenbox as parent for main window content
This fixes an issue with mouse-cursor contexts.
Eventbox is backed by a [gdk] window, each of which
has their own Gdk::Window::set_cursor.
2024-11-20 18:42:38 +01:00
Paul Davis
fc91c7b92d prevent canvas piano roll header scroomer drag pushing the same cursor over and over 2024-11-19 16:31:55 -07:00
Paul Davis
28e638deac undo a change the broke cursor management
push push pop pop must always work, even if the two pushes are for the same cursor
2024-11-19 16:31:36 -07:00
Paul Davis
f598f4e4e0 potential fixes for SNAFU with cursors 2024-11-19 16:04:41 -07:00
Robin Gareus
4a99026cc9
Revert "Replace boost::aligned_storage with alignas std::array"
This reverts commit 32ff87f7f6.

This causes issues on macOS/clang
```
../libs/pbd/pbd/stack_allocator.h:152:53: note: destructor of 'StackAllocator<std::__tree_node<std::__value_type<ARDOUR::DataType, std::map<unsigned int, unsigned int, std::less<unsigned int>, PBD::StackAllocator<std::pair<const unsigned int, unsigned int>, 16>>>, void *>, 2>' is implicitly deleted because field '_buf' has a deleted destructor
  152 |         alignas(16) std::array<value_type, stack_capacity> _buf;
```
2024-11-19 18:03:23 +01:00
Robin Gareus
2a620c64e9
Show plugin UIs in Route Property Box 2024-11-19 17:45:29 +01:00
Robin Gareus
49c7464b9c
Allow to move (cut/paste DnD) region FX
This also prevents copying effects to another RegionFX
Box of the same region (e.g. when using Region Property
Bottom Pane)
2024-11-19 17:45:26 +01:00
Robin Gareus
d8a197a63f
Implement Editor Region Properties 2024-11-19 17:45:21 +01:00
Robin Gareus
00f3ce2e76
Remove unused property boxes, prepare for Region Editor
Using that old template code would introduce significant
tech-dept.

This also properly initializes the selection property box
and handles edge cases during session setup and deletion.
2024-11-19 17:41:55 +01:00
Robin Gareus
c35fa54b3f
Refactor RegionEditor to be a Widget 2024-11-19 17:37:12 +01:00
Robin Gareus
3c5681b2c9
Add option to only show controls in generic plugin UI
The intention here is to show a minimal UI in the
Route Property Box
2024-11-19 17:37:06 +01:00