Commit graph

14820 commits

Author SHA1 Message Date
Robin Gareus
76334847c5 quick sanity check 2014-11-25 10:35:50 +01:00
Robin Gareus
8a58ffd151 NOOP, fix some “missing sentinel” -Wformat 2014-11-25 10:23:10 +01:00
David Robillard
a2475509e5 Check for clang with an actual code check.
Turns out Apple in its infinite wisdom installs clang as /usr/bin/g++, so
guessing based on executable name doesn't work.
2014-11-25 02:20:21 -05:00
David Robillard
ea5876b836 Remove dead code. 2014-11-25 02:11:44 -05:00
David Robillard
8b268344f9 Shup up clang about gtkmm/papertraits.h. 2014-11-25 02:08:35 -05:00
David Robillard
9dd8024e41 Don't add non-clang flag regardless of platform. 2014-11-25 02:07:40 -05:00
David Robillard
634a348296 Fix clang check for versioned clang executables. 2014-11-25 02:07:07 -05:00
Paul Davis
d953f1ce0e when dragging on the canvas, use x,y pointer coordinates to decide if motion has occured.
Using _last_pointer_frame breaks when dragging to the left of the canvas, because we clamp
the value of the frame to >= 0. Motion would step once the pointer crossed the left edge
of the canvas because the frame value would always be zero.

This is not a problem when using the pointer x,y values which end up appropriately negative
under all conditions.
2014-11-24 21:59:29 +02:00
Robin Gareus
78218e8c07 fix OSX open URL in browser 2014-11-24 20:35:38 +01:00
John Emmas
da6062a0b9 Add a newly introduced header file to our MSVC project (gtk2_ardour) 2014-11-24 13:01:16 +00:00
John Emmas
bf2625de40 Now that we're building pango's language modules statically (i.e. no longer as DLLs) it's not necessary to edit the user's 'pango.modules' file 2014-11-24 12:58:26 +00:00
John Emmas
c7ddedc5b8 Simulate 'trunc()' which isn't available in MSVC
(needed by 'gtk2_ardour/editor.cc')
2014-11-24 12:56:07 +00:00
John Emmas
018f559aad Remove a commented out line in 'pbd/stacktrace.h'
(was probably just needed for testing at some stage)
2014-11-24 12:53:24 +00:00
John Emmas
25745758aa Changes needed to accommodate building libevoral with MSVC
Note that class 'MusicalTime' needn't be exportable (with a little work, this could be reverted if it affects the other builds)
2014-11-24 12:51:54 +00:00
Robin Gareus
7b3263891f waf is fun 2014-11-24 04:56:31 +01:00
Robin Gareus
2bdf9e447f OSX gcc does not support local-typedef warning 2014-11-24 04:24:58 +01:00
Robin Gareus
3a7652200d also search for 32bit xjadeo on 64bit windows 2014-11-24 01:43:31 +01:00
Robin Gareus
c0e8647806 amend c4533939b9 2014-11-24 00:04:45 +01:00
Robin Gareus
3aea7af3fd lost quote 2014-11-24 00:00:58 +01:00
Robin Gareus
cd91fa0046 hotfix windows-compilation (unfinished bfe49540b9)
..at least it compiles and starts. Mackie support etc
is probably still broken.
2014-11-23 23:57:56 +01:00
Robin Gareus
1b6cbf743b update harvid & ffmpeg binary path discovery on windows (64 & 32 bit) 2014-11-23 23:57:55 +01:00
Robin Gareus
8ddeb712f6 make debug message more useful 2014-11-23 23:57:55 +01:00
Robin Gareus
5aba4df252 fix/silence various compiler warnings.
* ifdef unused static functions
* brackets around assignment and comparision
* no return statement in function returning non-void
* boost concept_checks.hpp unused-local-typedefs
2014-11-23 23:57:55 +01:00
David Robillard
f1926dc863 Fix build with a certain awful broken compiler. 2014-11-23 16:31:59 -05:00
Robin Gareus
ec01682714 -Wunused-function on windows 2014-11-23 21:01:39 +01:00
Robin Gareus
40764f4cb3 use NULL not 0 for c-functions (even in c++ code)
4.3 KBytes less compiler warnings.
2014-11-23 21:01:39 +01:00
Paul Davis
bfe49540b9 remove use of CrossThreadChannel::selectable() to allow cross-platform implementation of CrossThreadChannel via Glib::IOSource 2014-11-23 17:37:13 +02:00
Paul Davis
dcf632d99f assign minsec_ruler_scale and minsec_mark_modulo when zoomed very far out
Avoids crash when computing % minsec_mark_modulo.
2014-11-23 14:36:38 +02:00
David Robillard
57c1b6e261 Fix quantization and other time-related ops. 2014-11-22 21:49:42 -05:00
David Robillard
231e0009b4 Max is max and min is min and I am dumb. 2014-11-22 16:33:32 -05:00
David Robillard
bed95a64a0 Fix note resizing. 2014-11-22 15:33:40 -05:00
David Robillard
42b5ed3904 Fix clang and MSVC build. 2014-11-22 15:26:41 -05:00
David Robillard
73ad993597 Fix invisible discrete control points. 2014-11-22 04:39:30 -05:00
David Robillard
c1cfa12d6e Wrap MusicalTime in a class.
This lets us get a more explicit handle on time conversions, and is the main
step towards using actual beat:tick time and getting away from floating point
precision problems.
2014-11-22 04:05:42 -05:00
David Robillard
cae74309a5 Fix assert failure in control list interpolation.
How we never hit this before is beyond me, it's in some ooooold code.
2014-11-22 00:46:15 -05:00
David Robillard
01493b14cf Fix const violation warnings in tempo.cc. 2014-11-22 00:46:15 -05:00
David Robillard
24f7eccc86 Factor out copy-paste code to get grid type in beats defaulting to 1. 2014-11-22 00:46:15 -05:00
David Robillard
41a9060df9 Move time converters only to the region views that actually need them.
A step towards sorting out time issues more solidly, the time situation of MIDI
region views and automation region views is slightly different.
2014-11-22 00:46:15 -05:00
Robin Gareus
2966dd4a9f add a variable to specify windows build concurrency 2014-11-21 23:12:17 +01:00
David Robillard
4bc0d1c475 Fix lost MIDI note offs and controllers.
Fix initial read of discrete MIDI controllers.

Fix spurious note offs when starting to play in the middle of a note.

Faster search for initial event when cached iterator is invalid.

So much for dropping the cached iterator.  The iterator is responsible for
handling note offs, so that doesn't work.  This design means we have some stuck
note issues at the source read level, but they should be taken care of by the
state tracker anyway.
2014-11-20 15:36:11 -05:00
David Robillard
8bba63282a Reduce unnecessary non-const MIDI buffer access. 2014-11-20 15:32:06 -05:00
David Robillard
7def8de5a3 Use memento_command_binder() to (probably) fix MSVC build and other things.
Remove ugly hack that does the same thing.
2014-11-20 12:01:39 -05:00
David Robillard
8f8a4878f3 Clean up some MIDI code. 2014-11-20 11:31:31 -05:00
David Robillard
9d8bbf4b9a Remove unused variables. 2014-11-20 11:31:31 -05:00
Robin Gareus
0c4869dc35 debug trace lost midi-messages 2014-11-20 02:46:30 +01:00
David Robillard
a9936205b1 Fix dropped MIDI events, especially with record enabled.
I am not precisely sure why the cached iterator was causing this problem, it
shouldn't be invalidated, and the times make sense.  It may be some lock
related issue since the iterator holds a lock on the source.

In any case, this cached iterator was just to avoid repeated linear search of
the model, but since the model has a logarithmic search, instead just scrap all
this problematic persistent state and search for the appropriate start time
every read.  No need to be careful about invalidating when anything changes.
2014-11-19 19:24:16 -05:00
Ben Loftis
4ffdc99c5f fix range selection of mixer strips; shift+selecting a single strip would select from there til the end 2014-11-19 17:27:13 -06:00
Robin Gareus
e3e85a92db some const'ness and hints for clang 2014-11-19 20:38:50 +01:00
Robin Gareus
cc5f5c7738 copy hotspots file when packaging windows cursors 2014-11-19 00:21:32 +01:00
Robin Gareus
9bac4df9ec also load hotspot file (if it exists) for default cursors 2014-11-19 00:21:31 +01:00