Robin Gareus
6a741689d1
Consolidate calls to `pthread_create' (1/2)
2024-09-28 03:15:48 +02:00
Robin Gareus
8d3ebde60e
Distinguish Threads and ThreadName debugging
...
This also allows for -DThread to enable both.
We celebrate the 128th debug bit and look forward to
the next 64!
2024-09-28 03:15:36 +02:00
Robin Gareus
c4fdd5356c
Enable debugging for stored threads
2024-09-28 03:14:16 +02:00
Robin Gareus
301777e7fe
Remove cruft
2024-09-27 18:03:11 +02:00
Robin Gareus
71a3161252
Error handling for 3751d20ce
2024-09-27 17:20:42 +02:00
Robin Gareus
3751d20ce9
Use dedicated thread to start export timespans #9798
...
This addresses an issue with creating a one-shot thread
directly from the realtime callback, which can be problematic
on Windows.
2024-09-27 06:00:15 +02:00
Robin Gareus
d8e4e7b259
Fix calculating intersection of waveform rectangle
...
see also 68eb63e0c8
2024-09-27 02:54:35 +02:00
Robin Gareus
9945d7721f
Allow to investigate I/O thread policy
...
see
https://discourse.ardour.org/t/ardour-8-7-unable-to-connect-to-audio-backend/110774/10
https://discourse.ardour.org/t/ardour-8-7-x-run-issues/110767/2
2024-09-27 01:41:40 +02:00
Robin Gareus
6cc54aa1b0
Fix playhead moving beyond loop range
...
When some other transport related session event (anything that
requires non_realtime_work_pending, e.g. PostTransportOverWrite)
coincides with SessionEvent::AutoLoop, the auto-loop event
was removed from the main event queue and executed as one-shot
immediate event.
While looping the AutoLoop event needs to remain on the main
event queue.
2024-09-26 16:26:05 +02:00
Robin Gareus
dc92ed1bc9
Fix Pre-Fader RegionFx when looping
2024-09-26 04:39:19 +02:00
Robin Gareus
180e90b81a
Only call non_realtime_locate() when locating
...
`butler_transport_work()` may be called for various reasons,
notably PostTransportOverWrite. At that point in time the
transport may still be rolling or stopping with rtloc already
set.
This can cause DR::Underruns since seek clear the entire
disk reader buffer.
2024-09-26 03:45:24 +02:00
Robin Gareus
4f33105ae0
Process PostTransportOverWrite after all
...
This is needed to properly decrement "should_do_transport_work".
After a seek the DR:_pending_overwrite flag will have been
cleared, so not much extra work happens here.
2024-09-26 03:25:13 +02:00
Robin Gareus
e1f465a952
NO-OP: improve butler and disk-i/o debug messages
2024-09-26 03:25:07 +02:00
Robin Gareus
75e6a77c3e
Fix another debug message
2024-09-26 02:26:30 +02:00
Robin Gareus
9d0415ba04
Waveview: fix visual jitter when trimming or splitting regions
...
The left edge of a region on the the editor is rounded to be
on a pixel. When zoomed out, the position corresponding to that
pixel is not usually identical to the region's position().
We need to correct for this as best as possible, while keeping
peaks aligned to pixels.
2024-09-26 02:21:24 +02:00
Robin Gareus
68eb63e0c8
Waveview: fix rounding, span entire region rectangle
...
Previously samples at the end could end up being cropped,
when the Waveview is rendered using an offset.
2024-09-26 02:21:24 +02:00
Robin Gareus
b28090c64c
Peakdata: start striding at consistent offsets
2024-09-26 02:21:24 +02:00
Robin Gareus
5d65d7f051
Peakdata: correctly set peaks of left and right end
2024-09-26 02:21:23 +02:00
Robin Gareus
0357c12fcc
Really fix compiler warnings for clang < v15
...
see also 57a6773833
2024-09-26 01:31:25 +02:00
Robin Gareus
60b3b24cc8
Do not allow changing the loop range while recording
2024-09-25 21:43:47 +02:00
Robin Gareus
18e0cba1cb
Fix underruns when looping/locating and changing region content
...
Previously loop-wrap around asked the butler to perform
a unnecessary seek operation next time it is summoned.
If the butler is then summoned for a PostTransportOverWrite
event, the seek causes a DR::Underrun.
2024-09-25 20:06:08 +02:00
Robin Gareus
5af023c70b
Fix some debug messages
2024-09-25 20:06:08 +02:00
Alexandre Prokoudine
74bbcdcae7
Closing tags should also have proper indentation in XML
2024-09-25 17:11:27 +02:00
Paul Davis
3d1c414a94
initialize member variable
2024-09-24 14:52:06 -06:00
Paul Davis
0e28620a7a
prevent Session::StateSaved being emitted when doing save-as with no switch-to
...
The signal would be emitted while the session was temporarily renamed,
making it appear that we had switched to the new session, despite instructions
not to do so. We had not actually done so, but the saved-as name would show up
on window titles.
2024-09-24 14:50:35 -06:00
Robin Gareus
72cac07ae7
Generic MIDI: do not send touch events for all mapped controlers
...
Previously a start-touch was sent for any bound MIDI
Controllable on each incoming MIDI Control event.
2024-09-24 16:11:00 +02:00
Robin Gareus
d3f536a7ff
Remove unused variable
2024-09-24 16:10:59 +02:00
Alexandre Prokoudine
68d7c97b0d
Add the missing closing tag, mea maxima culpa
2024-09-24 15:45:30 +02:00
Ben Loftis
4024a4354c
region grouping: Overdubbing in non-layered mode was assigning wrong groups
2024-09-23 16:35:04 -05:00
Paul Davis
61988bb032
add option to name new MIDI tracks from SMF with just the SMF track name (gui editing)
2024-09-22 09:49:55 -06:00
Paul Davis
f75f5b0ded
add option to name new MIDI tracks from SMF with just the SMF track name (libs edition)
2024-09-22 09:49:55 -06:00
Robin Gareus
66fdee2e45
Require user's color theme files to be versioned
...
Previously tagged releases did not append major.minor
version to a user's "my-*.colors" file. Ardour also loaded
theme files which a user saved with a previous version.
When new colors were added, those are missing from the
older my-*.colors file.
see also https://discourse.ardour.org/t/color-theme-issues-with-ardour-8-7/110729/20
2024-09-22 16:12:26 +02:00
Robin Gareus
adf511264b
NO-OP: sort dark color names alphabetically
...
This is how Ardour's libXML saves the color files and
it is easier to diff files.
2024-09-19 17:24:33 +02:00
Robin Gareus
57a6773833
Check compiler version to set compiler warning options
...
This cleans up nightly build log (clang 13) and allows
clean compiler output on dev systems (clang 16).
2024-09-18 15:27:37 +02:00
Robin Gareus
8ab7c05382
Fix fan-out of instruments with illegal path-chars in their port-name
...
e.g. EZDrummer "1/2" (or generic "L/R"). While those names
are perfectly fine for Ports, tracks (file) names cannot include
those chars.
Since fan-out looks up routes by name this failed to properly
connect stereo pinouts since 4a14f2fed55b746b186
2024-09-17 22:16:28 +02:00
Robin Gareus
09e9d7781b
Add build support for macOS/Sonoma
...
At some point in the not-too-distant-future we need
to simplify this and simply require Mojave/XCode 10 or later.
2024-09-17 00:01:51 +02:00
Robin Gareus
2d99ff9703
Snapshot and.. cannot overwrite currently loaded session
2024-09-16 00:37:19 +02:00
Robin Gareus
9c64e7d141
Fix libhid API builds with recent gcc/glib `
...
Since glibc 2.10 `wcsdup` and `strtok_r` require `_POSIX_C_SOURCE`
(see also da520ce
2024-09-15 12:00:12 +02:00
Fabio Pesari
f94bde59d7
Fix for Boost 1.8.5
...
Recent boost prevents calls to `get_child` with temporary
default values.
2024-09-15 11:43:52 +02:00
Robin Gareus
9f438aa773
Add workaround to compile w/c++17 and old boost on macOS
...
This can be removed once the buildstack has been updated to
use recent boost.
2024-09-15 00:19:26 +02:00
Robin Gareus
e299635511
Allow to explicitly request C++11/17
2024-09-15 00:14:51 +02:00
Robin Gareus
098cd721d3
Allow a potential 8.8.0 hotfix
2024-09-14 18:36:59 +02:00
Robin Gareus
9602a11ef3
LV2: push output port data to GUI at first run
...
This fixes an issue with some plugins UIs that depend on a
"changed" signal e.g. zynaddsubfx
2024-09-14 17:46:14 +02:00
Robin Gareus
0ed82d2f50
Add C++17 option to force compiles to use std=cxx17
2024-09-14 16:08:58 +02:00
Paul Davis
1f70d54989
avoid call of a null function pointer
2024-09-13 08:24:04 -06:00
Paul Davis
79e78394c2
track modal window show/hide, not realize/finalize
2024-09-13 16:02:59 +02:00
Robin Gareus
639c9a0ca8
Ardour 8.x is history. up next: "Music for Civic Recovery Centre"
2024-09-12 21:22:55 +02:00
Robin Gareus
ab533c38a3
LV2 fix a tiny memory leak introduced in c0b61d5a28
2024-09-11 05:31:27 +02:00
Paul Davis
1737b48aec
Revert "try to add some debugging for macOS modal/menu handling"
...
This reverts commit c5751db473
2024-09-10 16:34:16 -06:00
Paul Davis
bf6ce27b03
Revert "try to fix up previous commit"
...
This reverts commit 04305774cc
2024-09-10 16:34:03 -06:00
