David Robillard
24f7eccc86
Factor out copy-paste code to get grid type in beats defaulting to 1.
2014-11-22 00:46:15 -05:00
David Robillard
41a9060df9
Move time converters only to the region views that actually need them.
...
A step towards sorting out time issues more solidly, the time situation of MIDI
region views and automation region views is slightly different.
2014-11-22 00:46:15 -05:00
Robin Gareus
2966dd4a9f
add a variable to specify windows build concurrency
2014-11-21 23:12:17 +01:00
David Robillard
4bc0d1c475
Fix lost MIDI note offs and controllers.
...
Fix initial read of discrete MIDI controllers.
Fix spurious note offs when starting to play in the middle of a note.
Faster search for initial event when cached iterator is invalid.
So much for dropping the cached iterator. The iterator is responsible for
handling note offs, so that doesn't work. This design means we have some stuck
note issues at the source read level, but they should be taken care of by the
state tracker anyway.
2014-11-20 15:36:11 -05:00
David Robillard
8bba63282a
Reduce unnecessary non-const MIDI buffer access.
2014-11-20 15:32:06 -05:00
David Robillard
7def8de5a3
Use memento_command_binder() to (probably) fix MSVC build and other things.
...
Remove ugly hack that does the same thing.
2014-11-20 12:01:39 -05:00
David Robillard
8f8a4878f3
Clean up some MIDI code.
2014-11-20 11:31:31 -05:00
David Robillard
9d8bbf4b9a
Remove unused variables.
2014-11-20 11:31:31 -05:00
Robin Gareus
0c4869dc35
debug trace lost midi-messages
2014-11-20 02:46:30 +01:00
David Robillard
a9936205b1
Fix dropped MIDI events, especially with record enabled.
...
I am not precisely sure why the cached iterator was causing this problem, it
shouldn't be invalidated, and the times make sense. It may be some lock
related issue since the iterator holds a lock on the source.
In any case, this cached iterator was just to avoid repeated linear search of
the model, but since the model has a logarithmic search, instead just scrap all
this problematic persistent state and search for the appropriate start time
every read. No need to be careful about invalidating when anything changes.
2014-11-19 19:24:16 -05:00
Ben Loftis
4ffdc99c5f
fix range selection of mixer strips; shift+selecting a single strip would select from there til the end
2014-11-19 17:27:13 -06:00
Robin Gareus
e3e85a92db
some const'ness and hints for clang
2014-11-19 20:38:50 +01:00
Robin Gareus
cc5f5c7738
copy hotspots file when packaging windows cursors
2014-11-19 00:21:32 +01:00
Robin Gareus
9bac4df9ec
also load hotspot file (if it exists) for default cursors
2014-11-19 00:21:31 +01:00
Ben Loftis
0fb91e10b4
allow dummy backend for any product
2014-11-18 17:04:23 -06:00
Robin Gareus
41128d1fd4
fix windows icon deply path
2014-11-18 22:32:06 +01:00
Robin Gareus
f082c42994
drop hotspot info when changing cursors.
2014-11-18 22:11:12 +01:00
Robin Gareus
68b3568ab0
deploy square cursors as default for windows
2014-11-18 22:08:51 +01:00
Robin Gareus
37a1717c22
add square cursors (for windows)
...
cursor icons squared with north-west gravity.
hotspots are identical to original icons.
otherwise gdkcursor-win32 creates square cursors with
center gravity and hotspot X/Y differs.
2014-11-18 22:00:58 +01:00
Robin Gareus
4389fd2ace
tabs are tabs and spaces are spaces
...
see http://ardour.org/styleguide.html #26
2014-11-18 21:59:28 +01:00
Robin Gareus
7518c363e5
assert no null pointer dereference
2014-11-18 21:59:04 +01:00
Jeremy Carter
fe6e6e3f35
Plugin Automation All: Fix bug where Switches weren't being changed.
2014-11-18 14:26:50 -05:00
David Robillard
e8716de015
Make MIDI channel selector rows/col constraints actually do something.
...
Seems kind of pointless since it's always 4 anyway, but whatever.
2014-11-18 02:55:04 -05:00
David Robillard
bd577a0663
Avoid possible use of uninitialized values.
...
This could only happen with a broken widget, but it shuts up clang and doesn't
hurt.
2014-11-18 02:55:03 -05:00
David Robillard
976a150e6b
Remove obviously dead/redundant code.
2014-11-18 02:55:03 -05:00
David Robillard
07d4f50689
Clean up funny code and initialize variables.
2014-11-18 02:55:03 -05:00
David Robillard
881d77f1e5
Constrain variable scopen and avoid uninitialized values existing at all.
...
Note: dead assignments trigger scan-build dead code warnings, which
initializations do not.
2014-11-18 02:55:03 -05:00
David Robillard
6e482b3488
Remove unused variable and redundant arithmetic.
2014-11-18 02:55:03 -05:00
David Robillard
8dde26da7b
Gracefully avoid importing audio that somehow has 0 channels.
2014-11-18 02:55:03 -05:00
David Robillard
e5d9fd1aac
Fix potential use of uninitialized value.
2014-11-18 02:53:28 -05:00
David Robillard
fed4e8446b
Fix NULL pointer dereference on malformed Playlist XML.
2014-11-18 02:53:28 -05:00
David Robillard
afd67800b9
Avoid potential division by zero.
2014-11-18 02:53:28 -05:00
David Robillard
c4c7598adb
Fix broken logic and possible NULL pointer dereference for Bundle XML.
2014-11-18 02:53:28 -05:00
David Robillard
26f6f80a53
Fix incredibly unlikely NULL pointer dereference.
2014-11-18 02:53:28 -05:00
David Robillard
9aec0c627d
Fix Region::verify_length() so it actually does something.
2014-11-18 02:53:27 -05:00
David Robillard
aabde88de0
Fix incredibly unlikely NULL pointer dereference.
2014-11-18 02:53:27 -05:00
David Robillard
2c85e7acac
Fix zoom out limiting logic to actually limit minimum zoom.
2014-11-18 02:53:27 -05:00
David Robillard
adea8ab68f
Fix mismatched note resize drag cursor and behaviour.
2014-11-18 02:53:27 -05:00
David Robillard
5799cb8509
Fix edit point selector on Mixbus.
2014-11-18 02:53:27 -05:00
Robin Gareus
843551d9d8
remove cruft
2014-11-18 06:15:22 +01:00
Robin Gareus
b6db707989
amend 484e38053
2014-11-18 05:28:27 +01:00
Robin Gareus
484e380536
silence clang "dead assignment" warnings
2014-11-18 04:46:37 +01:00
Robin Gareus
37937d9c69
synchronize preferences and monitor-section
2014-11-18 03:49:20 +01:00
Robin Gareus
5e90b97c42
files should have at least one channel.
2014-11-18 02:15:07 +01:00
Robin Gareus
bd5713f009
remove cruft (monitor section knobs are cairo now)
2014-11-18 02:15:06 +01:00
Robin Gareus
f39286f92f
NOOP, re-indent and remove trailing whitespace
2014-11-18 02:15:06 +01:00
Robin Gareus
f2273dc3b6
remove dead assignment
2014-11-18 02:15:06 +01:00
Robin Gareus
c194e4df18
remove superfluous if-branch (_session is checked a few lines above)
2014-11-18 02:15:06 +01:00
David Robillard
f7ebae85a7
Fix "maybe" rounding bug.
...
Introduced in d63161426f
2014-11-17 19:53:30 -05:00
Robin Gareus
02d735ff00
waves/coreaudio PPC support
2014-11-17 09:07:39 +01:00
