Commit graph

41197 commits

Author SHA1 Message Date
Paul Davis
1efd0c06bd move threshold for drags goes back to pair<int,int>
And for now, there's only a single implementation, though other types of
drags could implement it if needed. There really seems to be no need.

Note that the x-axis threshold is 3x in the case of a copy-drag.
2025-08-19 12:09:12 -06:00
Paul Davis
f34e314d93 move _copy member of some types of drags into Drag base class
this allows us to use it when computing move thresholds
2025-08-19 12:09:12 -06:00
Robin Gareus
43e4e428f5
Handle case where a custom MenuElem is added to the dropdown 2025-08-19 20:06:04 +02:00
Paul Davis
469f3e4d2a unit tests: fix an unusual deadlock/block in TempoMap::write_copy()
this call works in other tests, no time to investigate it right now, and
technically the test doesn't require a write copy at all.
2025-08-19 10:53:06 -06:00
Paul Davis
69174b555e unit tests: use std::cout for any debug output in tempo map cut buffer test 2025-08-19 10:53:06 -06:00
Paul Davis
1312e8f992 temporal: implement TempoMap::bbt_distance() but do not use it
This was implemented to try to fix paste() but was not needed. It might be
useful in the future, or just as an expression of the logic of this. Note that
the BBT_Offset it returns only has the beats field set, which is ... odd. So
this is likely not quite finished.
2025-08-19 10:53:06 -06:00
Paul Davis
29be601cce temporal: undefine macro after use 2025-08-19 10:53:06 -06:00
Paul Davis
7c9b9ceb7e temporal: show BBT marker point names in operator<< 2025-08-19 10:53:06 -06:00
Paul Davis
2aad1ac5f5 temporal: fix TempoMap::paste() to pass unit test
the BBT times of the newly inserted points during paste() are meaningless until
we recompute them using ::reset_starting_at(). So don't try to compute some
sort of likely value, just use the value from the cut buffer, and call
reset_starting_at() after every point inserted.
2025-08-19 10:53:06 -06:00
Paul Davis
ee6356d9df remove crashing assert() when rendering scroomer
Too hard to get a floating point assert correct, but I think this is still a little
incorrect because we do not scale the kbd size when rendering it.
2025-08-19 10:53:06 -06:00
Paul Davis
66dde32a1b no more BBT_Time round/round_up methods (GUI edition) 2025-08-19 10:53:06 -06:00
Paul Davis
f0111bcea5 temporal: BBT_Time cannot have any round_to_*() or round_up_to_*() methods
A meter (time signature) is required to do the math correctly for any operation that may
cross or reach the next bar boundary, which round_to_*() and round_up_to_*() may do.
2025-08-19 10:53:06 -06:00
Robin Gareus
d2512c814a
Use short labels for grid and beat-div dropdown 2025-08-19 18:24:22 +02:00
Robin Gareus
4859e4e57e
ArdourDropdown: use action's short-label for display text 2025-08-19 18:18:41 +02:00
Robin Gareus
e74dbf6ef7
Pianoroll: the return of the draw box (amend 8ffd45c3c) 2025-08-19 15:36:44 +02:00
Robin Gareus
8ffd45c3c0
Don't expand GUI as much on first load
The editor-toolbar still needs a major cleanup, it's
very busy
2025-08-19 15:25:24 +02:00
Robin Gareus
44ceb91e52
Use new YTKMM API instead of ytk+ 2025-08-19 14:40:49 +02:00
Robin Gareus
5f12554b56
YTKMM: expose ytk_set_child_packing 2025-08-19 14:20:39 +02:00
Robin Gareus
07dc5c0fc0
Remove cruft 2025-08-19 14:04:13 +02:00
Robin Gareus
936f8734b4
Tweak editor bottom pane packing, never unpack the property box 2025-08-19 14:03:19 +02:00
Robin Gareus
f9cdaf698c
Never unpack the selection-property-box
This is used to for all selection: route, plugins,
time and region and slot selection.

Only re-pack it with different expand option when
the pianoroll is also visible
2025-08-19 13:28:51 +02:00
Robin Gareus
014d231d13
Fix preference enum - see 4826a90796 2025-08-19 04:48:45 +02:00
Robin Gareus
32f162ec9a
Fix invalid markup (scene name) 2025-08-19 03:24:20 +02:00
Paul Davis
4826a90796 prefs editing widgets for region-edit-disposition 2025-08-18 19:04:05 -06:00
Paul Davis
368189c4f6 an initial guess at using the new region-edit-disposition parameter
No editing of the parameter yet
2025-08-18 18:26:10 -06:00
Paul Davis
1817aa5c2d add a new UI prefs variable/type for region edit disposition
i.e. where to edit a selected or specifically chosen region
2025-08-18 17:08:23 -06:00
Paul Davis
a48ffdf998 refinements to SMF type0 import logic 2025-08-18 16:46:26 -06:00
Paul Davis
4303b77441 MIDI regions attempt to get their tempo & meter from their source file 2025-08-18 16:35:42 -06:00
Paul Davis
c49f607ce6 slightly refine SMF::is_meta() to differentiate realtime system reset 2025-08-18 16:35:41 -06:00
Paul Davis
79da488132 Reimplement MIDI file import to retain metadata in the files written
Previosuly, all meta data was thrown away. Now we retain it, so that MIDI
regions can ask about their source file's tempo & meter.

Significant engineering rework of how this all works, relying on
recently introduced API and API changes in SMF, SMFSource etc.
2025-08-18 16:35:41 -06:00
Paul Davis
48cd807e6a change API of MidiSource::append_event_beats() to allow meta-event legality
Because we want a default argument of false, this involved the usual
inline-non-virtual-method-calls-virtual-with-no-default trick.

Also, do NOT append data to a MidiModel or change the length of an SMFSource
unless we know for sure that added that data to the SMF object.
2025-08-18 16:35:41 -06:00
Paul Davis
586ac7e447 add SMFSource::end_track() to provide source-level access to SMF method 2025-08-18 16:35:41 -06:00
Paul Davis
73065f814a modify API of Evoral::SMF::append_event_beats() to add meta-event legality
If the (new) final argument is true, we allow writing SMF meta events to the
underlying libsmf object (which doesn't care one way or another).
2025-08-18 16:35:41 -06:00
Paul Davis
b60702e014 add Evoral::SMF::end_track()
This changes the assumption that an SMF object only refers to
a single track when being written.

::end_track() is used within begin::write()/end_write() pairs to mark the start
of a new SMF track.
2025-08-18 16:35:41 -06:00
Paul Davis
785047bf47 add Evoral::SMF::is_meta() to test for SMF meta events
These are not legal in "live" MIDI but are allowed in SMF files.
2025-08-18 16:35:41 -06:00
Paul Davis
e703cf2d73 use nullptr instead of zero in initializer 2025-08-18 16:35:41 -06:00
Robin Gareus
017ad176ad
Expand route properties on cue page when strip is selected
This is currently only for Mixbus' benefit, showing
the channelstrip and plugin(s); but may become relevant
for Ardour sometime.
2025-08-18 23:27:03 +02:00
Robin Gareus
8dfd116b58
Properly hide cue editors (unmap macOS GLCanvas views) 2025-08-18 23:25:44 +02:00
Robin Gareus
06a2b174dd
Fix crash at session close
see also 6672db97. in theory re-assigning a sigc::connection
should disconnect the previous connection, but for yet
unknown reasons this does no happen here.
2025-08-18 23:25:43 +02:00
Paul Davis
a22a84cbee SMF: return meta events, with size set to event size, but return value of zero 2025-08-18 12:47:26 -06:00
Paul Davis
bd34f1744d add window geometry to region UI settings, and save after changes
Changes are detected in Pianoroll::canvas_allocate(), which is a proxy for window
geometry. Since Pianoroll doesn't own a window, this is not necessarily ideal, but it
works.
2025-08-18 12:47:25 -06:00
Edgar Aichinger
66599dac36
update german (gtk2_ardour only for now) translation 2025-08-17 17:47:35 +02:00
Robin Gareus
bdc4d6fb60
Potential fix for MSVC builds 2025-08-17 17:30:22 +02:00
Robin Gareus
6672db9794
Fix crash at session close - fix use-after-free
Pianoroll::maybe_update() was able to use _session
after session was already unset.
2025-08-17 06:34:31 +02:00
Robin Gareus
a91aa6ee9d
Except pianoroll CC metabuttons (w/submenu) from scrolling 2025-08-17 06:30:35 +02:00
Robin Gareus
26ca954574
Allow to scroll though meta-button items #9976 2025-08-17 06:29:31 +02:00
Robin Gareus
a83c83aef6
Overhaul persistent tooltip position #9979
* directly show at correct position
* honor multi-monitor boundaries
* hide on focus-out (e.g. switch desktops with visible
  tooltip left it visible)
* remove unused `set_center_alignment` API
2025-08-17 02:55:25 +02:00
Robin Gareus
6b79d4ab98
Add option to hide rendered UI instructions #9975 2025-08-17 00:34:53 +02:00
Robin Gareus
a270ae2aa3
Fix VST3 spec link 2025-08-16 23:11:19 +02:00
Robin Gareus
d35faf052e
Add popup dialog when MMCSS threads are exhausted 2025-08-16 23:11:19 +02:00