smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-27 08:57:41 +01:00
Code Issues Projects Releases Wiki Activity
12371 commits 103 branches 145 tags 316 MiB
Commit graph

12371 commits

This branch
This branch
All branches
Author SHA1 Message Date
Robin Gareus
1e4e6499e3 fix deadlock when removing monitoring-section 2014-01-13 09:39:50 -05:00
Robin Gareus
1b24aad933 fix processor -> reconfigure I/O || process concurrency 
Add a ReaderLock to Route::process_output_buffers().

But process_output_buffers() is always called with processor-lock
held. To avoid deadlocks, a processor WriterLock must always imply
a process-lock (IFF reconfigure-I/O is called with _processor_lock).

Otherwise: e.g.
*  add_processor() -> takes processor-lock. set up and activate processor.
*  simult. audio-engine process, process-lock -> call process_output_buffers() -> wait for processor-lock
*  add_processor() continues -> calls reconfigure-io -> take process-lock -> deadlock.
 2014-01-13 09:39:50 -05:00
Robin Gareus
ac8eb0581d take process lock when adding processors: 
fixes possible crash if a processor modifies port-count

1. a processor is inserted and activated with processor-lock held
2. only after that the process_lock() is taken, configure_processors() is called which reconfigures-IO

BUT if the processor that is inserted changes the channel count AND audio is processed before IOs are reconfigured
 -> possible crash (invalid port-buffers)

To reproduce: Bus1 (2in, 3out), Bus2 (2in, 3out)
- add a send from Bus1 to Bus2,
- then add a processor to Bus1, just before the send which
  increases the channel-count to 4 -> occasional crash or assert.
 2014-01-13 09:39:18 -05:00
Robin Gareus
ac8e258e15 VBAP panner UI tweaks: 
* fix mouse-grab of sentinel
* make GUI more hemisphere like (circles at latitude)
* change alpha slightly to show signal overlap
 2014-01-13 09:39:18 -05:00
Robin Gareus
a919ac8a86 aubio 3+4 compat 2014-01-13 09:38:24 -05:00
Robin Gareus
75e21d3ab4 cosmetic change - properly use lilv API 2014-01-13 09:38:24 -05:00
Robin Gareus
39d5ef5034 don't display elevation if panner does not support it. 2014-01-13 09:38:24 -05:00
Robin Gareus
28470af5f7 swap channel VBAP channel 2014-01-13 09:38:24 -05:00
Robin Gareus
5d8e392892 credit where credit is due for speaker-config and VBAP fixes inspiration 2014-01-13 09:38:24 -05:00
Robin Gareus
cc34174652 VBAP GUI object-grab & position 2014-01-13 09:38:24 -05:00
Robin Gareus
97758dcbea hide speaker-config in menu (it's not implemented yet) 2014-01-13 09:38:24 -05:00
Robin Gareus
a5ff738b87 add spinbox to control width in VBAP GUI,.. 2014-01-13 09:37:35 -05:00
Robin Gareus
dd4c0e040f VBAP rework (part III): fix position computation backend & GUI 2014-01-13 09:37:35 -05:00
Robin Gareus
431babc272 update default speaker position list 2014-01-13 09:37:35 -05:00
Robin Gareus
60fe9606f4 VBAP GUI depends on signal-position (not parameter changes) 2014-01-13 09:37:35 -05:00
Robin Gareus
1bf9c4c990 VBAP backend re-work (part two): speaker positioning 
* clean up source (whitespace)
* fix speaker 3x3 matrix iteration
* update math to go along with Ardour Cartesian -- fixes rounding errors
* fix division by zero in cross_prod()
* disable old debug output

(NB PBD::spherical_to_cartesian() returns
  3.7494e-33, 6.12323e-17, 1 for azimuth 90 elevation 90 distance 1
while it should return
  0.000000, 0.000000, 1 for azimuth 90 elevation 90 distance 1
IOW  cos(90.0 * 2.0 * M_PI / 360.0) != 0
Cause unknown. This is currently worked around check in vec_length()
)
 2014-01-13 09:37:34 -05:00
Robin Gareus
112de00841 VBAP backend re-work (part one): 
* fix azimuth, don't clamp but map to [0,1]
* prepare elevation (10+ speakers)
 2014-01-13 09:35:57 -05:00
John Emmas
5d8da11f4b Add provision for building 'libtimecode' as a DLL (MSVC build) 2014-01-13 14:27:56 +00:00
John Emmas
1fb9437e26 'libs/timecode' - Change some instances of 'rint' to be 'lrint' (better compatibility with MSVC) 2014-01-13 14:26:19 +00:00
John Emmas
5da8c2b476 'libs/evoral' - and add 'Note.impl' to the project 2014-01-13 12:47:21 +00:00
John Emmas
1d69f31266 'libs/evoral' - #include 'Note.impl' when building with MSVC (this is necessary to ensure that Evoral::Note gets exported from the evoral DLL) 2014-01-13 12:16:02 +00:00
John Emmas
316973d7c7 Merge branch 'windows+cc' into cairocanvas 2014-01-13 10:49:18 +00:00
John Emmas
8e51a6c84f Check in some minor modifications (to MSVC specific headers) 2014-01-13 10:22:31 +00:00
Paul Davis
9c753dbaec use LIBEVORAL_TEMPLATE_API with Evoral::Note 2014-01-12 20:23:45 -05:00
Paul Davis
2fc2df8c5d fix 64 bit template types 2014-01-12 20:01:12 -05:00
Paul Davis
cdfc094b9f add new file (required by MSVC) to sources list 2014-01-12 20:00:55 -05:00
Paul Davis
491bc4e865 use LIBEVORAL_TEMPLATE_API 
Also clean up unnecessary comments - git blame provides complete per-line history, no need to leave comments behind
 2014-01-12 20:00:26 -05:00
Paul Davis
a94dadc759 add LIBEVORAL_TEMPLATE_API to deal with gcc/msvc difference of opinion 2014-01-12 19:59:40 -05:00
Paul Davis
83c0720645 remove VAMP and Rubberband from source tree 2014-01-12 15:40:48 -05:00
Paul Davis
4b3feefa55 add -fvisibility=default back to cxx/cflags when building QM DSP and VAMP plugins libs, because ... ugh 2014-01-12 15:40:48 -05:00
Paul Davis
26a9e28922 add export visibility macro 2014-01-12 15:40:48 -05:00
Paul Davis
87009afff2 add new file 2014-01-12 15:40:48 -05:00
Paul Davis
c3a00990b3 add missing export/visibility macro 2014-01-12 15:40:48 -05:00
Paul Davis
0a2a6aaabb remove taglib from source tree (require external provision) 2014-01-12 15:40:48 -05:00
Paul Davis
5062a00c7d move -fvisibility=hidden to the top of the source tree, and remove its internal use; use libtimecode as a shared lib again 2014-01-12 15:40:47 -05:00
Paul Davis
2c21cbb044 add export/visibility macros to libtimecode and build as a shared library again 2014-01-12 15:40:47 -05:00
Paul Davis
b7bc2dd2c6 build libsmf as a static library, since it is private to evoral and would otherwise require export visibility control 
This also removes -fvisibility=hidden, a change that is taking place across the source tree and will show up in a later commit elsewhere
 2014-01-12 15:40:47 -05:00
John Emmas
6fc1f27013 Merge branch 'windows+cc' into cairocanvas 2014-01-12 17:45:28 +00:00
John Emmas
61c692baa1 'libs/evoral' - Move a couple of 'IdentityConverter' functions into their own dedicated C++ source file. This allows them to be used correctly with __dllimport and __dllexport. Hopefully, this technique will also work for gcc / mingw 2014-01-12 17:40:25 +00:00
John Emmas
dd8ba245bb 'libs/evoral' - DLL visibility stuff and associated changes needed for building with MSVC. Currently includes debugging information and things that are just commented out until we have known compatibility with the other platforms (i.e. contains stuff to be removed at a later date) 2014-01-12 17:36:17 +00:00
Paul Davis
59631acc5f fix merge with master 2014-01-11 15:19:18 -05:00
Paul Davis
943bcc29cc fix issues with isnan/isinf on OS X where <cmath> hides isnan/isinf and forces std::isnan/std::isinf 2014-01-11 15:02:10 -05:00
Paul Davis
cf0f985bc4 avoid apple gcc warning 2014-01-11 15:01:29 -05:00
David Robillard
72d8ca89e2 Support midnam controller value labels. 2014-01-10 20:51:54 -05:00
David Robillard
0fe968a140 Fix whitespace (no functional changes). 2014-01-10 20:51:54 -05:00
Paul Davis
658bb3ccd4 finished merge of cairocanvas with windows and windows+cc branches 2014-01-10 17:11:10 -05:00
Paul Davis
3020b224fa Merge windows+cc branch into cairocanvas branch. Not finished, need to now merge windows branch to get changes from there 2014-01-10 16:07:57 -05:00
Paul Davis
d15fda6d75 fix merge errors with master 2014-01-10 14:53:03 -05:00
Paul Davis
22c303d8f6 final (?) tweaks to rectangle rendering 2014-01-10 14:36:05 -05:00
Paul Davis
9df593d823 clamp expose (queue_redraw()) requests to visible window area, some extra debugging details 2014-01-10 14:35:36 -05:00