smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-08 15:54:57 +01:00
Code Issues Projects Releases Wiki Activity

SNAFU. Allow changing engine buffer-size while running

Browse source
This commit is contained in:
Robin Gareus 2017-08-04 03:36:03 +02:00
parent 1d0221349a
commit cc4df34697
1 changed files with 9 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

24
gtk2_ardour/engine_dialog.cc
View file

@ -803,22 +803,10 @@ EngineControl::update_sensitivity ()
if (get_popdown_string_count (buffer_size_combo) > 0) { if (get_popdown_string_count (buffer_size_combo) > 0) {
if (!engine_running) { if (!engine_running) {
buffer_size_combo.set_sensitive (valid); buffer_size_combo.set_sensitive (valid);
} else if (backend->can_change_sample_rate_when_running()) { } else if (backend->can_change_buffer_size_when_running ()) {
buffer_size_combo.set_sensitive (valid || !_have_control); buffer_size_combo.set_sensitive (valid || !_have_control);
} else { } else {
#if 1
/* TODO
* Currently there is no way to manually stop the
* engine in order to re-configure it.
* This needs to remain sensitive for now.
*
* (it's also handy to implicily
* re-start the engine)
*/
buffer_size_combo.set_sensitive (true);
#else
buffer_size_combo.set_sensitive (false); buffer_size_combo.set_sensitive (false);
#endif
} }
} else { } else {
buffer_size_combo.set_sensitive (false); buffer_size_combo.set_sensitive (false);
@ -1443,7 +1431,7 @@ EngineControl::set_buffersize_popdown_strings ()
s.push_back (bufsize_as_string (*x)); s.push_back (bufsize_as_string (*x));
} }
uint32_t previous_size = 0; uint32_t previous_size = backend->buffer_size ();
if (!buffer_size_combo.get_active_text().empty()) { if (!buffer_size_combo.get_active_text().empty()) {
previous_size = get_buffer_size (); previous_size = get_buffer_size ();
} }
@ -1634,6 +1622,12 @@ void
EngineControl::buffer_size_changed () EngineControl::buffer_size_changed ()
{ {
DEBUG_ECONTROL ("buffer_size_changed"); DEBUG_ECONTROL ("buffer_size_changed");
if (ARDOUR::AudioEngine::instance()->running()) {
boost::shared_ptr<ARDOUR::AudioBackend> backend = ARDOUR::AudioEngine::instance()->current_backend();
if (backend && backend->can_change_buffer_size_when_running ()) {
backend->set_buffer_size (get_buffer_size());
}
}
show_buffer_duration (); show_buffer_duration ();
} }
@ -1869,7 +1863,7 @@ EngineControl::store_state (State state)
void void
EngineControl::maybe_display_saved_state () EngineControl::maybe_display_saved_state ()
{ {
if (!_have_control) { if (!_have_control || ARDOUR::AudioEngine::instance()->running ()) {
return; return;
} }