smokephil/yt-dlp
1
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2025-12-06 14:55:02 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use os.replace where applicable (#793)

Browse source 
When using 
```py
os.remove(encodeFilename(filename))
os.rename(encodeFilename(temp_filename), encodeFilename(filename))
```
the `os.remove` need not be atomic and so can be executed arbitrarily compared to the immediately following rename call. It is better to use `os.replace` instead

Authored by: paulwrubel
This commit is contained in:
Paul Wrubel 2021-08-26 21:27:20 -05:00 • committed by GitHub
parent 691d5823d6
commit d75201a873
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

3
yt_dlp/postprocessor/embedthumbnail.py
View file

@ -222,8 +222,7 @@ class EmbedThumbnailPP(FFmpegPostProcessor):
raise EmbedThumbnailPPError('Supported filetypes for thumbnail embedding are: mp3, mkv/mka, ogg/opus/flac, m4a/mp4/mov')
if success and temp_filename != filename:
os.remove(encodeFilename(filename))
os.rename(encodeFilename(temp_filename), encodeFilename(filename))
os.replace(temp_filename, filename)
self.try_utime(filename, mtime, mtime)