Enhancement: angular 19 (#8584)

src-ui/src/app/components/document-list/bulk-editor/bulk-editor.component.spec.ts

@@ -4,15 +4,8 @@ import {
   provideHttpClientTesting,
 } from '@angular/common/http/testing'
 import { ComponentFixture, TestBed } from '@angular/core/testing'
-import { FormsModule, ReactiveFormsModule } from '@angular/forms'
 import { By } from '@angular/platform-browser'
-import {
-  NgbModal,
-  NgbModalModule,
-  NgbModalRef,
-  NgbModule,
-} from '@ng-bootstrap/ng-bootstrap'
-import { NgSelectModule } from '@ng-select/ng-select'
+import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap'
 import { NgxBootstrapIconsModule, allIcons } from 'ngx-bootstrap-icons'
 import { of, throwError } from 'rxjs'
 import { Correspondent } from 'src/app/data/correspondent'
@@ -21,10 +14,7 @@ import { DocumentType } from 'src/app/data/document-type'
 import { Results } from 'src/app/data/results'
 import { StoragePath } from 'src/app/data/storage-path'
 import { Tag } from 'src/app/data/tag'
-import { IfPermissionsDirective } from 'src/app/directives/if-permissions.directive'
 import { FilterPipe } from 'src/app/pipes/filter.pipe'
-import { IsNumberPipe } from 'src/app/pipes/is-number.pipe'
-import { SafeHtmlPipe } from 'src/app/pipes/safehtml.pipe'
 import { DocumentListViewService } from 'src/app/services/document-list-view.service'
 import { PermissionsService } from 'src/app/services/permissions.service'
 import { CorrespondentService } from 'src/app/services/rest/correspondent.service'
@@ -41,9 +31,6 @@ import { UserService } from 'src/app/services/rest/user.service'
 import { SettingsService } from 'src/app/services/settings.service'
 import { ToastService } from 'src/app/services/toast.service'
 import { environment } from 'src/environments/environment'
-import { ConfirmDialogComponent } from '../../common/confirm-dialog/confirm-dialog.component'
-import { MergeConfirmDialogComponent } from '../../common/confirm-dialog/merge-confirm-dialog/merge-confirm-dialog.component'
-import { RotateConfirmDialogComponent } from '../../common/confirm-dialog/rotate-confirm-dialog/rotate-confirm-dialog.component'
 import { CorrespondentEditDialogComponent } from '../../common/edit-dialog/correspondent-edit-dialog/correspondent-edit-dialog.component'
 import { CustomFieldEditDialogComponent } from '../../common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component'
 import { DocumentTypeEditDialogComponent } from '../../common/edit-dialog/document-type-edit-dialog/document-type-edit-dialog.component'
@@ -51,13 +38,6 @@ import { EditDialogMode } from '../../common/edit-dialog/edit-dialog.component'
 import { StoragePathEditDialogComponent } from '../../common/edit-dialog/storage-path-edit-dialog/storage-path-edit-dialog.component'
 import { TagEditDialogComponent } from '../../common/edit-dialog/tag-edit-dialog/tag-edit-dialog.component'
 import { FilterableDropdownComponent } from '../../common/filterable-dropdown/filterable-dropdown.component'
-import { ToggleableDropdownButtonComponent } from '../../common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component'
-import { PermissionsFormComponent } from '../../common/input/permissions/permissions-form/permissions-form.component'
-import { PermissionsGroupComponent } from '../../common/input/permissions/permissions-group/permissions-group.component'
-import { PermissionsUserComponent } from '../../common/input/permissions/permissions-user/permissions-user.component'
-import { SelectComponent } from '../../common/input/select/select.component'
-import { SwitchComponent } from '../../common/input/switch/switch.component'
-import { PermissionsDialogComponent } from '../../common/permissions-dialog/permissions-dialog.component'
 import { BulkEditorComponent } from './bulk-editor.component'
 
 const selectionData: SelectionData = {
@@ -95,32 +75,7 @@ describe('BulkEditorComponent', () => {
 
   beforeEach(async () => {
     TestBed.configureTestingModule({
-      declarations: [
-        BulkEditorComponent,
-        IfPermissionsDirective,
-        FilterableDropdownComponent,
-        ToggleableDropdownButtonComponent,
-        FilterPipe,
-        ConfirmDialogComponent,
-        SafeHtmlPipe,
-        PermissionsDialogComponent,
-        PermissionsFormComponent,
-        SelectComponent,
-        PermissionsGroupComponent,
-        PermissionsUserComponent,
-        SwitchComponent,
-        RotateConfirmDialogComponent,
-        IsNumberPipe,
-        MergeConfirmDialogComponent,
-      ],
-      imports: [
-        FormsModule,
-        ReactiveFormsModule,
-        NgbModule,
-        NgbModalModule,
-        NgSelectModule,
-        NgxBootstrapIconsModule.pick(allIcons),
-      ],
+      imports: [BulkEditorComponent, NgxBootstrapIconsModule.pick(allIcons)],
       providers: [
         PermissionsService,
         {

src-ui/src/app/components/document-list/bulk-editor/bulk-editor.component.ts

@@ -1,7 +1,17 @@
 import { Component, Input, OnDestroy, OnInit } from '@angular/core'
-import { FormControl, FormGroup } from '@angular/forms'
-import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap'
+import {
+  FormControl,
+  FormGroup,
+  FormsModule,
+  ReactiveFormsModule,
+} from '@angular/forms'
+import {
+  NgbDropdownModule,
+  NgbModal,
+  NgbModalRef,
+} from '@ng-bootstrap/ng-bootstrap'
 import { saveAs } from 'file-saver'
+import { NgxBootstrapIconsModule } from 'ngx-bootstrap-icons'
 import { first, map, Subject, switchMap, takeUntil } from 'rxjs'
 import { ConfirmDialogComponent } from 'src/app/components/common/confirm-dialog/confirm-dialog.component'
 import { Correspondent } from 'src/app/data/correspondent'
@@ -11,6 +21,7 @@ import { MatchingModel } from 'src/app/data/matching-model'
 import { StoragePath } from 'src/app/data/storage-path'
 import { Tag } from 'src/app/data/tag'
 import { SETTINGS_KEYS } from 'src/app/data/ui-settings'
+import { IfPermissionsDirective } from 'src/app/directives/if-permissions.directive'
 import { DocumentListViewService } from 'src/app/services/document-list-view.service'
 import { OpenDocumentsService } from 'src/app/services/open-documents.service'
 import {
@@ -39,6 +50,7 @@ import { StoragePathEditDialogComponent } from '../../common/edit-dialog/storage
 import { TagEditDialogComponent } from '../../common/edit-dialog/tag-edit-dialog/tag-edit-dialog.component'
 import {
   ChangedItems,
+  FilterableDropdownComponent,
   FilterableDropdownSelectionModel,
 } from '../../common/filterable-dropdown/filterable-dropdown.component'
 import { ToggleableItemState } from '../../common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component'
@@ -50,6 +62,14 @@ import { CustomFieldsBulkEditDialogComponent } from './custom-fields-bulk-edit-d
   selector: 'pngx-bulk-editor',
   templateUrl: './bulk-editor.component.html',
   styleUrls: ['./bulk-editor.component.scss'],
+  imports: [
+    FilterableDropdownComponent,
+    IfPermissionsDirective,
+    FormsModule,
+    ReactiveFormsModule,
+    NgbDropdownModule,
+    NgxBootstrapIconsModule,
+  ],
 })
 export class BulkEditorComponent
   extends ComponentWithPermissions

src-ui/src/app/components/document-list/bulk-editor/custom-fields-bulk-edit-dialog/custom-fields-bulk-edit-dialog.component.spec.ts

@@ -2,11 +2,8 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'
 
 import { provideHttpClient } from '@angular/common/http'
 import { provideHttpClientTesting } from '@angular/common/http/testing'
-import { FormsModule, ReactiveFormsModule } from '@angular/forms'
-import { NgbActiveModal, NgbModule } from '@ng-bootstrap/ng-bootstrap'
-import { NgSelectModule } from '@ng-select/ng-select'
+import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap'
 import { of, throwError } from 'rxjs'
-import { SelectComponent } from 'src/app/components/common/input/select/select.component'
 import { CustomFieldDataType } from 'src/app/data/custom-field'
 import { DocumentService } from 'src/app/services/rest/document.service'
 import { CustomFieldsBulkEditDialogComponent } from './custom-fields-bulk-edit-dialog.component'
@@ -19,8 +16,8 @@ describe('CustomFieldsBulkEditDialogComponent', () => {
 
   beforeEach(async () => {
     TestBed.configureTestingModule({
-      declarations: [CustomFieldsBulkEditDialogComponent, SelectComponent],
-      imports: [FormsModule, ReactiveFormsModule, NgbModule, NgSelectModule],
+      declarations: [],
+      imports: [CustomFieldsBulkEditDialogComponent],
       providers: [
         NgbActiveModal,
         provideHttpClient(),

src-ui/src/app/components/document-list/bulk-editor/custom-fields-bulk-edit-dialog/custom-fields-bulk-edit-dialog.component.ts

@@ -1,7 +1,21 @@
 import { Component, EventEmitter, Output } from '@angular/core'
-import { FormControl, FormGroup } from '@angular/forms'
+import {
+  FormControl,
+  FormGroup,
+  FormsModule,
+  ReactiveFormsModule,
+} from '@angular/forms'
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap'
+import { NgxBootstrapIconsModule } from 'ngx-bootstrap-icons'
 import { first } from 'rxjs'
+import { CheckComponent } from 'src/app/components/common/input/check/check.component'
+import { DateComponent } from 'src/app/components/common/input/date/date.component'
+import { DocumentLinkComponent } from 'src/app/components/common/input/document-link/document-link.component'
+import { MonetaryComponent } from 'src/app/components/common/input/monetary/monetary.component'
+import { NumberComponent } from 'src/app/components/common/input/number/number.component'
+import { SelectComponent } from 'src/app/components/common/input/select/select.component'
+import { TextComponent } from 'src/app/components/common/input/text/text.component'
+import { UrlComponent } from 'src/app/components/common/input/url/url.component'
 import { CustomField, CustomFieldDataType } from 'src/app/data/custom-field'
 import { DocumentService } from 'src/app/services/rest/document.service'
 
@@ -9,6 +23,19 @@ import { DocumentService } from 'src/app/services/rest/document.service'
   selector: 'pngx-custom-fields-bulk-edit-dialog',
   templateUrl: './custom-fields-bulk-edit-dialog.component.html',
   styleUrl: './custom-fields-bulk-edit-dialog.component.scss',
+  imports: [
+    CheckComponent,
+    DateComponent,
+    DocumentLinkComponent,
+    MonetaryComponent,
+    NumberComponent,
+    SelectComponent,
+    TextComponent,
+    UrlComponent,
+    FormsModule,
+    ReactiveFormsModule,
+    NgxBootstrapIconsModule,
+  ],
 })
 export class CustomFieldsBulkEditDialogComponent {
   CustomFieldDataType = CustomFieldDataType