smokephil/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-12-14 10:36:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix: including ordering param for id__in retrievals from frontend (#6875)

Browse source
This commit is contained in:
shamoon 2024-06-01 19:28:31 -07:00 • committed by GitHub
parent 085447e7c4
commit d2883b83c5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 24 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src-ui/src/app/services/rest/abstract-paperless-service.spec.ts
View file

@ -100,13 +100,13 @@ export const commonAbstractPaperlessServiceTests = (endpoint, ServiceClass) => {
test('should call appropriate api endpoint for get a few objects', () => {
subscription = service.getFew([1, 2, 3]).subscribe()
const req = httpTestingController.expectOne(
`${environment.apiBaseUrl}${endpoint}/?id__in=1,2,3`
`${environment.apiBaseUrl}${endpoint}/?id__in=1,2,3&ordering=-id`
)
expect(req.request.method).toEqual('GET')
req.flush([])
subscription = service.getFew([4, 5, 6], { foo: 'bar' }).subscribe()
const req2 = httpTestingController.expectOne(
`${environment.apiBaseUrl}${endpoint}/?id__in=4,5,6&foo=bar`
`${environment.apiBaseUrl}${endpoint}/?id__in=4,5,6&ordering=-id&foo=bar`
)
expect(req2.request.method).toEqual('GET')
req2.flush([])

1
src-ui/src/app/services/rest/abstract-paperless-service.ts
View file

@ -94,6 +94,7 @@ export abstract class AbstractPaperlessService<T extends ObjectWithId> {
getFew(ids: number[], extraParams?): Observable<Results<T>> {
let httpParams = new HttpParams()
httpParams = httpParams.set('id__in', ids.join(','))
httpParams = httpParams.set('ordering', '-id')
for (let extraParamKey in extraParams) {
if (extraParams[extraParamKey] != null) {
httpParams = httpParams.set(extraParamKey, extraParams[extraParamKey])