Mirror of Ardour Source Code
Find a file
Franke Burgarino d774535fe9 Fix reverse iterator issue caught by ASAN
This issue could be seen when dragging an arrangement marker beyond the
bottom of the list in the right edge.

IIUC, std::reverse_iterator<Iter>::operator* creates a temporary iterator
which it then dereferences. This is a problem because what we are
derefencing is a Gtk::TreeIter<Gtk::TreeRow>. gtkmm documentation for
Gtk::TreeIter< T >::operator* states, "The returned reference is
implemented by casting from *this, and so the returned reference is only
valid while this iter is." Additionally, cpp documentation for
std::reverse_iterator states, "std::reverse_iterator does not work with
iterators whose dereference returns a reference to a member of *this."

We also are not advancing this iterator at all, so whether it is reverse
or not is irrelevant (we just want the last one). Thus, *prev(rows.end ())
instead of *rows.rbegin ().
2026-01-09 14:19:29 -06:00
doc Replace git.ardour link with github 2025-08-08 23:36:32 +02:00
gtk2_ardour Fix reverse iterator issue caught by ASAN 2026-01-09 14:19:29 -06:00
headless Copy more mingw branches for MSVC 2025-10-22 18:48:40 +02:00
libs temporal: write down things that I have learned 2026-01-09 11:03:18 -07:00
luasession Statically link luasession against libreadline 2025-11-21 13:36:36 +01:00
msvc_extra_headers Use compiler provided PTW_VERSION define for compatibility 2025-12-05 16:00:09 +01:00
MSVCardour3 remove all trace of cursor stacks; canvas cursor is always "just set" 2024-12-08 12:13:41 -07:00
MSVCMixbus3
MSVCvst_scan
session_utils Copy more mingw branches for MSVC 2025-10-22 18:48:40 +02:00
share Backport Mixbus reset-mixer script 2025-12-17 15:15:28 +01:00
tools Lua doc: properly split std::map<> as function argument 2026-01-09 00:41:50 +01:00
.dir-locals.el
.gitattributes
.gitignore Ignore files generated by macOS packaging 2024-07-23 17:01:16 +02:00
ardour.1
COPYING add plugin clarification to COPYING 2023-04-26 13:28:29 -06:00
nutempo-todo
PACKAGER_README
README
README-GITHUB.txt
system_config
TRANSLATORS Update translation howto 2023-09-24 19:58:25 +02:00
waf upgrade waf to 2.0.26 (includes new autowaf.py version) 2023-09-23 12:09:52 -06:00
wscript Add MSVC specific compiler flags to wscript 2025-12-13 16:01:03 +01:00

Please see the Ardour web site at https://ardour.org/ for all documentation..

For information on building ardour: 
      
     https://ardour.org/development.html