smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-19 11:55:58 +01:00
Code Issues Projects Releases Wiki Activity
ardour/libs/pbd/pbd
History
David Robillard e0aaed6d65 *** NEW CODING POLICY *** 
All #include statements that include a header that is a part of a library
bundled with ardour MUST use quotes, not angle brackets.

Do this:

#include "ardour/types.h"

NOT this:

#include <ardour/types.h>

Rationale:

This is best practice in general, to ensure we include the local version
and not the system version.  That quotes mean "local" (in some sense)
and angle brackets mean "system" (in some sense) is a ubiquitous
convention and IIRC right in the C spec somewhere.

More pragmatically, this is required by (my) waf (stuff) for dependencies
to work correctly.  That is:

!!! FAILURE TO DO THIS CAN RESULT IN BROKEN BUILDS !!!

Failure to comply is punishable by death by torture. :)

P.S. It's not that dramatic in all cases, but this (in combination with some
GCC flags specific to the include type) is the best way I have found to be
absolutely 100% positive the local ones are being used (and we definitely
want to be absolutely 100% positive on that one).


git-svn-id: svn://localhost/ardour2/branches/3.0@4655 d708f5d6-7413-0410-9779-e7cbd77b26cf
2009-02-25 18:26:51 +00:00
..
.cvsignore rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
.DS_Store rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
abstract_ui.cc *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
abstract_ui.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
base_ui.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
basename.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
command.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
compose.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
controllable.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
convert.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
crossthread.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
destructible.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
enumwriter.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
error.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
failed_constructor.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
fastlog.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
file_utils.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
filesystem.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
filesystem_paths.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
forkexec.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
fpu.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
functor_command.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
id.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
mathfix.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
memento_command.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
mountpoint.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
pathscanner.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
pool.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
pthread_utils.h most of the 2.X->3.0 commit (up to rev 4299) except for gtk2_ardour/editor_canvas.cc; builds and runs and does a few specific things but expect it to be buggy for a while yet 2008-12-12 14:43:24 +00:00
rcu.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
receiver.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
replace_all.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
ringbuffer.h Fix empty for loop warning in RingBuffer constructor... and scary indentation... this is what was intended here, yes? 2009-02-25 17:23:15 +00:00
ringbufferNPT.h Fix empty for loop warning in RingBuffer constructor... and scary indentation... this is what was intended here, yes? 2009-02-25 17:23:15 +00:00
search_path.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
selectable.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
shiva.h most of the 2.X->3.0 commit (up to rev 4299) except for gtk2_ardour/editor_canvas.cc; builds and runs and does a few specific things but expect it to be buggy for a while yet 2008-12-12 14:43:24 +00:00
shortpath.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
stacktrace.h Move waf up to top level, waf building of pbd, evoral, midi++ 2009-02-25 17:51:42 +00:00
stateful.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
statefuldestructible.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
stl_delete.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
stl_functors.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
strsplit.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
textreceiver.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
thrown_error.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
tokenizer.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
touchable.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
transmitter.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
undo.h *** NEW CODING POLICY *** 2009-02-25 18:26:51 +00:00
unknown_type.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
uuid.h * Added PBD::UUID 2008-09-19 16:56:01 +00:00
whitespace.h rollback to 3428, before the mysterious removal of libs/* at 3431/3432 2008-06-02 21:41:35 +00:00
xml++.h Clean up xml++.h and xml++.cc in Ardour style. 2009-02-22 20:52:34 +00:00