ardour/gtk2_ardour/note.cc
Paul Davis 8b389ee829 amend 365e3ef8e2 to be "more right"
NoteBase-derived note objects must delete their children, because
often they are deleted long before the parent (group) is. However,
in MidiView::clear_events() we used to call _note_group->clear (true)
first, which would delete the canvas items owned by these objects,
without them knowing about it. This made it dangerous for them
to delete those same items in their destructors.

This reverses the ordering so that NoteBase objects are deleted first
(along with their canvas items) and after that we clear _note_group
which will address any danging canvas items created there that are
not owned by a NoteBase-derived object
2025-03-25 14:49:49 -06:00

158 lines
2.7 KiB
C++

/*
* Copyright (C) 2013-2018 Paul Davis <paul@linuxaudiosystems.com>
* Copyright (C) 2013 John Emmas <john@creativepost.co.uk>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include "evoral/Note.h"
#include "canvas/note.h"
#include "canvas/debug.h"
#include "note.h"
#include "public_editor.h"
using namespace ARDOUR;
using ArdourCanvas::Coord;
using ArdourCanvas::Duple;
Note::Note (MidiView& region, ArdourCanvas::Item* parent, const std::shared_ptr<NoteType> note, bool with_events)
: NoteBase (region, with_events, note)
, _visual_note (new ArdourCanvas::Note (parent))
{
CANVAS_DEBUG_NAME (_visual_note, "note");
set_item (_visual_note);
}
Note::~Note ()
{
delete _visual_note;
}
void
Note::move_event (double dx, double dy)
{
_visual_note->set (_visual_note->get().translate (Duple (dx, dy)));
}
Coord
Note::x0 () const
{
return _visual_note->x0 ();
}
Coord
Note::x1 () const
{
return _visual_note->x1 ();
}
Coord
Note::y0 () const
{
return _visual_note->y0 ();
}
Coord
Note::y1 () const
{
return _visual_note->y1 ();
}
void
Note::set_outline_color (uint32_t color)
{
_visual_note->set_outline_color (color);
}
void
Note::set_fill_color (uint32_t color)
{
_visual_note->set_fill_color (color);
}
void
Note::show ()
{
_visual_note->show ();
}
void
Note::hide ()
{
_visual_note->hide ();
}
void
Note::set (ArdourCanvas::Rect rect)
{
_visual_note->set (rect);
}
void
Note::set_x0 (Coord x0)
{
_visual_note->set_x0 (x0);
}
void
Note::set_y0 (Coord y0)
{
_visual_note->set_y0 (y0);
}
void
Note::set_x1 (Coord x1)
{
_visual_note->set_x1 (x1);
}
void
Note::set_y1 (Coord y1)
{
_visual_note->set_y1 (y1);
}
void
Note::set_outline_what (ArdourCanvas::Rectangle::What what)
{
_visual_note->set_outline_what (what);
}
void
Note::set_outline_all ()
{
_visual_note->set_outline_all ();
}
void
Note::set_ignore_events (bool ignore)
{
_visual_note->set_ignore_events (ignore);
}
void
Note::set_velocity (double fract)
{
/* This just changes the way velocity is drawn */
_visual_note->set_velocity (fract);
}
double
Note::visual_velocity () const
{
return _visual_note->velocity();
}