mirror of
https://github.com/Ardour/ardour.git
synced 2025-12-07 23:35:03 +01:00
69c29a5346
The drawing itself should be unchanged but much of the rest of the implementation has changed. The WaveViewThreads and WaveViewDrawingThread classes were added and allow multiple drawing threads. The Item::prepare_for_render interface is implemented by WaveView to enable queuing draw requests for the drawing threads to process as soon as the state change occurs during Editor::visual_changer, which often means the images will be finished by the time they are needed in WaveView::render. This can significantly reduce total render time and also flickering caused by images not being ready for display. If the drawing thread/s cannot finish the request by the time it is required in WaveView::render then cancel it and draw the WaveViewImage in the GUI thread if it is likely it can be completed in the current render pass/frame. This change also helps reduce the flickering caused by images not being ready with threaded rendering, but with several drawing threads, drawing in the GUI thread may not often occur (unless explicitly requested). Allow unfinished images to be returned from the cache in WaveView::prepare_for_render so that new draw requests aren't queued for duplicate images. This reduces the amount of drawing for instance in compositions where there are many instances of the same sample/waveform displayed on the canvas as only a single image should be drawn. Use a random width within a certain range for WaveView::optimal_image_width_samples so that image drawing is less likely to occur at the same time (which will cause a spike in render/draw time and increase the chance of flickering waveforms). Move implementations of the private WaveView classes into wave_view_private.h and wave_view_private.cc source files. Incorporate a fix for limiting the waveview image size to the cairo image size limit. Should hopefully Resolve: #6478 |
||
|---|---|---|
| .. | ||
| benchmark | ||
| canvas | ||
| doc | ||
| macosx/canvas/canvas.xcodeproj | ||
| MSVCcanvas | ||
| test | ||
| arc.cc | ||
| arrow.cc | ||
| box.cc | ||
| build-and-run-benchmark.sh | ||
| build-and-run-manual-test.sh | ||
| build-and-run-tests.sh | ||
| canvas.cc | ||
| circle.cc | ||
| colors.cc | ||
| colorspace.cc | ||
| container.cc | ||
| curve.cc | ||
| debug.cc | ||
| fill.cc | ||
| flag.cc | ||
| framed_curve.cc | ||
| grid.cc | ||
| image.cc | ||
| item.cc | ||
| line.cc | ||
| line_set.cc | ||
| lookup_table.cc | ||
| meter.cc | ||
| Notes | ||
| outline.cc | ||
| pixbuf.cc | ||
| poly_item.cc | ||
| poly_line.cc | ||
| polygon.cc | ||
| rectangle.cc | ||
| root_group.cc | ||
| ruler.cc | ||
| run-manual-test.sh | ||
| run-tests.sh | ||
| scroll_group.cc | ||
| stateful_image.cc | ||
| text.cc | ||
| tracking_text.cc | ||
| types.cc | ||
| utils.cc | ||
| wave_view.cc | ||
| wave_view_private.cc | ||
| widget.cc | ||
| wscript | ||
| xfade_curve.cc | ||