ardour/libs/surfaces/osc
Matthijs Kooijman a9a5787399
osc: Fix send and plugin page size in /set_surface
When handling the `/set_surface` command, the code would set
plug_page_size to the new value first, and call `sel_plug_pagesize()`
later. The latter then sees the page size is already the same, so it
leaves it unchanged and also does not send the page size to the
OSCSelectObserver object. In practice, this means that only the default
plugin page size from the preferences or set with
`/set_surface/plugin_page_size` take effect and values set with
`/set_surface` are ignored.

Exactly the same thing happens for the send page size.

This code has been like this since it was first introduced in comit
9c0f6ea948 (OSC: Allow set_surface to set send and plugin page sizes.,
2017-06-13)

This commit fixes this by omitting the first assignment.
2024-09-03 00:40:11 +02:00
..
MSVCardour_osc
interface.cc Refactor Ctrl Surface API 2023-05-03 15:38:42 +02:00
osc.cc osc: Fix send and plugin page size in /set_surface 2024-09-03 00:40:11 +02:00
osc.h Update Ctrl Surfaces: use new well-known-ctrl API 2024-01-13 03:08:51 +01:00
osc_controllable.cc switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_controllable.h switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_cue_observer.cc switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_cue_observer.h switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_global_observer.cc switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_global_observer.h switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_gui.cc OSC: add support for Mixer Scenes: save, recall, and state feedback 2022-11-07 10:28:30 -06:00
osc_gui.h OSC: add support for Mixer Scenes: save, recall, and state feedback 2022-11-07 10:28:30 -06:00
osc_route_observer.cc switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_route_observer.h switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr 2023-03-24 14:19:15 -06:00
osc_select_observer.cc osc: Let OSCSelectObserver know about feedback config changes 2024-09-03 00:40:11 +02:00
osc_select_observer.h osc: Let OSCSelectObserver know about feedback config changes 2024-09-03 00:40:11 +02:00
wscript Localize stripped down gtk2 2024-01-06 21:52:48 +01:00