smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-18 19:36:00 +01:00
Code Issues Projects Releases Wiki Activity
Mirror of Ardour Source Code
31085 commits 104 branches 145 tags 327 MiB
Find a file
Robin Gareus 1a49d7d42b
Fix invisible multicahannel waveform at rec-stop 
AudioRegionView() c'tor calls create_waves() early on
before the _height is set [1].

Now one following can happen:
 1. All peak-files are present. create_waves() directly calls
    create_one_wave() for each channel. They are initialized
    with zero height.
    But all channels are present so waves[] is populated and
    a later call to set_height() corrects this
 2. All peak-files are still missing. create_waves() schedules
    callbacks via PeaksReady -> peaks_ready_handler()
    Those callbacks arrive after set_height() was called and
    the waveforms are displayed correctly.

 3. Only some peak-files are present. This can happen at
    rec-stop when the region is created.
    create_waves() directly calls create_one_wave() for available
    peaks, and schedules peaks_ready_handler() for the remainder.
    The directly created waves have zero-height.
    Since not all waves are ready, they are stored in tmp_waves.
    waves[] remains unpopulated.

The set_height() call only ever changed the height of wave[], which
resulted in hidden waveforms, until a user manually changed the
height of the track.


[1] the height is set from
```
#1 AudioStreamView::create_region_view(boost::shared_ptr<ARDOUR::Region>, bool, bool)
#2 AudioStreamView::add_region_view_internal(boost::shared_ptr<ARDOUR::Region>, bool, bool)
#3 StreamView::add_region_view(boost::weak_ptr<ARDOUR::Region>)
 ...
## PBD::Signal1 Playlist::RegionAdded()
```
2020-12-22 03:37:17 +01:00
doc Clarify source-tree doc: libsmf is used inside libevoral 2020-04-28 21:27:16 +02:00
gtk2_ardour Fix invisible multicahannel waveform at rec-stop 2020-12-22 03:37:17 +01:00
headless Transmitter::Debug implementation 1/2 2020-10-13 21:58:26 +02:00
libs Close peakfile before emitting PeaksReady signal 2020-12-22 03:02:54 +01:00
luasession Luasession: load default session snapshot 2020-11-30 22:18:09 +01:00
msvc_extra_headers Move MSVC's declaration of VST3_SUPPORT to the right place 2020-09-22 12:21:20 +01:00
MSVCardour3 Move MSVC's declaration of VST3_SUPPORT to the right place 2020-09-22 12:21:20 +01:00
MSVCMixbus3 Initial changes needed for building Mixbus (with MSVC) as version 5 2018-09-10 07:14:59 +01:00
MSVCvst_scan Correct a typo in my MSVC project file (vst3_scan) 2020-10-16 11:30:00 +01:00
nutemp additional changes to follow library name change from timecode -> temporal 2017-09-25 12:13:54 -04:00
session_utils Bail out if export cannot be started 2020-12-08 01:10:00 +01:00
share Add updated Waldorf Blofeld midnam 2020-11-24 09:12:20 -06:00
tools macOS: explicitly ask for mic/input permissions 2020-12-20 23:49:05 +01:00
vst
.dir-locals.el
.gitattributes Add a Readme pertaining to GH release tarballs 2017-04-22 16:04:35 +02:00
.gitignore Ignore generaed translation files 2020-10-18 17:45:32 +02:00
ardour.1 Update man-page 2020-07-06 21:36:12 +02:00
COPYING
instant.xml.sae
msvc32-fixup.pl Build 'ardour-vst3-scanner.exe' with MSVC 2020-09-22 12:15:09 +01:00
PACKAGER_README
README
README-GITHUB.txt Add a Readme pertaining to GH release tarballs 2017-04-22 16:04:35 +02:00
system_config
testfile.flac
testfile.ogg
TRANSLATORS add text to TRANSLATORS file explaining how contextual translation msgids work and should be translated 2020-05-20 14:40:10 -06:00
waf Update waf to v2.0.19 2020-01-25 04:07:41 +01:00
wscript Set BigSur version compatibility 2020-12-18 14:51:07 +01:00

README 

Please see the Ardour web site at http://ardour.org/ for all documentation..

For information on building ardour: 
      
     http://ardour.org/development.html