mirror of
https://github.com/Ardour/ardour.git
synced 2025-12-23 23:17:46 +01:00
0bd3b0b670
I just had an epiphany. I tried so many ways to make saving function name and
args work, it never occured to me that you could just as easily save undo
information as a pair of mementos, even in the Command-based structure we
agreed on.
Since many (read: almost all) existing undo commands take this form:
begin_reversible_command (_("change fade in length"));
session->add_undo (arv->region.get_memento());
arv->region.set_fade_in_length (fade_length);
session->add_redo_no_execute (arv->region.get_memento());
commit_reversible_command ();
We are already doing the save a memento before and after work. All we need to
do is instantiate an appropriate instance of MementoCommand. So the above
becomes:
begin_reversible_command (_("change fade in length"));
MementoCommand<arv_region_t, arv_region_memento_t> before, after;
before = arv->region.get_memento();
arv->region.set_fade_in_length (fade_length);
after = arv->region.get_memento();
session->add_command(arv->region, before, after);
commit_reversible_command ();
(With apologies for being too lazy to go look up what arv_region_t and
arv_region_memento_t are)
Note that the true command approach is still possible, and encouraged (both by
dictate and design).
git-svn-id: svn://localhost/ardour2/branches/undo@680 d708f5d6-7413-0410-9779-e7cbd77b26cf
49 lines
1.6 KiB
C++
49 lines
1.6 KiB
C++
/*
|
|
Copyright (C) 2006 Hans Fugal & Paul Davis
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
|
|
$Id: /local/undo/libs/pbd3/pbd/undo.h 132 2006-06-29T18:45:16.609763Z fugalh $
|
|
*/
|
|
|
|
#ifndef __lib_pbd_memento_command_h__
|
|
#define __lib_pbd_memento_command_h__
|
|
|
|
#include <pbd/command.h>
|
|
#include <sigc++/slot.h>
|
|
|
|
template <class obj_T, class mem_T>
|
|
class MementoCommand : public Command
|
|
{
|
|
public:
|
|
MementoCommand(obj_T &obj,
|
|
mem_T before,
|
|
mem_T after
|
|
)
|
|
: obj(obj), before(before), after(after) {}
|
|
void operator() () { obj.set_memento(after); }
|
|
void undo() { obj.set_memento(before); }
|
|
virtual XMLNode &serialize()
|
|
{
|
|
// obj.id
|
|
// key is "MementoCommand" or something
|
|
// before and after mementos
|
|
}
|
|
protected:
|
|
obj_T &obj;
|
|
mem_T before, after;
|
|
};
|
|
|
|
#endif // __lib_pbd_memento_h__
|