Fix macOS builds (missing header)

implicit instantiation of undefined template 'std::array<..>'
Move unistd.h detection to the correct wscript
2025-12-06 06:44:57 +01:00 · 2025-12-02 16:54:05 +01:00 · 2025-12-02 16:38:42 +01:00 · 2025-12-02 14:00:59 +01:00 · 2025-12-02 13:58:15 +01:00
6 changed files with 4 additions and 4 deletions
--- a/gtk2_ardour/editor_selection.cc
+++ b/gtk2_ardour/editor_selection.cc
@ -1523,7 +1523,7 @@ Editor::sensitize_the_right_region_actions (bool because_canvas_crossing)

 	if (rs.size() > 1) {
 		_region_actions->get_action("show-region-list-editor")->set_sensitive (false);
-		_region_actions->get_action("show-region-properties")->set_sensitive (false);
+		_region_actions->get_action("edit-region-dedicated-window")->set_sensitive (false);
 		_region_actions->get_action("rename-region")->set_sensitive (false);
 		/* XXX need to check whether there is than 1 per
 		   playlist, because otherwise this makes no sense.
--- a/gtk2_ardour/nsmclient.cc
+++ b/gtk2_ardour/nsmclient.cc
@ -29,7 +29,6 @@
 #ifndef COMPILER_MSVC
 #pragma GCC diagnostic ignored "-Wunused-parameter"
 #else
-#include <process.h>  // Needed for 'getpid()'

 #include <lo/lo_osc_types.h>
 #define LO_TT_IMMEDIATE lo_get_tt_immediate()
--- a/gtk2_ardour/wscript
+++ b/gtk2_ardour/wscript
@ -492,6 +492,8 @@ def configure(conf):
    autowaf.check_pkg(conf, 'pangoft2', uselib_store='PANGOFT2', atleast_version='1.36.8', mandatory=False)
    autowaf.check_pkg(conf, 'fontconfig', uselib_store='FONTCONFIG')

+    conf.check(header_name='unistd.h', define_name='HAVE_UNISTD_H',mandatory=False)
+
    if conf.env.CC_NAME == 'gcc' and Options.options.strict:
        conf.define('GLIB_DISABLE_DEPRECATION_WARNINGS', 1)
        for var in ['CFLAGS', 'CXXFLAGS']:
--- a/libs/ardour/wscript
+++ b/libs/ardour/wscript
@ -341,7 +341,6 @@ def configure(conf):

    conf.check(header_name='sys/vfs.h', define_name='HAVE_SYS_VFS_H',mandatory=False)
    conf.check(header_name='sys/statvfs.h', define_name='HAVE_SYS_STATVFS_H',mandatory=False)
-    conf.check(header_name='unistd.h', define_name='HAVE_UNISTD_H',mandatory=False)

    have_sys_ioprio = conf.check_cc(
            msg="Checking for 'ioprio_set' syscall support",
--- a/libs/pbd/pbd/abstract_ui.inc.cc
+++ b/libs/pbd/pbd/abstract_ui.inc.cc
@ -21,7 +21,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include <unistd.h>
 #include <iostream>
 #include <algorithm>

--- a/libs/surfaces/mackie/surface.h
+++ b/libs/surfaces/mackie/surface.h
@ -20,6 +20,7 @@
 #ifndef mackie_surface_h
 #define mackie_surface_h

+#include <array>
 #include <stdint.h>

 #include <sigc++/trackable.h>
Author	SHA1	Message	Date
Robin Gareus	c08531f96e	Fix macOS builds (missing header) implicit instantiation of undefined template 'std::array<..>'	2025-12-02 16:54:05 +01:00
Robin Gareus	d0109bed16	Move unistd.h detection to the correct wscript This fixes macOS builds (getpid())	2025-12-02 16:38:42 +01:00
Robin Gareus	6ce8358709	Remove yet another irrelevant unistd.h	2025-12-02 14:00:59 +01:00
Robin Gareus	39370aff7b	Fix crash when selecting multiple regions see also `7a5591121b`, action was renamed.	2025-12-02 13:58:15 +01:00