Paul Davis
71ff8ba3e0
refactor horizontal scrolling to use same code/modifiers in Editor and PianorollMidiView
2025-11-24 11:22:50 -07:00
Paul Davis
c6b3694441
continue work from 68f4ac3282356 on correct checks for editing context actions
2025-11-21 22:39:14 -07:00
Paul Davis
a6f85b0da4
EditingContext: use a correct check for various MIDI-only actions
2025-11-21 22:39:14 -07:00
Robin Gareus
b54c8f973e
Set Transient Parents for edit-context dialogs
2025-11-20 21:38:50 +01:00
Robin Gareus
3f6c79b009
Keep Quantize Dialog on top of EditingContext's parent
2025-11-20 17:09:53 +01:00
Paul Davis
1e430325d0
CueEditor: fix a corner case when displaying a ridiculously short region
...
If there are less samples to show than there are pixels to show it, samples per pixel would
be zero. Limit it to spp = 1
2025-11-19 11:08:18 -07:00
Robin Gareus
db364a6db1
Cleanup Cue toolbar layout and spacing
2025-11-19 06:09:16 +01:00
Paul Davis
8ffb54e431
Primary-a in internal edit mode selects all notes
2025-11-18 09:03:05 -07:00
Paul Davis
7f063dab6c
fix display and function of EditingContexts' zoom focus selector
2025-11-17 19:33:00 -07:00
Paul Davis
34bede65aa
editing contexts: remove unusued method parameter from get_grid_music_divisions()
2025-10-31 13:24:35 -06:00
Paul Davis
9bc1e2ad79
remove debug output
2025-10-25 15:15:20 -06:00
Franke Burgarino
bbdca232a9
NO-OP: strum item/action capitalization
2025-09-26 16:54:05 -05:00
Robin Gareus
82bdb3f05f
Expose MIDI Strum using operator in libardour
2025-09-26 00:00:19 +02:00
Robin Gareus
44097cdd6a
Revert "Add MIDI note strumming feature"
...
This reverts commit a9e7ce15db
2025-09-25 22:56:39 +02:00
chousemp3
2ba290e904
NO-OP: whitespace and comment clarification
2025-09-12 19:03:00 +02:00
chousemp3
a9e7ce15db
Add MIDI note strumming feature
2025-09-12 19:02:07 +02:00
Paul Davis
4b28ca2136
move minsec-ruler related code and variables from Editor to EditingContext
2025-09-02 11:03:38 -06:00
Paul Davis
07b20aa60a
kbd automation: no popup immediately after add, 2nd Return/Enter for that
...
Also, two different bindings for adding a point with and without guard points.
2025-08-21 18:56:00 -06:00
Paul Davis
c0fa42a203
EditingContext: don't call drop_action_group() if an action group was not created
...
Example would be an audio clip editor that does not define MIDI actions
2025-08-20 14:53:49 -06:00
Robin Gareus
d8c10a96bd
Amend c6a49fdd50 drop automation actions
...
This fixes a crash when showing the same Pianoroll again,
since actions a already present, a NULL reference was pushed
to session_sensitive_actions. Closing a session then crashed
accessing a NULL Action.
2025-08-20 22:25:58 +02:00
Robin Gareus
4b88330c9c
Use main editor for loop-range undo/redo - fix crash
...
While CueEditor is-a HistoryOwner, session specific
changes such as Location don't belong in EditingContext.
This fixes a heap-use-after-free crash since MementoCommand
was free()ed twice. Once via ARDOUR::Location::~Location
and earlier due to direct Destructible::drop_references
from the History.
This partially reverts 04a8fb1eb6
2025-08-20 21:32:22 +02:00
Robin Gareus
82dc2a9e54
Add "note" to short grid labels
...
see also d2512c814a
2025-08-20 13:05:22 +02:00
Robin Gareus
d2512c814a
Use short labels for grid and beat-div dropdown
2025-08-19 18:24:22 +02:00
Robin Gareus
8ffd45c3c0
Don't expand GUI as much on first load
...
The editor-toolbar still needs a major cleanup, it's
very busy
2025-08-19 15:25:24 +02:00
Paul Davis
192c7a2f9a
fix for a subtle bug that led to track headers not expanding as intended
...
now that we use action-as-state, there was no way to look up the old
mouse mode when changing into or out of internal editing. this
prevented us from queuing the redisplay of trackviews that allows the track
headers to expand when appropriate.
2025-08-14 18:48:04 -06:00
Paul Davis
e467ee77f8
just rename a variable for more clarity when reading code
2025-08-14 14:55:37 -06:00
Paul Davis
5c2afa74e1
restore missing 1/8th note option from grid type selector
2025-08-13 11:05:05 -06:00
Paul Davis
fa97071872
mamy improvements to kbd-driven automation editing
...
Really needs a short video to demo/explain
2025-08-12 21:44:50 -06:00
Paul Davis
478dd72fb0
moved scoped tempo map from GUI to libtemporal (gui)
2025-08-11 15:41:34 -06:00
Paul Davis
1136ba4c99
let's (maybe) inline some of the scoped tempo stuff
2025-08-10 21:03:32 -06:00
Paul Davis
2312187070
sort-of-a-solution for local TempoMap context in EditingContext
2025-08-10 20:25:59 -06:00
Paul Davis
1ecb28da47
tweak local tempo scope infrastructure
2025-08-08 15:03:11 -06:00
Paul Davis
22abddcd95
no local tempo scope for constructors
2025-08-08 14:39:40 -06:00
Paul Davis
4e23772b5d
ensure (possible) local tempo map at start of every EditingContext method
...
This still needs to be done for derived, non-Editor classes
2025-08-08 14:34:03 -06:00
Paul Davis
e682e1fde4
refinements to infrastructure for an EditingContext's locally scoped tempo map
2025-08-08 14:34:03 -06:00
Paul Davis
28e0082868
use std::unique_ptr for a couple of EditingContext members
2025-08-08 12:12:09 -06:00
Paul Davis
4f5848d85c
action-ify stationary playhead mgmt; fix up follow-playhead action handling
2025-08-08 11:35:20 -06:00
Paul Davis
19f6b5277c
when setting default actions, do dbl-set to force change
2025-08-06 11:44:20 -06:00
Paul Davis
d654d98661
fix a #warning about zoom focus state
2025-07-30 22:18:26 -06:00
Paul Davis
9c890f2690
zoom focus and snap mode get the stateful-action treatment
2025-07-30 15:28:46 -06:00
Paul Davis
1d4e3940d1
large-scale refactoring of Pianoroll, CueEditor and AudioClipEditor
...
Enables code-sharing between "clip editors"
2025-07-29 18:16:35 -06:00
Paul Davis
8037762690
braces, please
2025-07-29 18:16:35 -06:00
Paul Davis
561dde4d3a
move grid/snap actions into common editing groups and bindings
2025-07-13 10:37:26 -06:00
Paul Davis
641e3441b8
fix operation of MIDI draw channel dropdown/selector
2025-07-12 11:06:33 -06:00
Paul Davis
38cfd12bac
NoCamelCase method names (gui)
2025-07-12 10:51:54 -06:00
Paul Davis
25b1057e7d
fix computation of maximum zoom for an editing context
...
it must take the max_extents_scale() value into consideration.
2025-07-04 12:22:10 -06:00
Paul Davis
baf41a65c3
some incremental improvements in scroomer behavior
...
Notably dbl-click works consistently/reliably
2025-06-30 09:39:51 -06:00
Paul Davis
87b50a4ecd
use method instead of a direct call, to centralize logic
2025-06-28 22:45:08 -06:00
Paul Davis
ad6b6f1e30
desensitize automation keybindings after session is set, to avoid them being active by default
...
ARDOUR_UI sets all session-sensitive actions to sensitive at session load
2025-06-28 22:44:41 -06:00
Paul Davis
a2c8203a19
use new ArdourDropdown API to build two of the midi draw menus
2025-06-25 22:18:15 -06:00
