Commit graph

5323 commits

Author SHA1 Message Date
Robin Gareus
f6ac5cadea use dedicated buffers for route (and track)
"scratch buffers are by definition scratch and their contents are undefined at all times"
"silent buffers are by definition all-zero and should not be used for real data"

But track & route were using those for actual data; plugins (which may run
in the same thread and may get the same buffers) use them for scratch thereby
overwriting real data.

In particular get_silent_buffers() (used by LadspaPlugin::connect_and_run)
clears the buffer which can holds real data:
e.g. via  Route::passthru_silence() -> plugin1 -> plugin2 (clears output of plugin1)
2013-08-08 15:26:17 -04:00
Robin Gareus
e92306459d Revert "fix issue with generator plugins and no-roll disk monitoring"
This reverts commit bd34ab04cd.
2013-08-08 15:26:17 -04:00
Robin Gareus
05ed31a980 fix issue with generator plugins and no-roll disk monitoring 2013-08-08 15:26:17 -04:00
Michael Fisher
406e69c57d Return an empty string instead of a bool 2013-08-08 15:26:17 -04:00
Michael Fisher
af148ff130 Cast param for std::time to a pointer of time_t
- bleeding clang (trunk 186535 v3.4) fails here
2013-08-08 15:26:17 -04:00
Michael Fisher
bfbc55a673 Proper OSX/CLANG/CXX11 support in stl_delete.h
- replaces fix in 066df0d218
- Check if _LIBCPP_VECTOR is defined for vector_delete.
  This is defined in libc++'s headers which Apple is using
  instead of libstdc++
2013-08-08 15:26:17 -04:00
Michael Fisher
14a7941b5d Housekeeping, code style 2013-08-08 15:26:17 -04:00
Michael Fisher
8541b81e31 Moving Mclk locating code to ticker.cc. Housekeeping 2013-08-08 15:26:17 -04:00
Michael Fisher
4f1085aa08 Add method to send a song position pointer message 2013-08-08 15:26:17 -04:00
Robin Gareus
c8a26faa97 use K-20 meter as default master bus 2013-08-08 15:26:17 -04:00
Robin Gareus
84f20367cc add option to resize meterbridge track-labels 2013-08-08 15:26:17 -04:00
Robin Gareus
5a187cb650 change default meter-fall-off to 13.3 dB/sec 2013-08-08 15:26:17 -04:00
Robin Gareus
82e1d9655f use 3px for peak-hold in LED mode -> display 2 bright lines 2013-08-08 15:26:16 -04:00
Robin Gareus
59a3b797d7 fix compiler warnings. 2013-08-08 15:26:16 -04:00
Robin Gareus
3098e5963c tweak meter-LED style 2013-08-08 15:26:01 -04:00
Edgar Aichinger
c5d930b6b8 update german translation for libardour
fixes x42's screwup with prev commit.
2013-08-08 15:26:01 -04:00
Edgar Aichinger
89cf7c1248 update german translation 2013-08-08 15:26:01 -04:00
Robin Gareus
ff9296e17c add dedicated line-up level for IEC1/DIN meter (15dbFS) 2013-08-08 15:26:01 -04:00
Robin Gareus
d4c864d803 make LED meter style optional 2013-08-08 15:26:01 -04:00
Robin Gareus
11c49ab8d1 cache shaded meter-background regardless of color
previously, shaded patterns were assumed to have different colors as well.
2013-08-08 15:26:01 -04:00
Robin Gareus
2bdd29d3ac fix meter background redraw issue #5601 2013-08-08 15:26:01 -04:00
Robin Gareus
12c9055659 [re]implement horizontal meter 2013-08-08 15:26:01 -04:00
Robin Gareus
26c4ae14cb Don't allow to deactivate meter.
before this change:

1) switch to 'custom' meter point,
2) deactivate meter processor.

-> meters does not run regardless of meter-point
-> meter can only be re-nabled in 'custom' mode
2013-08-08 15:25:40 -04:00
Robin Gareus
d327ab43cf reset meters only when *really* necessary
..and continue to calculate fall-off in
audio-cycle (rather than UI thread)

TODO: check if this works properly when switching
between audio/midi meter modes on a midi-track.

One of the motivations to always reset meters when the
meter-point changes was to resolve peak-hold & fall-off
issues when a midi-meter replaces an audio-meter and vice
versa.
2013-08-08 15:25:40 -04:00
Robin Gareus
d39d296ff8 fix compiler warning 2013-08-08 15:25:40 -04:00
Robin Gareus
ba8742edd1 align gradient with meter-metrics 2013-08-08 15:25:40 -04:00
Robin Gareus
d10b712897 increase saturation of meter-shader 2013-08-08 15:24:49 -04:00
Robin Gareus
bc66985710 allow to en/disable shade and LED meter style 2013-08-08 15:24:49 -04:00
Robin Gareus
2c9484fe14 add "0VU = +8dBu" VU meter config 2013-08-08 15:24:15 -04:00
Robin Gareus
b713fceed0 change default VU mode to "0VU = +4dBu (standard)" 2013-08-08 15:24:15 -04:00
Robin Gareus
2faf401fea implement meter-lineup and VU standard preferences 2013-08-08 15:24:15 -04:00
Robin Gareus
3ec7a620a3 use fixed fall-off time for k-meter 2013-08-08 15:24:15 -04:00
Colin Fletcher
1da655c2eb Fix special handling of 'zoom vertical' scroll wheel modifier key.
gtkmm2ext/keyboard.cc has a special case to emit a signal on the key-up of
the modifier key used to adjust track heights in conjunction with the
scroll wheel, so that the same track continues to be resized even when
it's shrunk to no longer be under the mouse cursor. However, this code
assumed that the modifier key for this was <Shift>.

Fix it to use the event->state bit corresponding to
ScrollZoomVerticalModifier instead, and rename the relevant functions to
clarify that it's the 'zoom vertical' modifier key they're dealing with.

Partially fixes #5610.
2013-08-08 15:24:15 -04:00
Robin Gareus
d31c0f759c restore session backwards compatibility to 3.3 2013-08-08 15:24:15 -04:00
Robin Gareus
553d393d30 implement new meter types 2013-08-08 15:24:15 -04:00
Robin Gareus
bd2ddc09ab Revert "Revert new meter types (postponed until after 3.3 release)"
This reverts commit d80f672e84.
2013-08-08 15:23:11 -04:00
Robin Gareus
67c5652edb reset meter when meter-point changes 2013-08-08 15:23:10 -04:00
Robin Gareus
dbe31bcf22 add a stripe-pattern to the meters 2013-08-08 15:23:10 -04:00
Robin Gareus
ec99830110 meter-state 17 and 49 + code-comment 2013-08-08 15:23:10 -04:00
Robin Gareus
a4edd1ed7a possible fix for http://tracker.ardour.org/view.php?id=5586 2013-08-08 15:23:10 -04:00
Robin Gareus
b0a239d9f8 rework metering states 2, 6, 18 and 22 2013-08-08 15:23:10 -04:00
Robin Gareus
7157fc1bdd revert functionality of f842e8af2 (meter display in DISK mode) 2013-08-08 15:23:10 -04:00
Paul Davis
b5da0c852f Revert "C++11 Building - Use new style struct field inititializing" (this code
change breaks gcc on several platforms).

This reverts commit bf153e58a5.
2013-08-08 15:23:10 -04:00
Robin Gareus
33ecb22e87 yet another meter+monitoring detail:
"explicit Monitor DISK" + "Transport Stop" + "not track rec-en"
 -> meter is always zero
2013-08-08 15:23:10 -04:00
Robin Gareus
a3d5ba3397 fix metering states 34, 38, 49, 50, 53 and 54
for state descriptions see
http://www.oofus.co.uk/ardour/Ardour3MonitorModesV3.pdf
2013-08-08 15:23:10 -04:00
Robin Gareus
15aa2a224e zero meters for inactive tracks 2013-08-08 15:23:10 -04:00
Robin Gareus
7b3968bf5f RMS meter - reset after calculating new data 2013-08-08 15:23:10 -04:00
Robin Gareus
ae544dc6c7 fix "monitor mode 11"
see http://www.oofus.co.uk/ardour/Ardour3MonitorModesV2.pdf
the overall logic can probably be simplified somewhat
track-rec-enable on -> always monitor input
2013-08-08 15:23:10 -04:00
Robin Gareus
a29dcc5a47 fix input metering:
if meter==input, meter depends on In/Disk
see also 29108187ed
2013-08-08 15:23:10 -04:00
Michael R. Fisher
ea08feec48 Temporary OSX/Clang/C++11 workaround
- Adds a directive that includes <vector> upon specific conditions
- WIP
2013-08-08 15:23:10 -04:00