Commit graph

40441 commits

Author SHA1 Message Date
Paul Davis
0254e7e6b0 removed unused optimization iterator from GhostRegions 2024-11-10 13:45:13 -07:00
Paul Davis
cdf88efeff fix crash caused by VelocityDisplay _optimization_iterator
Never use the _optimization_iterator when looking for a note to update or select
because those two conditions may be preceded by note add/delete operations (including
those via undo/redo) which would make the iterator invalid.

The _optimization_iterator only makes sense when actually iterating over the event list,
which is ironic because that's the one time we don't need it
2024-11-10 12:44:05 -07:00
Paul Davis
96ef4d20f2 when recording MIDI, create active_notes on demand
Since the signal handler for "data recorded" is in the GUI thread, we can do
whatever we want there, including memory allocation
2024-11-09 09:20:25 -07:00
Paul Davis
a7bd0da8ea fix missing initialization 2024-11-09 09:19:01 -07:00
Paul Davis
a76afae0e9 use smaller ("very small") text for rulers on macOS
This fixes a years-long visual issue with the rulers on macOS, where the
text has been MUCH larger than on Linux (and maybe Windows, not sure)
2024-11-08 17:16:12 -07:00
Paul Davis
8196734e3f change references to what was "very small text" to "smaller text";
This is more consistent with the naming of the font size for the canvas
via wscript.

Also, provide the new "very small" font size.

Also, several styles defined in clearlooks.rc.in used spaces in
font names or derived styles instead of underscores, this fixes that.
2024-11-08 17:14:33 -07:00
Paul Davis
c08cfa8109 more work on multiple automation display 2024-11-08 12:16:09 -07:00
Robin Gareus
c8b2c0c543
Fix crash looking up smart-mode
we need to call
  get_toggle_action (char const*, char const, bool d = false)
and not
  get_toggle_action (const string& name, bool)

For whatever reason `(string, char*)` matches the latter
function's signature.
2024-11-08 19:15:46 +01:00
Paul Davis
bbdb6b0e63 more extensive automation display design for cue editor 2024-11-07 16:10:31 -07:00
Paul Davis
f8f6e5d2ab implement newly-required inclusion of <cassert> 2024-11-07 16:10:02 -07:00
Juan Vardy
f2fc5fc0dc
Update Spanish translation 2024-11-07 17:51:11 +01:00
Robin Gareus
efbc8b4390
Turn touchscreen debug prints into gdk-debug messages 2024-11-07 06:13:12 +01:00
Paul Davis
2ad12280f6 fix erroneous API changes related to ::reset_write_sources() introduced in midilen branch
This restores peak file building after capture
2024-11-06 18:59:44 -07:00
Alejandro Domínguez
ed1ab8622e
Replace boost::function with std::function 2024-11-06 23:08:44 +01:00
Alejandro Domínguez
1124e191f0
Replace boost::integer::gcd with std::gcd 2024-11-06 23:08:36 +01:00
Alejandro Domínguez
5223b176f3
Replace boost::shared_array<T> with std::shared_ptr<T[]> 2024-11-06 23:03:19 +01:00
Robin Gareus
a3d4888be3
Replace boost::format with PBD::string_compose 2024-11-06 22:55:56 +01:00
Alejandro Domínguez
9544855fdd
Remove unused headers 2024-11-06 22:50:35 +01:00
Robin Gareus
5f2371a9e2
Fix 30dc9ccc86, buf2 needs to remain in scope.
This fixes a heap-use-after-free.
2024-11-06 17:24:25 +01:00
Zabooma
a6e2f856a2
Update track_organizer lua script to use text-area for comments 2024-11-06 16:39:22 +01:00
Zabooma
1155da84dd
Add text control type for LuaDialog, based on Gtk::TextView 2024-11-06 16:39:00 +01:00
Robin Gareus
a76d4b4c82
Fix class/struct mismatch (can cause with Windows builds) 2024-11-06 05:43:25 +01:00
Robin Gareus
ba4d9709c6
Properly check for syscall (#9845) 2024-11-06 04:08:19 +01:00
Robin Gareus
02fde5f1aa
Fix unlikely buffer overflow #9845
> warning: 'sscanf' may overflow; destination buffer in argument 6
> has size 32, but the corresponding specifier may require size 33
> [-Wfortify-source]
2024-11-06 04:08:19 +01:00
Paul Davis
ea64eb87c5 canvas; fix thinko and typo in Rectangle size_request() 2024-11-05 15:02:06 -07:00
Paul Davis
b3a22a024c add more buttons to midi cue editor and use Canvas::Box for packing 2024-11-05 14:59:20 -07:00
Paul Davis
a3deba207e Canvas: auto-fy a couple of lops in Box::reposition_children() 2024-11-05 14:58:44 -07:00
Paul Davis
e6758b6ba8 Canvas; make button handle dynamic size allocation 2024-11-05 14:56:37 -07:00
Paul Davis
b500eeb36e canvas; fix indent in Text::dump() 2024-11-05 14:56:11 -07:00
Paul Davis
5808c6e78f Canvas: fix logic bug when setting child items to be layout sensitive
Also, auto-fy the loop
2024-11-05 14:55:37 -07:00
Paul Davis
ba782dd097 Canvas; items added to a box become layout sensitive 2024-11-05 14:54:39 -07:00
Paul Davis
370b045715 canvas: fix typo in using explicit size request 2024-11-05 14:53:54 -07:00
Paul Davis
75177f3ef8 canvas: honor explicit size request for Rectangle 2024-11-05 14:53:22 -07:00
Paul Davis
19e4063b6b add a button bar and 1 button at the bottom of the MidiCueView 2024-11-05 13:27:22 -07:00
Paul Davis
39949e778d autofication of another loop 2024-11-05 13:27:22 -07:00
Paul Davis
d260b1d4c0 Canvas::Button improvements 2024-11-05 13:27:22 -07:00
Paul Davis
c1ad49a411 skeleton for a canvas button 2024-11-05 13:27:22 -07:00
Paul Davis
61f1466f50 use virtual methods to get MidiRegionView to do ::set_model() correctly 2024-11-05 13:27:22 -07:00
Robin Gareus
f17a656217
use modern C++ for snprintf (#9841)
This replaces vector<char>::operator[] (which now
a constexpr since C++20). We could use &vector::data(),
but a unique_ptr seems more appropriate for the case at hand.
2024-11-04 18:48:28 +01:00
Robin Gareus
c9645723de
ACE fluidsynth: unload soundfonts after use, refill channels #9837 2024-11-03 19:22:30 +01:00
laIK4ndPDScproJyv9ofA
f0ec6b5bda
Redraw arrangement rectangles upon tempo change
Previously, changing tempo would leave arrangement rectangles out of sync with markers.
2024-11-03 15:15:35 +01:00
Robin Gareus
a5c1a7feaf
Use new marker API in Lua scripts 2024-11-03 15:15:32 +01:00
John Emmas
3933fc2db7 Oops, missed one... 2024-11-03 13:33:57 +00:00
John Emmas
44068a63f5 Guard some pragmas which aren't understood by MSVC 2024-11-03 11:50:44 +00:00
Robin Gareus
1b13bf607f
Micro optimization: only queue resize when widget is realized 2024-11-03 02:49:51 +01:00
Robin Gareus
d6e3afd3ae
Fix class/struct forward declaration 2024-11-02 23:28:00 +01:00
Robin Gareus
37b0910d80
Windows Multitouch: disable gestures
Gestures may prevent a 2nd touch from being registered as
such (and instead report a zoom/pinch gesture).

At least that is my best guess, why Nathan needs 3 fingers
to move 2 Faders :)
2024-11-02 04:54:28 +01:00
Paul Davis
ced7441a19 remove debug output 2024-11-01 18:43:44 -06:00
Paul Davis
57252cd1c7 clip recording: begin/end write only happens on trigger arm/disarm 2024-11-01 17:45:00 -06:00
Paul Davis
56c99a43d2 remove any existing data display from a MidiView when ::begin_write() happens 2024-11-01 17:45:00 -06:00