Paul Davis
0b7d0ebfd6
remove debug output
2020-04-17 10:47:01 -06:00
Paul Davis
ca9e54100a
more sane design for MidiRegionView::nudge_notes()
...
Use nudge clock if snap/grid is disabled; use grid (and grid/4 if "fine" adjustment is chosen)
2020-04-16 21:39:38 -06:00
Paul Davis
8545250936
MidiRegionView no longer handles any keypresses or alters editor "note selection"
...
1. Alt is still handled to change drag behavior
2. Selection doesn't store notes unless they are part of the cut buffer, which means we should not
be altering the note selection in the editor's selection object most of the time.
2020-04-16 17:48:12 -06:00
Robin Gareus
4e005540c6
Update PatchChange when instrument/midnam changes
2020-04-04 01:48:30 +02:00
Robin Gareus
8d28115ec7
Update MIDNAM handling in GUI
...
* Always use InstrumentInfo for lookups.
Remove name lookups that directly used gui_property()
* Use set/get_gui_property() only to save/restore state,
push custom selection to InstrumentInfo.
* Only store custom selection, use unset for "default"
default = plugin-provided (if available) otherwise general-midi
2020-04-01 16:33:40 +02:00
Paul Davis
e6ce5a611c
shortest note length after a drag-trim is 1 tick, not 1/512 beats
2020-01-28 00:06:12 -07:00
Paul Davis
fd62b38f8d
correct computation of new note length after a front-drag-trim
2020-01-28 00:05:44 -07:00
Paul Davis
2d5a3013e0
fix 03c4335c1e to use the correct test for zero length
...
That commit used the dangerous Beats::operator== (int) comparison, which only campares the beat portion
2020-01-14 14:35:08 -07:00
Paul Davis
03c4335c1e
fix drawing of zero-length notes
...
Note that the result is too narrow to be manipulated, though it can be moved
2020-01-11 10:57:21 -07:00
Paul Davis
929bd7c8ac
use Note::end_time() == numeric_limits<Beats>::max() as the indicator that a note is in-process w.r.t. recording
...
We used to use length() == 0, but this clashes with actual zero-length notes
2020-01-11 10:57:21 -07:00
Paul Davis
2ae327fa8f
prevent MIDI note starts being drawn earlier than their region start
2020-01-08 10:22:08 -07:00
Paul Davis
a855119bdd
rename all Evoral source from .(hpp|cpp)$ to .(h|cc)
2019-11-02 16:32:18 -06:00
Paul Davis
b83ef09947
various adjustments so that a MidiPlaylist gets re-rendered whenever it changes.
...
This may still be missing a few changes (i.e. they do not cause re-rendering)
2019-11-02 16:32:18 -06:00
Paul Davis
0573e7cdf0
alter where note resolution happens when a re-rendering is scheduled for a MIDI track
2019-11-02 16:32:18 -06:00
Paul Davis
5b90bad68c
fix commented out decision on whether or not to hide/show sysexes in MIDI regions
2019-09-20 12:26:49 -06:00
Robin Gareus
4050ca5633
Update GPL boilerplate and (C)
...
Copyright-holder and year information is extracted from git log.
git history begins in 2005. So (C) from 1998..2005 is lost. Also some
(C) assignment of commits where the committer didn't use --author.
2019-08-03 15:53:15 +02:00
Ben Loftis
e0bdcd7137
(Source List) Clean up the natural_position implementation (gtk2 part).
2019-08-01 12:11:31 -05:00
Robin Gareus
eb4e854a56
Replace some more "samples" with "frames" (rectangles)
2019-04-09 00:31:29 +02:00
Robin Gareus
01a43c6b1e
Another round of whitespace fixes
2019-04-09 00:27:33 +02:00
Robin Gareus
a0b032efe2
Revert more "frame/sample" replacements
...
- Coverage concerns rectangles (frames, not sample)
- frame-handles are rectangles
- layout container boxes are frames
- inline display boxes are display_frame
2019-04-08 22:42:47 +02:00
Robin Gareus
8a7e452265
Yet another "Rect frame" (not a sample)
2019-04-08 20:57:56 +02:00
Robin Gareus
f9e12235c3
Frame as in "picture frame", not sample
2019-04-08 20:19:15 +02:00
Robin Gareus
83981a37a3
Ignore scroll-wheel while dragging notes.
...
Previously, dragging a MIDI note and scrolling with scroll wheel
(to change velocity) made the note jump back to location before drag.
2018-08-09 18:11:18 +02:00
Ben Loftis
0883f02de9
new_grid: The Return of the snap_to_X functions.
...
We no longer assume that Snap always uses the visible ruler lines.
If you want to snap to the grid, and ignore the users zoom scale, use SnapPref::SnapToGrid_Unscaled
This fixes 2 (known) oversights: "snap region(s) to grid" and "regions whose start are left of the canvas edge".
2018-07-27 00:28:47 +02:00
Paul Davis
b0e496c825
remove more unused MIDI note colors
2018-07-05 16:52:49 -04:00
Paul Davis
870fe055cf
make use-note-color-for-velocity much much more efficient
...
(by not invoking the global color change signal)
2018-07-03 18:33:11 -04:00
Paul Davis
a1df752095
call Note::set_velocity() at an appropriate time
2018-07-03 11:28:01 -04:00
Ben Loftis
f54f270627
Fix a few warnings
2018-02-17 09:12:38 -06:00
Ben Loftis
dc61256466
new_grid: Rewrite of Snap and Grid. (squashed commit)
...
Separate Snap from Grid. Lots of naming changes.
Multiple simultaneous snap options allowed. Grid is one of the possible Snap options.
Grid uses the same data as the rulers. Replace complicated tempo_lines with simple grid_lines.
The Grid is zoom-scale-sensitive along with the rulers. If you are zoomed out, grid becomes coarser.
2018-02-09 09:59:39 -06:00
Ben Loftis
d6eb1c826f
new_grid: MidiRegionView::motion should propagate thru RegionView, so snapped_cursor is updated. This probably fixes other bugs as well.
2018-02-09 08:26:27 -06:00
Ben Loftis
c6eab71435
new_snap: Snapped Cursor ( squashed commit )
...
Snapped Cursor is a line that follows the edit point, and indicates where the operation will occur.
This replaces and extends the line that appears with the Cut tool.
New associated preferences: snap_threshold and show_snap_cursor.
2018-02-09 08:21:45 -06:00
Paul Davis
b9c6ffac21
fix header order and space alignment
2017-09-24 12:57:27 -04:00
Paul Davis
7db12f6b12
convert codebase to use Temporal for various time types
2017-09-24 12:03:54 -04:00
Paul Davis
41bd6d3721
fix unintentionally edited color/theme name from f2s edit
2017-09-19 11:15:22 -04:00
Paul Davis
30b087ab3d
globally change all use of "frame" to refer to audio into "sample".
...
Generated by tools/f2s. Some hand-editing will be required in a few places to fix up comments related to timecode
and video in order to keep the legible
2017-09-18 12:39:17 -04:00
Paul Davis
e37558502e
changes required to operate with the Evoral::Beats ticktime commit
2017-09-18 11:40:53 -04:00
nick_m
d1932b23b3
Call Editor::abort_reversible_command() in MidiRegionView::abort_command()
...
Fixes broken undo stack if no changes occurred.
Edit note dialog is currently the only user.
2017-07-22 02:15:20 +10:00
André Nusser
77a2632e34
Fix compiler warning of unused variable.
2017-05-14 18:15:10 +02:00
Robin Gareus
05231949e6
When adding a PC, use the channel given in the dialog.
2017-03-29 23:53:56 +02:00
nick_m
16089bff96
more linked midi region trim drag fixes.
...
- freeze the correct playlists on fiorst move.
- only update the start offset of linked regions once the drag
has finished.
2017-03-06 15:51:53 +11:00
nick_m
1f9c26136c
rework percussive hit spraying.
...
- the spray is limited to the first entered note.
- all new notes are selected (requires a selection change to
MRV::create_note_at()
2017-03-05 01:57:10 +11:00
nick_m
e8b5b4fcf3
offset linked regions to compensate for negative start after trim drag.
...
- should fix 7105
2017-03-04 11:28:49 +11:00
nick_m
62cef7feff
also fix flying percussive hits while copy-dragging.
2017-02-24 01:11:56 +11:00
nick_m
ae3c50c495
hotfix for flying percussive hits while dragging.
...
- Hit::position still may not be set correctly,
but this patch eliminates the error for now.
2017-02-24 00:36:58 +11:00
nick_m
b24dd49c1a
update note length when dragging notes (over tempo change)
2017-02-07 03:10:02 +11:00
nick_m
987c1cb94a
remove overzealous bounds check when dropping notes.
2017-02-05 05:26:18 +11:00
nick_m
5031bdcf10
midi note drags are music-based.
...
- wysiwyg (during drag) when dragging more than one note across
a tempo change.
- introduces a muscal equivalent of snap_delta (only used for
note drags atm)
- split earliest note in selection into a separate function
- MRV::copy_selection() returns the equivalent _primary note
to avoid offset hell.
- RV::snap_frame_to_frame returns a MusicFrame
- prevent note drag moving before region start.
2017-02-05 05:02:01 +11:00
John Emmas
fac04afbba
If 'MidiRegionView::find_canvas_sys_ex()' fails, make it return a boost::shared_ptr<> (rather than returning an int)
2017-02-04 16:14:56 +00:00
nick_m
f7b005ebf1
clean up patch change/sysex headers.
2017-02-04 22:57:36 +11:00
nick_m
2eca71e6f1
set sysex height & position on redisplay.
2017-02-04 22:57:36 +11:00