smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-09 16:24:57 +01:00
Code Issues Projects Releases Wiki Activity
38387 commits 101 branches 144 tags 307 MiB
Commit graph

38387 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Davis
da4d16b1f2 launchpad pro: remember to destroy GUI to avoid use-after-free in its connection handler 2023-10-13 09:47:22 -06:00
Paul Davis
e61c1f6993 launchpad pro: use regexes more extensively to find ports to connect to 
Hopefully this works for ALSA, Windows and macOS, whereas the previous version worked only
for JACK1
 2023-10-12 21:19:21 -06:00
Paul Davis
dfbe4f61cd more debug output for bad buffer sized trout 2023-10-12 21:19:21 -06:00
Robin Gareus
ca1e466f26
Replace altool with notarytool for Apple packages 
altool will stop working on Nov 1st.
 2023-10-11 23:35:06 +02:00
Robin Gareus
d8a3f771c2
Backport Mixbus osx-build script changes 2023-10-11 18:45:03 +02:00
Robin Gareus
653cd3fa17
Fix double free, heap-use-after-free 
_canvas_grid_zone and _section_box are destroyed when the
Canvas Container (here: `_track_canvas_viewport`) deletes
child items.
 2023-10-11 16:06:35 +02:00
Robin Gareus
f83fe558e1
Remove --windows-vst (option from build-script) 
Since VST is enabled by default, that option was removed.
 2023-10-11 00:51:00 +02:00
Robin Gareus
273f81fad7
VarispeedDialog fixes, use 100% for speed 1.0 
* Honor max-speed
* Fix percentage off-by one (100%)
* keep cents in range -50 .. +50
 2023-10-10 05:12:53 +02:00
Robin Gareus
417f3647cc
Keep shuttle ctrl in sync with actual speed 
When using "VS" the numeric control shows the "default speed"
when not rolling. Then when starting to roll default speed will
be the actual speed.

Previously the shuttle was not updated when `last_speed_displayed`
was the current speed. This dated back to before "VS" showed
default speed.
 2023-10-10 04:18:53 +02:00
Robin Gareus
0f21d26f2c
Mitigate varispeed by percentage issues by constraining range 2023-10-09 23:25:15 +02:00
Robin Gareus
bb211564a8
The return of the -x86_64 suffix for macOS DMG 
We previously dropped it when we discontinued 32bit builds.
But now that we have -arm64, it is only consistent.
 2023-10-09 22:47:28 +02:00
Stian Grindvoll
5a7f750e7c
Fix ardour not loading Moog Subsequence 37 midnam 2023-10-09 21:54:41 +02:00
Stian Grindvoll
cfd19197b2 Add Midname for Moog Subsequent_37 2023-10-09 13:37:47 -06:00
Robin Gareus
1b0f248e68
Fix creating sessions using CLI arguments (#9473) 
Initialize uninitialized variable. Previously this crashed
when setting up the session's time-domain.
 2023-10-09 21:16:09 +02:00
Robin Gareus
b803179768
Fix label in insert-time dialog 
The return of the accidentally removed label in 5b038e488
 2023-10-09 20:24:19 +02:00
Paul Davis
4f2c86f670 enforce time domains for region trims 2023-10-09 11:19:22 -06:00
Paul Davis
0fa63b6d37 add percentage field to varispeed dialog 
All fields are kept sync'ed to each other, so it does not matter
which one(s) you use
 2023-10-09 11:09:07 -06:00
Robin Gareus
c0d91362cf Fix duplicate close-session dialog on macOS 
Previously [GtkApplicationDelegate applicationShouldTerminate:]
triggered both StartupFSM::queue_finish and ArdourUI::queue_finish.
Both of which registered an idle-callback to call ArdourUI::finish.
 2023-10-09 17:19:17 +02:00
Robin Gareus
120979bd76
Remove unused variable 2023-10-07 22:43:27 +02:00
Robin Gareus
c5b2c4432e
Fix tracing internally connected MIDI ports 
MIDI track A -> MIDI track B
The data on Track B's input is not available at cycle-start.
 2023-10-07 22:43:27 +02:00
Paul Davis
a5712d1f85 remove comment referring to glue-to-time-domain 2023-10-07 13:16:08 -06:00
Paul Davis
d67e7cd222 remove some preference metadata related to removed options 2023-10-07 13:14:39 -06:00
Paul Davis
bebe6587a2 tweak launchpad pro port name for probe to be x-platform 2023-10-07 11:43:07 -06:00
Paul Davis
d6323a1686 GUI side of 122c9141 (API change for TempoMap::move_meter()) 2023-10-07 11:11:31 -06:00
Paul Davis
afe74bb460 use Meter::round_to_bar() rather than BBT_Time::round_(up|down)_to_bar 
this gives slightly better behavior when dragging a meter marker
 2023-10-07 11:11:31 -06:00
Paul Davis
64458c2430 prevent meter changes being dragged "through" a BBT marker 
might want to do this for tempo drags too
 2023-10-07 11:11:31 -06:00
Paul Davis
ec34c2137d avoid a crash when dragging a meter change near a BBT marker 2023-10-07 11:11:31 -06:00
Robin Gareus
cece64e649
Remove another accidentally commited debug message 2023-10-07 18:25:32 +02:00
Robin Gareus
f78d82a192
Allow single click to create Region-Gain points (again) 
regression was introduced in 18819a48a9
 2023-10-07 18:17:36 +02:00
Robin Gareus
b962addc8c
Fix Region Gain freehand draw offset for regions with start offset 2023-10-07 17:55:39 +02:00
Robin Gareus
31730794be
Remove debug output from 5426bbfd57 2023-10-07 16:59:26 +02:00
Robin Gareus
5426bbfd57
Allow single-click on TempoMap Ruler markers 
This fixes the abort, when clicking on a Tempo, Meter or BBT
Marker using the grid tool.
 2023-10-07 15:54:23 +02:00
Robin Gareus
b87937a20e
Fix crash when double-clicking on TempoMap Ruler markers 
heap-use-after-free. Marker is deleted (and re-created), when
the tempo-map edit is aborted:

```
    #0 0x7f77528ac017 in operator delete(void*) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:160
    #1 0x55f81062800d in TempoMarker::~TempoMarker() ../gtk2_ardour/marker.cc:794
    #2 0x55f80ffb2fc0 in Editor::reset_tempo_marks() ../gtk2_ardour/editor_tempodisplay.cc:205
    #3 0x55f80ffb2b19 in Editor::reset_metric_marks() ../gtk2_ardour/editor_tempodisplay.cc:185
    #4 0x55f80ffb49fb in Editor::tempo_map_changed() ../gtk2_ardour/editor_tempodisplay.cc:301
    #5 0x55f80ffbdf00 in Editor::abort_tempo_map_edit() ../gtk2_ardour/editor_tempodisplay.cc:850
    #6 0x55f80fcf967a in TempoMarkerDrag::finished(_GdkEvent*, bool) ../gtk2_ardour/editor_drag.cc:333
```

Since no movement occurred, the tempo-map was not changed.
however we need to drop the lock and writable thread-pointer...
 2023-10-07 15:35:15 +02:00
Paul Davis
bdd0fda188 remove debug output 2023-10-06 17:08:28 -06:00
Paul Davis
26eed327ad amend 405574184 with correct lock scope and do not hold state 2023-10-06 17:07:44 -06:00
Paul Davis
405574184a use a RegionWriteLock while modifying Playlist region list in ::region_bounds_changed 2023-10-06 16:17:12 -06:00
Robin Gareus
d95179f571
NO-OP: remove unused, unimplemented functions 2023-10-05 21:56:42 +02:00
Robin Gareus
4a8dc04f14
Remove ScrubDrag and vari-speed based fake-scrubbing 2023-10-05 21:53:39 +02:00
Robin Gareus
96c45b65ee
Remove more or less useless Mouse Audition Button 
Audition action is very much preferred and also works with
multiple selection.
 2023-10-05 21:49:55 +02:00
Robin Gareus
e9bde1c638
Make all "Feedback"s translatable #9461 2023-10-05 21:11:59 +02:00
Paul Davis
eba00287cd fix SNAFU with ordering of adding stripables and selecting them 
when Session emits RouteAdded, each handler (editor, mixer, trigger pages etc) will
execute their callbacks in order. But Editor::add_routes() selects the routes too,
which triggers a PresentationInfo::Change signal. This is received by e.g. the Mixer
before it has even found out about the newly added stripables. This in turn
leads to severe confusion regarding the state of the selection in the mixer,
and potentially elsewhere.

So, just add a PresentationInfo::ChangeSuspender for the scope of the RouteAdde
signal emission
 2023-10-05 12:57:16 -06:00
Paul Davis
cd1d83f366 reintroduce a fake XML "active" property for Tempo to allow 7.x to load 8.x sessions 2023-10-05 11:22:38 -06:00
Paul Davis
558b300177 tweaks to arprof to make it more useful with CALLGRIND_* macros 2023-10-05 08:31:11 -06:00
Paul Davis
e23f79a8a9 do not create a Gtk::ColorSelectionDialog for every trigger/slot, create on demand 2023-10-05 08:31:11 -06:00
John Emmas
14973bd894 Simplify the MSVC / superclock change which should now be compatible with all compilers 2023-10-05 14:01:32 +01:00
Paul Davis
91f50b8a06 in insert time, don't differentiate between audio/music time markers 2023-10-04 18:50:42 -06:00
Paul Davis
dd556f6ee8 NO-OP: line formattting 2023-10-04 18:50:42 -06:00
Paul Davis
85f0648b6b don't pass unnecessary argument to Playlist::shift() 2023-10-04 18:50:42 -06:00
Paul Davis
62416ee276 remove unnecessary argument from Playlist::shift() 2023-10-04 18:50:42 -06:00
Robin Gareus
c3b881327c
Possible fix for MSVC build 2023-10-05 01:50:37 +02:00