Commit graph

14155 commits

Author SHA1 Message Date
Robin Gareus
d76589d90f FP8/16: include makeup gain control 2018-09-28 16:19:40 +02:00
Albert Graef
65693a72a2 MCP: Fix up the feedback for the view selection buttons. 2018-09-27 11:31:13 -04:00
Albert Graef
38bccabeca MCP: Allow the current bank to move right one channel even if this results in a partial bank.
Rationale: This change is trivial, but Ardour's behavior of refusing to move right one channel unless a full bank remains has been there for a long time, and there are probably good reasons for it. This design was likely conceived when all MCP-compatible devices had banks of 8 faders anyway. However, with the advent of affordable single-strip devices like the X-Touch ONE it becomes a real issue.

Single-strip devices can only access the first channel in the current bank, so relaxing this restriction is the easiest way to enable such devices to access all strips, while still maintaining the usual bank size of 8. Note that maintaining a bank size of 8 is beneficial even with single-strip devices for several reasons:

- It allows use of the bank switch buttons to flip through a large number of strips more quickly.

- It maintains compatibility with existing device descriptions. E.g., the X-Touch ONE can be used with the existing X-Touch device description without any ado.

- Most importantly, it maintains compatibility with other MCP-compatible controllers which do have 8 strips and may be connected to Ardour at the same time. E.g., one might want to use an X-Touch Mini, or even a full-size X-Touch along with the X-Touch ONE in some use cases. Changing the bank size to 1 affects all connected MCP devices, so you'd rather keep the bank size to 8 in such scenarios. (Ardour should preferably have separate bank size settings for each connected MCP device, but that isn't possible right now since only one MCP device description can be active at the same time.)
2018-09-27 11:31:13 -04:00
Albert Graef
936f6814ac MCP: Fix up the feedback for the bank left/right buttons. 2018-09-27 11:31:13 -04:00
Paul Davis
c4fcd0c268 consolidate all transport masters on a SafeTime object that is a member of the TransportMaster base class.
This seems to have broken some aspects of chasing/locking
2018-09-27 11:31:13 -04:00
Paul Davis
147d456dbd change type of MIDI::Parser::position signal to include timestamp 2018-09-27 11:31:13 -04:00
Paul Davis
0f7123d33a more objectification for SafeTime 2018-09-27 11:31:13 -04:00
Paul Davis
b6aefaf100 initial hacks towards a truly thread-safe SafeTime object, using boost::atomic 2018-09-27 11:31:13 -04:00
Robin Gareus
3c11660d2a VST-state, set/restore program before loading chunk.
This may fix some issues with VST state being restored incorrectly
when a plugin-preset was loaded.
2018-09-25 21:46:59 +02:00
Robin Gareus
99a8899c2d Add Lua bindings to query DSP load statistics 2018-09-25 18:01:22 +02:00
Paul Davis
6ca8ec5141 remove debug output 2018-09-23 13:48:19 -04:00
Paul Davis
12d5eb9a34 remove debug output 2018-09-23 13:48:19 -04:00
Paul Davis
d48dd0ccd5 defer creating a visibility tracker for a window until the window is mapped
Without this, the visibility tracker will report that the window is not visible at startup, and
this overrides the XML _visible property which denotes that the window should be made visible
2018-09-23 13:48:19 -04:00
Paul Davis
b9d8f75119 emit property change for "collect" on a TransportMaster 2018-09-23 13:48:19 -04:00
John Emmas
fd23f89b35 Accommodate newly added/renamed source(s) in our MSVC project (libardour) 2018-09-22 16:55:43 +01:00
Jan Lentfer
e52c8e376a LCXL: fix off by one cause by fader8master 2018-09-22 15:12:26 +02:00
Jan Lentfer
7d6c9c3085 LCXL: Fix a crash on exit 2018-09-22 15:12:26 +02:00
Paul Davis
3b151c8cfb no more slave.h 2018-09-22 09:03:50 -04:00
Paul Davis
c83d5add7b use abs() instead of fabs() on integers 2018-09-22 08:51:58 -04:00
Paul Davis
f39bcaa4bf Revert "MSVC complains because we're using 'fabs()' to compare 2 x integers"
You can't remove an abs() conversion and keep the same semantics.

This reverts commit d89b8cc0ad.
2018-09-22 08:50:16 -04:00
Paul Davis
62f29d6c44 remove old slave files 2018-09-22 08:49:24 -04:00
John Emmas
736b6a3e57 Replace a namespace brace deleted by accident 2018-09-22 09:08:44 +01:00
John Emmas
a3a156520d Remove some namespace ambiguity
There are a couple of places where we're using both MIDI namespace as well as ARDOUR namespace (both of which declare 'pframes_t)
2018-09-22 08:48:41 +01:00
John Emmas
0354dbdfe9 Remove 2 x unneeded functions in 'SlaveSessionProxy'
I assume they're not needed now because their declarations got removed in commit #e6915e01de
2018-09-22 08:44:42 +01:00
John Emmas
d89b8cc0ad MSVC complains because we're using 'fabs()' to compare 2 x integers 2018-09-22 08:39:34 +01:00
Robin Gareus
6dd6f6bb16 Fix typo: emit signal (don't construct an object) 2018-09-21 21:35:28 +02:00
Robin Gareus
357361c89d Fix --no-nls (4/5), i18n include order in libs/*
"i18n.h" needs to be included last (after any includes that may indirectly
pull in getext or libintl etc)
2018-09-21 19:05:39 +02:00
Robin Gareus
497a3fbaa1 Fix --no-nls (2/5), prefer #if in libs
This is for consistency with system-wide gettext.h which is used
by some 3rd party libs. system-wide gettext uses `#if ENABLE_NLS`,
not #ifdef
2018-09-21 19:03:33 +02:00
Paul Davis
03e5b97921 missing enum/properties stuff 2018-09-20 12:00:16 -04:00
Paul Davis
9cdbeaa07d switch transport masters to use properties and notify via PropertyChanged 2018-09-20 11:30:28 -04:00
Paul Davis
84930c0cf1 namespace change to help out on non-linux platforms 2018-09-18 21:35:33 -04:00
Paul Davis
a183b3bff4 do not initialize boost::shared_ptr<> with zero 2018-09-18 21:26:43 -04:00
Paul Davis
87c11bcc2e boost/atomic.hpp is not used 2018-09-18 20:01:05 -04:00
Paul Davis
e6915e01de new transport slave/master implementation, libs/ edition 2018-09-18 19:06:04 -04:00
Len Ovens
7390b88c2b OSC: Allow personal monitor to change output connection 2018-09-18 15:39:14 -07:00
Colin Fletcher
9321f46c45 Implement new Enclosed region equivalence mode 2018-09-13 14:05:47 -04:00
Robin Gareus
f9f0b4aabd LTC-file reader: offset frame position (not timecode) 2018-09-11 16:02:42 +02:00
Robin Gareus
d7dc224da5 Fix LTC file-reader -- closes #7661
Change reader API to return the position of the decoded LTC frame
and store the correct position in the array)
This bug was introduced in e5a181c323
2018-09-11 16:02:42 +02:00
Len Ovens
a96aa4e1fd OSC: Personal monitoring can add a new aux 2018-09-10 09:58:15 -07:00
John Emmas
79f01bc889 Initial changes needed for building Mixbus (with MSVC) as version 5
(Mixbus itself will probably need extra changes)
2018-09-10 07:14:59 +01:00
Robin Gareus
2172337306 Add missing cast (NoteButton to TrackButton) 2018-09-06 23:03:55 +02:00
Robin Gareus
e1c58aad60 Fix an invalid conversion from 'int' to non-scalar. 2018-09-06 19:28:45 +02:00
Jan Lentfer
eff7a51de1 LCXL: Refactor code to use boost::shared_ptr 2018-09-04 18:55:49 +02:00
Robin Gareus
ed678aa2f9 Fix shared_ptr initialization
error: no matching function for call to
 'boost::shared_ptr<ArdourSurface::Push2::Button>::shared_ptr(int)'
2018-09-03 13:38:37 +02:00
Paul Davis
6e419a961e use boost::shared_ptr<> to manage Button/Pad lifetimes in Push2 code 2018-09-02 13:23:57 -04:00
Térence Clastres
2a78f0a852 LCXL: Fix check if ports exist 2018-08-30 22:39:24 +02:00
Robin Gareus
9f30d14906 P2: Fix check if ports exist 2018-08-30 22:28:31 +02:00
Jan Lentfer
c3d0c80f68 LCXL: Fix two crashes
* fix a crash when accessing VCAs
    * fix a crash when being at the end
      of available stripables
    * unify for-loop constructs
2018-08-29 23:40:26 +02:00
Robin Gareus
46175b6b60 Increase alsa-backend timeout
Following discussion (https://community.ardour.org/node/15805 and
#ardour IRC) test initial disconnect due to timeout after a cold-boot.
2018-08-29 19:23:53 +02:00
Jan Lentfer
fdbce2e8c8 LCXL: add visual feedback for sec button functions
also add some little fixes in regard
    to fixing master fader on controller
    fader no 8
2018-08-25 22:51:31 +02:00