Paul Davis
d58e7c7ee4
Revert "fix handling of SMF files with consecutive noteOn events"
...
This breaks MIDI files that have events ordered On,On,Off,Off, and only fixes
the "malformed" On,On,Off. Correct fix requires collecting all events occuring
yat one time, sorting into Off,On and then merging.
This reverts commit 5c3e5f9afb .
2021-06-29 17:29:29 -06:00
Robin Gareus
fff2d2c5ad
Revert "Fix crashes when unloading mac VST2 plugins"
...
This reverts commit b01fe8b0e4 .
2021-06-30 01:05:09 +02:00
Robin Gareus
72242353f3
Revert "Fix mac builds - amend b01fe8b0e"
...
This reverts commit 45c8944789 .
2021-06-30 01:05:04 +02:00
Robin Gareus
4170482aaf
Revert "VST2: Consolidate support methods (close, unload)"
...
This reverts commit 5e54425a35 .
This is not compatible with current 6.x vst-info-file.
2021-06-30 00:22:17 +02:00
Paul Davis
a36ab0c562
avoid timing stats calculation with <= values from get_microseconds()
2021-06-29 11:13:59 -06:00
Paul Davis
a9f285b82b
debugging timing stats by showing how max values are computed
2021-06-29 09:46:46 -06:00
Paul Davis
9d88f370ae
debug windows RunLoop timing stats
2021-06-29 09:25:38 -06:00
Paul Davis
24ea6c4d30
make it possible to debug one of the RAII TimingStats objects
2021-06-29 09:25:38 -06:00
John Emmas
821d79e5a8
MSVC doesn't offer strings.h
2021-06-29 10:01:23 +01:00
Robin Gareus
a0f49fe5d0
Fix 32bit OSX builds (missing reference to bzero from Carbon.h)
2021-06-29 05:22:57 +02:00
Robin Gareus
b35a8f6626
Fix Wsign-compare, consistently use microseconds_t
2021-06-29 02:04:02 +02:00
Robin Gareus
bd6fb8f172
Fix issue when importing m4a
...
PBD::RingBuffer<>::rw_vector can return a NULL pointer
for the 2nd buffer, which can lead to undefined behavior:
`memcpy (NULL, src, 0);`
2021-06-29 00:11:17 +02:00
Paul Davis
b20a541d7e
change PBD::microseconds_t to a signed type and check for -1 in TimingStats::update
...
This may help a Windows issue with the return value of QueryPerformanceCounter
2021-06-28 14:47:48 -06:00
Robin Gareus
45c8944789
Fix mac builds - amend b01fe8b0e
2021-06-28 20:58:36 +02:00
Paul Davis
5c3e5f9afb
fix handling of SMF files with consecutive noteOn events
...
We no longer store nascent notes when noteOn is received, but wait till noteOff arrives. We also
ignore all other noteOn events between the earliest received and the noteOff.
Potentially we may want to use the _overlap_pitch_resolution member at some point
to offer control of this behavior.
2021-06-28 08:30:38 -06:00
Robin Gareus
b01fe8b0e4
Fix crashes when unloading mac VST2 plugins
...
CFBundleRef is reference counted, so we need to retain
a reference. Previously it went out of scope at the end
of mac_vst_load().
2021-06-28 15:46:27 +02:00
Robin Gareus
5e54425a35
VST2: Consolidate support methods (close, unload)
2021-06-28 15:42:57 +02:00
John Emmas
09589c3c94
Add/remove source(s) in our MSVC project (libpbd)
2021-06-28 10:37:54 +01:00
Paul Davis
4fd639eca9
NOOP: remove incomplete comment
2021-06-27 12:48:29 -06:00
Paul Davis
a261d399e0
microsoft docs say that only windows.h is required for QueryPerformance*
2021-06-27 12:17:51 -06:00
Paul Davis
e2f2d0cb0f
fix inadvertent typo that would cause compilation failure on windows
2021-06-27 10:53:31 -06:00
Paul Davis
857a9b14d7
more macOS cleanup for microseconds.cc
2021-06-27 10:39:51 -06:00
Paul Davis
347ca5c2fe
clean up locally-created mess in libs/pbd/microseconds.cc
2021-06-27 10:28:53 -06:00
Paul Davis
412b6a922d
macOS: slight speed up for ::get_microseconds()
...
Move timebase initialization into microsecond_timer_init() and drop conditional
2021-06-27 10:23:44 -06:00
Robin Gareus
b58dfc7f0f
Resolve microseconds_t ambiguity 1/2
...
This resolves a PBD vs ARDOUR namespace error for some compilers:
```
error: reference to 'microseconds_t' is ambiguous
libs/pbd/pbd/microseconds.h:29:19: error: candidates are: typedef uint64_t PBD::microseconds_t
libs/ardour/ardour/types.h:81:29: error: typedef PBD::microseconds_t ARDOUR::microseconds_t
```
2021-06-27 17:33:05 +02:00
Robin Gareus
7b5d61b7a5
Fix transport master crash when switching backends
...
Port registration happens asynchronously. During the first process
callbacks the timecode/clock input ports may not have been
re-established.
2021-06-27 16:37:33 +02:00
Paul Davis
db0691d236
macOS: fix compilation warnings on macOS versions where clock_gettime() is finally implemented
2021-06-27 08:24:59 -06:00
Robin Gareus
738b0ad21b
Fix OSX builds (amend 04df26244, a2b5962b6)
2021-06-27 05:09:07 +02:00
Paul Davis
b904fdea5d
switch PBD::Timing* to use PBD::get_microseconds()
2021-06-26 20:15:12 -06:00
Paul Davis
c2f7b12b0d
window compilation fix
2021-06-26 19:02:47 -06:00
Paul Davis
fb562ddb61
window compilation fix
2021-06-26 19:02:13 -06:00
Paul Davis
74538b7114
window compilation fix
2021-06-26 18:58:23 -06:00
Paul Davis
2678366555
window compilation fix
2021-06-26 18:53:28 -06:00
Paul Davis
228231d914
window compilation fix
2021-06-26 18:47:08 -06:00
Paul Davis
5c8df87205
window compilation fix
2021-06-26 18:43:17 -06:00
Paul Davis
5289d44821
window compilation fix
2021-06-26 18:40:44 -06:00
Paul Davis
d1967827ca
compilation error fix for windows
2021-06-26 18:35:14 -06:00
Paul Davis
b9a85c7dcd
compilation error fix for windows
2021-06-26 18:34:46 -06:00
Paul Davis
4c1dcb70bb
compilation error fix for windows
2021-06-26 18:33:27 -06:00
Paul Davis
a2b5962b6c
add new files for PBD::get_microseconds()
2021-06-26 18:30:11 -06:00
Paul Davis
9cbaa31c7e
libs fix for get_microseconds() move to libpbd
2021-06-26 18:27:39 -06:00
Paul Davis
04df262447
tweak libardour to reflect get_microseconds() move to libpbd
2021-06-26 18:26:13 -06:00
Paul Davis
9e598548f7
put get_microseconds() into PBD namsepace
...
This implementation is a blend of the two previously in libs/ardour/globals.cc
and libs/pbd/window_timer_utils.cc
2021-06-26 18:25:02 -06:00
Paul Davis
a2974b0c0b
portaudio: improved compilation error fix
2021-06-26 12:56:49 -06:00
Paul Davis
8bc4464309
portaudio: compilation error fix
2021-06-26 12:51:54 -06:00
Paul Davis
7e858b9bda
portaudio: add standardized DSP statistics to portaudio backend (uncompiled)
2021-06-26 12:32:23 -06:00
Paul Davis
74c93f3ff3
coreaudio: fix dsp stats collection
2021-06-26 11:42:18 -06:00
Paul Davis
a05bf30ccb
CoreAudioSource: fix formatting error
2021-06-26 11:28:15 -06:00
Paul Davis
c7bed1320e
adding DSP stats to coreaudio backend (uncompiled)
2021-06-26 11:25:07 -06:00
Paul Davis
995137aeb3
add PBD::WaitTimerRAII with reverse semantics from PBD::TimerRAII
2021-06-26 11:24:59 -06:00