Paul Davis
873f78de78
NOOP: rearrange code DiskReader::get_midi_playback() to follow the "early exit for conditional" style guide
2022-06-25 13:36:55 -06:00
Robin Gareus
64f9829b56
AudioBackends: ignore setting latency of invalid port(s)
2022-06-24 19:55:17 +02:00
Robin Gareus
fe0e997335
Backend: prefer debug_msg over PBD::Transmitter in threads
...
PBD::Transmitter is neither thread-safe nor rt-safe. This likely
fixes a crash on macOS when process-threads are started.
Many threads simultaneously enter coreaudio_process_thread() and
log a message calling `PBD::info << .. << endmsg` simultaneously.
2022-06-24 19:27:57 +02:00
Robin Gareus
9ab32d7cb4
Fix builds on platforms without execinfo (amend cd4549aff7)
2022-06-23 01:59:58 +02:00
Paul Davis
5831ddd40b
amend b30ac5e221 to actually replace the assert with a return
2022-06-22 16:09:38 -06:00
Paul Davis
0d9656ef82
use new macros to cleanup #ifndef NDEBUG as much as possible (libs edition)
2022-06-22 13:31:08 -06:00
Paul Davis
0004ca2c41
add useful DEBUG_RESULT and DEBUG_RESULT_CAST to pbd/debug.h
2022-06-22 13:31:08 -06:00
Paul Davis
d917d7b351
fix actual x_assert macro definition
2022-06-22 13:31:08 -06:00
Paul Davis
df641765ec
add new header for x_assert() macro
2022-06-22 13:31:08 -06:00
Paul Davis
4599b07217
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
046cdf1295
fix unused variable warning by removing it.
2022-06-22 13:31:08 -06:00
Paul Davis
41948821e2
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
ebb9d3d4dc
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
26d2c8a7fa
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
bb5798ee66
fix may-be-used-unset warning and bizarre brace/indent style
2022-06-22 13:31:08 -06:00
Paul Davis
6fd4c01fc9
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
4878c48386
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
7a32ff33d4
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
f7b91d577b
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
9922daf284
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
24f1a65d5f
use C style cast in C code, rather than C++ constructor
2022-06-22 13:31:08 -06:00
Paul Davis
48a109e8c8
fix snprintf buffer size warning
2022-06-22 13:31:08 -06:00
Paul Davis
660d2fc8ab
fix strncpy() size argument error (Windows only, needs review)
2022-06-22 13:31:08 -06:00
Paul Davis
9b80d6558a
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
ad8e1c1cfd
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
45403dd2f1
fix may-be-used-unset warning
2022-06-22 13:31:08 -06:00
Paul Davis
b30ac5e221
replace unnecessary assert(0) with return;
2022-06-22 13:31:08 -06:00
Paul Davis
4ee854e7df
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
123cc92fff
fix may-be-used-unset warning
2022-06-22 13:31:08 -06:00
Paul Davis
7436a110dc
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
ecefe29d5e
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
6fdd745dc5
fix may-be-used-unset warning
2022-06-22 13:31:08 -06:00
Paul Davis
311e36b28f
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
168b540959
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
0e1f62e605
fix optimized build unused variable warnings and abort not assert
2022-06-22 13:31:08 -06:00
Paul Davis
f1a24fac98
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
f78d384281
fix may-be-used-unset warning
2022-06-22 13:31:07 -06:00
Paul Davis
1e09e0f6fa
fix may-be-used-unset warnin
2022-06-22 13:31:07 -06:00
Paul Davis
ed645761d0
fix optimized unused variable warning
2022-06-22 13:31:07 -06:00
Paul Davis
ae9c11fb01
fix redefined CANVAS_DEBUG warning
2022-06-21 17:35:01 -06:00
Paul Davis
670b1fe3e2
fix initialization order warning
2022-06-21 17:34:48 -06:00
Paul Davis
ac18b84351
remove always-true-condition from if() to avoid compiler warning
2022-06-21 17:34:09 -06:00
Paul Davis
b51c4b7ef9
fix signed/unsigned warning
2022-06-21 17:33:37 -06:00
Paul Davis
181f40a349
fix signed/unsigned warning
2022-06-21 17:33:22 -06:00
Paul Davis
83b5fdf569
fix unused code warning
2022-06-21 17:33:04 -06:00
Paul Davis
cd4549aff7
fix signed/unsigned warning
2022-06-21 17:31:50 -06:00
Paul Davis
dc4235efbe
fix left-shift of negative value warning
2022-06-21 17:31:17 -06:00
Paul Davis
e2ef135161
remove unused warning
2022-06-21 17:30:59 -06:00
Paul Davis
f679da4e1e
simplify implementation of Beats::operator%= (Beats)
2022-06-21 14:46:20 -06:00
Paul Davis
5d81535588
remember to use muldiv() when doing a*b/c; also no need to call to_ticks(), just use _ticks
2022-06-21 14:46:20 -06:00