Robin Gareus
b0738b1950
Fix tempo-marker/curve z-axis stacking
...
Previously it was possible that the tempo-curve display was rendered
above a tempo-marker (e.g. create a marker in the between of existing
markers). With the tempo-curve in front, markers on the right
became inaccessible.
2022-06-26 16:20:00 +02:00
Robin Gareus
944b0ed6e0
Prefer const iterators when container does not change
2022-06-26 13:55:46 +02:00
Paul Davis
c3f40aedeb
tempodisplay: fix thinko in display of tempo/meter/bartime markers
...
Code used to just push back new markers to the end of the relevant list, and
this would then the new marker to be deleted soon thereafter. Instead pass
an interator indicating where to place the marker in the list.
Note that we rely on the use of std::list<T> here to keep the iterator to the
existing marker valid.
2022-06-25 22:26:34 -06:00
Paul Davis
873f78de78
NOOP: rearrange code DiskReader::get_midi_playback() to follow the "early exit for conditional" style guide
2022-06-25 13:36:55 -06:00
Robin Gareus
d9ce918c41
Small test tool for PBD::Transmitter thread-safety tests
...
Launch as
```
./session_utils/run ardour7-debug_transmitter
./session_utils/debug ardour7-debug_transmitter
```
2022-06-24 21:11:51 +02:00
Robin Gareus
64f9829b56
AudioBackends: ignore setting latency of invalid port(s)
2022-06-24 19:55:17 +02:00
Robin Gareus
fe0e997335
Backend: prefer debug_msg over PBD::Transmitter in threads
...
PBD::Transmitter is neither thread-safe nor rt-safe. This likely
fixes a crash on macOS when process-threads are started.
Many threads simultaneously enter coreaudio_process_thread() and
log a message calling `PBD::info << .. << endmsg` simultaneously.
2022-06-24 19:27:57 +02:00
Robin Gareus
9ab32d7cb4
Fix builds on platforms without execinfo (amend cd4549aff7)
2022-06-23 01:59:58 +02:00
Paul Davis
5831ddd40b
amend b30ac5e221 to actually replace the assert with a return
2022-06-22 16:09:38 -06:00
Robin Gareus
7b7f17085b
Fix crash when using get_all_equivalent_regions wih VCAs in a session
2022-06-22 22:22:52 +02:00
Paul Davis
e8e21b3152
NOOP: fix comment for abort-after-fatal to follow norms
2022-06-22 13:31:08 -06:00
Paul Davis
3245a89bfe
add comment explaining non-idiomatic C++
2022-06-22 13:31:08 -06:00
Paul Davis
b2d553cc51
editor: fix HitCreateDrag to (a) not crash (b) use the right length (c) snap correctly
2022-06-22 13:31:08 -06:00
Paul Davis
1de542120a
editor: remove a couple of unnecessary uses of Beats::from_double() and uses ::ticks() method instead
2022-06-22 13:31:08 -06:00
Paul Davis
22e77130e2
use new macros to cleanup #ifndef NDEBUG as much as possible (GUI edition)
2022-06-22 13:31:08 -06:00
Paul Davis
0d9656ef82
use new macros to cleanup #ifndef NDEBUG as much as possible (libs edition)
2022-06-22 13:31:08 -06:00
Paul Davis
0004ca2c41
add useful DEBUG_RESULT and DEBUG_RESULT_CAST to pbd/debug.h
2022-06-22 13:31:08 -06:00
Paul Davis
d917d7b351
fix actual x_assert macro definition
2022-06-22 13:31:08 -06:00
Paul Davis
df641765ec
add new header for x_assert() macro
2022-06-22 13:31:08 -06:00
Paul Davis
4599b07217
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
046cdf1295
fix unused variable warning by removing it.
2022-06-22 13:31:08 -06:00
Paul Davis
41948821e2
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
ebb9d3d4dc
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
26d2c8a7fa
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
bb5798ee66
fix may-be-used-unset warning and bizarre brace/indent style
2022-06-22 13:31:08 -06:00
Paul Davis
6fd4c01fc9
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
4878c48386
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
7a32ff33d4
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
f7b91d577b
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
9922daf284
handle compiler stupidity with early return
2022-06-22 13:31:08 -06:00
Paul Davis
24f1a65d5f
use C style cast in C code, rather than C++ constructor
2022-06-22 13:31:08 -06:00
Paul Davis
48a109e8c8
fix snprintf buffer size warning
2022-06-22 13:31:08 -06:00
Paul Davis
660d2fc8ab
fix strncpy() size argument error (Windows only, needs review)
2022-06-22 13:31:08 -06:00
Paul Davis
9b80d6558a
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
ad8e1c1cfd
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
45403dd2f1
fix may-be-used-unset warning
2022-06-22 13:31:08 -06:00
Paul Davis
b30ac5e221
replace unnecessary assert(0) with return;
2022-06-22 13:31:08 -06:00
Paul Davis
4ee854e7df
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
123cc92fff
fix may-be-used-unset warning
2022-06-22 13:31:08 -06:00
Paul Davis
7436a110dc
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
ecefe29d5e
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
6fdd745dc5
fix may-be-used-unset warning
2022-06-22 13:31:08 -06:00
Paul Davis
311e36b28f
fix optimized unused variable warnings
2022-06-22 13:31:08 -06:00
Paul Davis
168b540959
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
0e1f62e605
fix optimized build unused variable warnings and abort not assert
2022-06-22 13:31:08 -06:00
Paul Davis
f1a24fac98
fix optimized unused variable warning
2022-06-22 13:31:08 -06:00
Paul Davis
f78d384281
fix may-be-used-unset warning
2022-06-22 13:31:07 -06:00
Paul Davis
1e09e0f6fa
fix may-be-used-unset warnin
2022-06-22 13:31:07 -06:00
Paul Davis
ed645761d0
fix optimized unused variable warning
2022-06-22 13:31:07 -06:00
Paul Davis
4fd676aad5
fix optimized build buffer size/snprintf warning
2022-06-22 13:31:07 -06:00
