Commit graph

19608 commits

Author SHA1 Message Date
Robin Gareus
1f6abbb756
Comment-out unused timepos_t modulo operator which is not implemented 2022-06-30 01:47:42 +02:00
Robin Gareus
f67e731a7f
Prevent session-range changes to create invalid loop ranges
When a session-range coincides with a loop-range location, moving
the session-range also updates the loop-range.

Keeping session and loop-range in sync can be useful if the whole
session is looped. However markers are treated individually, so
we need prevent invalid ranges.

If session-start and loop-start coincide, but loop-end is before the
end-marker, it is possible to move session-start beyond the loop-end.
2022-06-30 01:07:32 +02:00
Robin Gareus
3bcf75a35a
Remove Range::squish debug information, used fixed modulo operation 2022-06-30 01:07:32 +02:00
Robin Gareus
2c1f36201c
Fix timecnt_t modulo operation when mixing time-domains 2022-06-30 01:07:32 +02:00
Robin Gareus
ca49bc00f0
Remove old "user" API, use consistent get/set_double() 2022-06-29 01:39:02 +02:00
Robin Gareus
3623b39168
Replace ::user_double() with ::get_double() 1/2 2022-06-29 01:39:02 +02:00
Robin Gareus
a4a241c738
Prepare replacing ::user_double() with ::get_double()
Automation Controls (and controls in general) are now
only updated in realtime context. Either via automation-playback,
or via SessioEvent. This directly sets the Control:_user_value
(before emitting the Changed signal).

The GUI does not need to evaluate the control at a given point
in time, so the API call can be removed and unified.

This commit first removes all calls to "get_double" to ensure
that no special cases exist.
2022-06-29 01:39:02 +02:00
Robin Gareus
5cb6e1046b
Fix automated controllable display value
::automation_run() evaluates the value, possibly ahead of time
depending on latency-compensation. The actual value is set in
realtime-context via set_value_unchecked() -> actually_set_value()
which emits the Changed signal.

At this point in time Control::user_value is already set correctly.
There is no need to evaluate and interpolate again, at a potentially
incorrect (uncompensated) time: `_session.transport_sample()`.

This fixes an issue with the GUI Automation control showing an
outdated value when there is an "immediate jump" in the signal:
eg. add a latent plugin post-fader, then automate the Fader to jump
from 0dB to -inf dB (snap to grid) and play though that transition.

(Plugin controls were not affected by this bug, the process
cycle is split for those, but Mixbus internal AC were affected).
2022-06-29 01:39:02 +02:00
Robin Gareus
7a01f3cbcd
Fix automated fader display value (use cycle-end value) 2022-06-29 01:39:01 +02:00
Robin Gareus
b0b7750bc7
NO-OP, use default argument 2022-06-29 01:38:55 +02:00
Robin Gareus
ee350362d3
Debug loop range squishing
When the loop-range is defined in BeatTime, the disk-reader encounters
rounding issues due to time-domain mismatches.

With a simple session fixed BPM at 120,  48kHz.
looping 1 bar exactly 2 sec at the start of the session:
```
 Range::squish start: b0 end: b7680 squish: a113554560
 Range::squish using modulo:       b45 = a661500
 Range::squish using modulo in TD: a5760
 Range::squish using earlier():    a658560
```
The correct answer is a113554560 - 2 * 56448000 [SC/sec] = a658560

Calculating the modulo iteratively is not great, however usually
only one iteration is required.
2022-06-28 03:01:41 +02:00
Paul Davis
873f78de78 NOOP: rearrange code DiskReader::get_midi_playback() to follow the "early exit for conditional" style guide 2022-06-25 13:36:55 -06:00
Robin Gareus
64f9829b56
AudioBackends: ignore setting latency of invalid port(s) 2022-06-24 19:55:17 +02:00
Robin Gareus
fe0e997335
Backend: prefer debug_msg over PBD::Transmitter in threads
PBD::Transmitter is neither thread-safe nor rt-safe. This likely
fixes a crash on macOS when process-threads are started.
Many threads simultaneously enter coreaudio_process_thread() and
log a message calling `PBD::info << .. << endmsg` simultaneously.
2022-06-24 19:27:57 +02:00
Robin Gareus
9ab32d7cb4
Fix builds on platforms without execinfo (amend cd4549aff7) 2022-06-23 01:59:58 +02:00
Paul Davis
5831ddd40b amend b30ac5e221 to actually replace the assert with a return 2022-06-22 16:09:38 -06:00
Paul Davis
0d9656ef82 use new macros to cleanup #ifndef NDEBUG as much as possible (libs edition) 2022-06-22 13:31:08 -06:00
Paul Davis
0004ca2c41 add useful DEBUG_RESULT and DEBUG_RESULT_CAST to pbd/debug.h 2022-06-22 13:31:08 -06:00
Paul Davis
d917d7b351 fix actual x_assert macro definition 2022-06-22 13:31:08 -06:00
Paul Davis
df641765ec add new header for x_assert() macro 2022-06-22 13:31:08 -06:00
Paul Davis
4599b07217 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
046cdf1295 fix unused variable warning by removing it. 2022-06-22 13:31:08 -06:00
Paul Davis
41948821e2 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
ebb9d3d4dc fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
26d2c8a7fa handle compiler stupidity with early return 2022-06-22 13:31:08 -06:00
Paul Davis
bb5798ee66 fix may-be-used-unset warning and bizarre brace/indent style 2022-06-22 13:31:08 -06:00
Paul Davis
6fd4c01fc9 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
4878c48386 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
7a32ff33d4 handle compiler stupidity with early return 2022-06-22 13:31:08 -06:00
Paul Davis
f7b91d577b handle compiler stupidity with early return 2022-06-22 13:31:08 -06:00
Paul Davis
9922daf284 handle compiler stupidity with early return 2022-06-22 13:31:08 -06:00
Paul Davis
24f1a65d5f use C style cast in C code, rather than C++ constructor 2022-06-22 13:31:08 -06:00
Paul Davis
48a109e8c8 fix snprintf buffer size warning 2022-06-22 13:31:08 -06:00
Paul Davis
660d2fc8ab fix strncpy() size argument error (Windows only, needs review) 2022-06-22 13:31:08 -06:00
Paul Davis
9b80d6558a fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
ad8e1c1cfd fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
45403dd2f1 fix may-be-used-unset warning 2022-06-22 13:31:08 -06:00
Paul Davis
b30ac5e221 replace unnecessary assert(0) with return; 2022-06-22 13:31:08 -06:00
Paul Davis
4ee854e7df fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
123cc92fff fix may-be-used-unset warning 2022-06-22 13:31:08 -06:00
Paul Davis
7436a110dc fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
ecefe29d5e fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
6fdd745dc5 fix may-be-used-unset warning 2022-06-22 13:31:08 -06:00
Paul Davis
311e36b28f fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
168b540959 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
0e1f62e605 fix optimized build unused variable warnings and abort not assert 2022-06-22 13:31:08 -06:00
Paul Davis
f1a24fac98 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
f78d384281 fix may-be-used-unset warning 2022-06-22 13:31:07 -06:00
Paul Davis
1e09e0f6fa fix may-be-used-unset warnin 2022-06-22 13:31:07 -06:00
Paul Davis
ed645761d0 fix optimized unused variable warning 2022-06-22 13:31:07 -06:00