Commit graph

40 commits

Author SHA1 Message Date
Paul Davis
a72bde5d3c add the final virtual GhostRegion method to VelocityGhostRegion 2024-10-17 07:44:31 -06:00
Paul Davis
a44e8ac088 fix drawing of lollipops.
There may be more virtual GhostRegion methods that VelocityGhostRegion has to proxy
to VelocityDisplay
2024-10-17 07:44:31 -06:00
Paul Davis
54fdf90cc2 lots of detailed fixes to get lollipops in tracks working again, post re-factor 2024-10-17 07:44:31 -06:00
Paul Davis
96e074d78c refactor velocity display so that it can be used in the editor and elsewhere 2024-10-17 07:44:31 -06:00
Robin Gareus
c4224b2a5a
Fix x-alignment of velocity lollis for Percussive Events 2024-08-08 21:35:46 +02:00
Paul Davis
9240b96bea reduce default size of lollis and make them scale with the UI scale factor 2023-11-04 12:27:55 -06:00
Paul Davis
4ea676b855 lollipops: try to make sure we use the right velocity when setting lolli heights (dragging vs. not dragging 2023-10-27 14:11:47 -06:00
Paul Davis
ef0938a16d more improvements to velocity drawing (including straight line) 2023-10-27 11:50:15 -06:00
Paul Davis
91fbb1c65b first steps towards improving straight line drags for velocity 2023-10-27 11:50:15 -06:00
Paul Davis
d88b9d36ca freehand draw for velocity only affects selected notes, if any are selected (#9491) 2023-10-18 08:26:42 -06:00
Paul Davis
f504eba0fe velocity regions should never be opaque, even when the region is selected 2023-09-29 08:49:40 -06:00
Paul Davis
c72a94250c update to aca5d7d988 to fix lollipop position
As noted in the commit message for that earlier commit, the radius
adjustment should not be required
2023-09-29 08:45:14 -06:00
Paul Davis
1f13b311fd midi display: ensure that lollipops are visible right after import
VelocityGhostRegion used the visibility of the "parent" note canvas item of a
lollipop canvas item to determine the lolli's visibility. But during the
construction of the MidiRegionView, the note's container is not yet visible, so
this fails.

In addition this logic would hide lollis for notes that are outside the current
visible note range of the track (because the parent note item was not visible).

This change adds a method to MidiRegionView to decide if a note is within the
region's time range, and if so, we show the lollipop item. This means that
lollis for notes outside the note-range will still be visible, which seems more
correct. In addition, the nascent condition of the parent note's container no
longer affects lolli visibility.
2023-09-24 18:38:20 -06:00
Paul Davis
c642611fe8 fix crash in ghostregions after adding notes but not invalidating optimization iter (#9452) 2023-09-21 16:26:59 -06:00
Paul Davis
aca5d7d988 place lollipops in correct location on timeline
It is not immediately clear to me why the + radius expression is reqired
2023-09-08 16:16:15 -06:00
Paul Davis
df52c39ce0 freehand line drawing: automation & velocity share the same basic code 2023-07-14 13:03:26 -06:00
Paul Davis
58a6fcfe37 lollis: note selection should move corresponding lolli to top 2023-06-27 14:07:31 -06:00
Paul Davis
e6b4d38e52 remove debug output 2023-06-27 09:21:56 -06:00
Paul Davis
1febe07480 lollis: use layering to enable editing of overlapping regions 2023-06-27 09:19:29 -06:00
Paul Davis
f7176b411e lollis: fix crash when a note is removed 2023-06-26 16:28:32 -06:00
Paul Davis
57fc25c28d lollis: tweak color of dragging line (still not sure about this) 2023-06-26 14:18:18 -06:00
Paul Davis
7dc532a646 lollis: only allow velocity editing on currently selected region 2023-06-26 14:18:18 -06:00
Paul Davis
6ef84ca376 increase transparency of velocity ghost regions 2023-06-26 14:18:18 -06:00
Paul Davis
296d0756a1 lollis: add left/right|earlier/later outlines to ghost region 2023-06-26 14:18:18 -06:00
Paul Davis
60256282e3 lollis: make a single drag be represented by a single Command object (for undo/redo) 2023-06-26 14:18:18 -06:00
Paul Davis
006779d4c3 lollis: better selection algorithm during drag, plus drawn line 2023-06-26 14:18:18 -06:00
Paul Davis
6ea7e8c8f4 improve button up/down tracking during velocity draw drag 2023-06-26 14:18:18 -06:00
Paul Davis
6d4bbae48c prototyping mouse-drag-paint velocity 2023-06-26 14:18:18 -06:00
Paul Davis
31de7e93bf lollis: show note selected status (using note selection outlien color) 2023-06-26 14:18:18 -06:00
Paul Davis
25bb43e285 lollis: color management during drag, and verbose cursor 2023-06-26 14:18:18 -06:00
Paul Davis
c75b9a11ef lollis: fix drawing and positioning glitches 2023-06-26 14:18:18 -06:00
Paul Davis
2d9a2ad668 lollis: also adjust velocity bars during the drag 2023-06-26 14:18:18 -06:00
Paul Davis
f7130f5c02 lollipop drag: move all selected notes 2023-06-26 14:18:18 -06:00
Paul Davis
cf7ba80fc1 the basics of lollipop dragging 2023-06-26 14:18:18 -06:00
Paul Davis
2a8f275174 sort of no-op: change variable name for slightly better legibility 2023-06-26 14:18:17 -06:00
Paul Davis
f7e97be115 canvas lollipops: object redesign and reimplementation 2023-06-26 14:18:17 -06:00
Paul Davis
7e4a3dce01 lollipop pixel pushing 2023-06-26 14:18:17 -06:00
Paul Davis
9089694e36 pops visible and somewhat responsive to note changes 2023-06-26 14:18:17 -06:00
Paul Davis
4bafadc419 steps to an ecology of lollipops 2023-06-26 14:18:17 -06:00
Paul Davis
52f10ad2a8 velocity views will be ghost regions 2023-06-26 14:18:17 -06:00