Commit graph

35990 commits

Author SHA1 Message Date
Paul Davis
b30ac5e221 replace unnecessary assert(0) with return; 2022-06-22 13:31:08 -06:00
Paul Davis
4ee854e7df fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
123cc92fff fix may-be-used-unset warning 2022-06-22 13:31:08 -06:00
Paul Davis
7436a110dc fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
ecefe29d5e fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
6fdd745dc5 fix may-be-used-unset warning 2022-06-22 13:31:08 -06:00
Paul Davis
311e36b28f fix optimized unused variable warnings 2022-06-22 13:31:08 -06:00
Paul Davis
168b540959 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
0e1f62e605 fix optimized build unused variable warnings and abort not assert 2022-06-22 13:31:08 -06:00
Paul Davis
f1a24fac98 fix optimized unused variable warning 2022-06-22 13:31:08 -06:00
Paul Davis
f78d384281 fix may-be-used-unset warning 2022-06-22 13:31:07 -06:00
Paul Davis
1e09e0f6fa fix may-be-used-unset warnin 2022-06-22 13:31:07 -06:00
Paul Davis
ed645761d0 fix optimized unused variable warning 2022-06-22 13:31:07 -06:00
Paul Davis
4fd676aad5 fix optimized build buffer size/snprintf warning 2022-06-22 13:31:07 -06:00
Paul Davis
a78fbf919d fix optimized unused variable warning 2022-06-22 13:31:07 -06:00
Paul Davis
fc1a0140a3 fix may-be-used-unset warning 2022-06-22 13:31:07 -06:00
Paul Davis
5a0767bd7b fix may-be-used-unset warning 2022-06-22 13:31:07 -06:00
Ben Loftis
94ca42cbea lua mixer_reset: fix copy+paste thinko so it actually works 2022-06-22 14:19:40 -05:00
Paul Davis
02b77ca88a better fix for CURL debugging unused variable warning 2022-06-21 17:36:26 -06:00
Paul Davis
ae9c11fb01 fix redefined CANVAS_DEBUG warning 2022-06-21 17:35:01 -06:00
Paul Davis
670b1fe3e2 fix initialization order warning 2022-06-21 17:34:48 -06:00
Paul Davis
ac18b84351 remove always-true-condition from if() to avoid compiler warning 2022-06-21 17:34:09 -06:00
Paul Davis
b51c4b7ef9 fix signed/unsigned warning 2022-06-21 17:33:37 -06:00
Paul Davis
181f40a349 fix signed/unsigned warning 2022-06-21 17:33:22 -06:00
Paul Davis
83b5fdf569 fix unused code warning 2022-06-21 17:33:04 -06:00
Paul Davis
e1f9d28d6a fix unused code warning 2022-06-21 17:32:50 -06:00
Paul Davis
48ab542ffa fix signed/unsigned warning 2022-06-21 17:32:27 -06:00
Paul Davis
5bc7c26d9b fix unused variable errors 2022-06-21 17:32:09 -06:00
Paul Davis
cd4549aff7 fix signed/unsigned warning 2022-06-21 17:31:50 -06:00
Paul Davis
dc4235efbe fix left-shift of negative value warning 2022-06-21 17:31:17 -06:00
Paul Davis
e2ef135161 remove unused warning 2022-06-21 17:30:59 -06:00
Paul Davis
4b11b2ba28 remove unused item 2022-06-21 16:55:29 -06:00
Paul Davis
d47b581cbb remove RegionRippleDrag
This used to be a distinct kind of drag, but ended up being refactored into
something that happens during a regular drag. Has not been used in quite some time.
2022-06-21 15:52:16 -06:00
Paul Davis
f679da4e1e simplify implementation of Beats::operator%= (Beats) 2022-06-21 14:46:20 -06:00
Paul Davis
5d81535588 remember to use muldiv() when doing a*b/c; also no need to call to_ticks(), just use _ticks 2022-06-21 14:46:20 -06:00
Paul Davis
1be136adbd allow construction of Beats with a beat count that exceeds INT32_MAX 2022-06-21 14:46:20 -06:00
Paul Davis
d6d9792dcb fix construction of Beats from an int64_t that exceeds INT32_MAX 2022-06-21 14:46:20 -06:00
Robin Gareus
71ee12af6a
Add API to format keyboard modifiers for tooltips 2022-06-21 22:11:49 +02:00
Robin Gareus
5b03bf72fa
NO-OP: code style 2022-06-21 22:11:08 +02:00
Robin Gareus
af38528174
Physical modifier abstraction is constant 2022-06-21 22:09:54 +02:00
Robin Gareus
9ae9282547
Use abstract group_override_modifier instead of hardcoded modifiers 2022-06-21 21:38:41 +02:00
Robin Gareus
8a5fc65df4
Expose newly added semantic modifiers 2022-06-21 21:38:37 +02:00
Robin Gareus
3266b1acb0
Add API to query currently held modifiers keys 2022-06-21 21:37:14 +02:00
Robin Gareus
f1eb45e129
NO-OP: clang format 2022-06-21 21:37:08 +02:00
Paul Davis
696e05c3e5 convert internal implementation of Temporal::Beats to just use a 64 bit tick value
This expands significantly the maximum number of Beats that can be represented, which is a good
thing in itself. It slightly speeds up some Beats::operator methods, and slightly slows down
::get_beats() and ::get_ticks().

One minor change in an API user was required, and several tweaks to the unit tests due to the
macros being used by cppunit creating possible type confusion.

Units test pass
2022-06-21 12:26:54 -06:00
Robin Gareus
4661957091
Re-establish 47932fb7bf (which was lost in e557245bf7) 2022-06-21 20:17:01 +02:00
Ben Loftis
0cc9f87baf continued work on modifier semantics (gtk part)
more implementations of group_override_event() and momentary_push_event()
2022-06-21 13:01:30 -05:00
Ben Loftis
e557245bf7 implement group_override_modifier() (lib part)
Consistently use Tertiary for Group Override on all platforms (and be consistent about it)

Consistently use Primary-mod for Momentary on all platforms (partially reverts 47932f)
Primary modifier is used for fine-adjust on knobs and sliders, with no analogous operation on switches.
2022-06-21 13:01:30 -05:00
Paul Davis
4dbdaf7fe9 fix possible negative return from TempoPoint::quarters_at_superclock() 2022-06-21 11:39:10 -06:00
Robin Gareus
47932fb7bf
Only special case middle-click modifier for macOS by default 2022-06-20 23:30:45 +02:00