Paul Davis
7fca55eeb5
Fix placement of drawn MIDI notes.
...
Important logic from 6.9 was either missing or incorrectly implemented. New
version is much simpler - we just use the RoundDownMaybe mode of round_to_bbt()
to ensure that the note start is always within the current grid even if the
mouse is more than halfway "through" it.
2021-11-04 18:27:02 -06:00
Paul Davis
248d7e5980
prevent trim-dragging that doesn't change region duration from incorrectly resetting fades
2021-10-05 10:43:24 -06:00
Paul Davis
8bdb8f51fd
remove debug output
2021-10-04 17:47:55 -06:00
Paul Davis
7d0c67e376
Revert "A small experiment to try '#pragma GCC warning'"
...
This reverts commit 808bfe0916
2021-10-03 09:10:14 -06:00
John Emmas
808bfe0916
A small experiment to try '#pragma GCC warning'
...
MSVC is happy to ignore the above pragma although it aborts the build if it encounters #warning
#pragma GCC warning seems to work fine here for Clang - so start by changing just 1 x file to see if there's any detrimental effect for the other builds.
2021-10-03 13:29:07 +01:00
Paul Davis
754230921d
there is no Properties::position any more (GUI)
...
Position is a part of a length property (a duple specifying
"duration AT position", and there is no distinct property
for just the position itself
2021-09-25 16:49:51 -06:00
Paul Davis
66595ae60e
a more correct fix (partial reversion) for Drag::adjusted_time()
2021-09-25 16:49:51 -06:00
Paul Davis
3a1d8c48df
Fix implementation of Drag::adjusted_time() to behave like the pre-nutempo version
2021-09-24 15:46:11 -06:00
Paul Davis
139a051b18
remove default args to Session::new_midi_track() (gui edition)
2021-08-13 12:51:36 -06:00
Paul Davis
b6f290add2
timeline type changes for new ripple code and post-conflict-resolution fixups
2021-08-13 12:51:36 -06:00
Paul Davis
bf50d27b68
fix timeline type use
2021-08-13 12:51:36 -06:00
Paul Davis
f755174c5f
fix timeline type use
2021-08-13 12:51:36 -06:00
Paul Davis
757acf381e
fix typo/thinko with const "division" value
2021-08-13 12:51:36 -06:00
Paul Davis
c6370948c4
fix call to RegionMotionDrag constructor
2021-08-13 12:51:36 -06:00
Paul Davis
40c9b1482a
region move drag now requires named argument
2021-08-13 12:51:36 -06:00
Paul Davis
6a71f9988e
fix timeline type use in brush dragging
2021-08-13 12:51:36 -06:00
Paul Davis
90264e1d0d
fix timeline type use
2021-08-13 12:51:36 -06:00
Paul Davis
88bed837c0
fix deadlock during tempo marker dragging, and don't start a tempo map update if a tempo point is inactive
2021-08-13 12:51:35 -06:00
Paul Davis
f05b2ed93b
remove another NUTEMPO #warning by allow grab starts in rubber band selection to use the default time domain
2021-08-13 12:51:35 -06:00
Paul Davis
7244b03385
convert NoteCreateDrag::grid_aligned_beats() into a proxy for Editor::snap_to_bbt()
2021-08-13 12:51:35 -06:00
Paul Davis
0ddfd7c873
force drag-created regions to use beat time for position
2021-08-13 12:51:34 -06:00
Paul Davis
49424ab0e3
Region::_start should be a timepos_t not a timecnt_t (GUI edition)
2021-08-13 12:51:34 -06:00
Paul Davis
dad56af802
remove another 3 NUTEMPO #warnings
...
These all involve converting between ControlList-relative time and absolute time
2021-08-13 12:51:34 -06:00
Paul Davis
0162d3f9d6
GUI changes to *try* to adapt to a world without explicit beats<->samples converter objects (i.e. use AutomationLine::get_origin() instead
2021-08-13 12:51:34 -06:00
Paul Davis
6536655a0a
add explanatory comment
2021-08-13 12:51:34 -06:00
Paul Davis
21e6f1cf50
(mostly) fix note drag creation drawing
2021-08-13 12:51:34 -06:00
Paul Davis
b66b98ce58
remove 2 more NUTEMPO warnings by use Editor::default_time_domain() appropriately (but perhaps without enough user control)
2021-08-13 12:51:34 -06:00
Paul Davis
39f52cd3ce
remove unused and unnecessary Drag::snap_delta_music() code
2021-08-13 12:51:34 -06:00
Paul Davis
cb66ae496c
don't even pretend to use non-modal dialog API for the BBT marker dialog
2021-08-13 12:51:34 -06:00
Paul Davis
d4f52498fa
somewhat working dialog for BBT/Position marker creation
2021-08-13 12:51:34 -06:00
Paul Davis
4911779157
manual fixups after a rebase against master
2021-08-13 12:51:34 -06:00
Paul Davis
432fbe984a
make "add BBT marker" test case use 3|1|0 for better testing
2021-08-13 12:51:34 -06:00
Paul Davis
2445081dcc
remove another NUTEMPO #warning - this one was just unnecessary concern
2021-08-13 12:51:34 -06:00
Paul Davis
0f67dbf8cc
remove another NUTEMPO #warning - use time domain of region's track for content trim dragging
2021-08-13 12:51:34 -06:00
Paul Davis
18fba5dece
whitespace adjustments
2021-08-13 12:51:33 -06:00
Paul Davis
fe352311f6
make shift-leftclick on bbt ruler set that time to be 3|2|0 (experiment - GUI dialog to follow)
2021-08-13 12:51:33 -06:00
Paul Davis
c22c8ed69f
get TempoMarkerDrag and BBTRulerDrag to compile
2021-08-13 12:51:33 -06:00
Paul Davis
c5c14e2416
remove two nutempo #warnings - initialize timecnt_t() using timedomain of route with first selected region (ripple dragging)
2021-08-13 12:51:33 -06:00
Paul Davis
0114059c9d
nutempo warning removal
2021-08-13 12:51:33 -06:00
Paul Davis
125c20e148
manual fixups for recent rebase conflicts left in the wrong state (GUI edition)
2021-08-13 12:51:33 -06:00
Paul Davis
42c74932a5
fixes/improvements for meter marker drags
2021-08-13 12:51:32 -06:00
Paul Davis
b0725a8ab9
use new TempoMap::abort_update() API when drag does not end in map update
2021-08-13 12:51:32 -06:00
Paul Davis
eaedcd79d4
fix a bunch of undo-able tempo map operations to use RCU
2021-08-13 12:51:32 -06:00
Paul Davis
06f93e65b2
fix timefx to use ratio_t from the beginning of the operation
2021-08-13 12:51:32 -06:00
Paul Davis
dee71c0a97
mostly fix region- and note-create drags
2021-08-13 12:51:32 -06:00
Paul Davis
fa759d3507
fix direction for trim drags
2021-08-13 12:51:31 -06:00
Paul Davis
9412130c01
use cleaned up Temporal ::quarters*_at* API (GUI edition)
2021-08-13 12:51:31 -06:00
Paul Davis
0093ae07b0
cleanup after timecnt_t API changed (GUI edition)
2021-08-13 12:51:31 -06:00
Paul Davis
cce695d33a
changes required by fixing ambiguities in timepos_t/timecnt_t API (GUI edition)
2021-08-13 12:51:31 -06:00
Paul Davis
18d64f0402
change all Region::nt_*() methods to names without the nt_ prefix (GUI version)
2021-08-13 12:51:30 -06:00
