Paul Davis
cb83d11681
triggerbox: add new trigger state enum to enums.cc
2022-01-10 14:02:38 -07:00
Paul Davis
dbb816b1f9
triggerbox: add "final sample" concept to start dealing with post-data playout
2022-01-10 14:02:38 -07:00
Paul Davis
1afc0ce69c
triggerbox: add follow length property to triggers (not used yet)
2022-01-10 14:02:33 -07:00
Robin Gareus
2342caae46
Push a few more nutempo DnD warning macros
2022-01-10 21:48:11 +01:00
Robin Gareus
fa7e7a462c
Work-around/Fix DnD from sidebar to editor-canvas
...
Editor::drop_regions() creates a new RegionInsertDrag()
with the region to drop to the timeline.
RegionInsertDrag is-a RegionMotionDrag is-a RegionDrag is-a Drag.
However the region does not yet exist on the timeline and
RegionView is NULL.
This will likely need an API change. e.g.
Directly pass the TimeDomain as argument. The information can
be provided by the region, or from the TimeAxisView or RouteUI
when dropping a new source/region.
2022-01-10 21:36:17 +01:00
Robin Gareus
056189c76c
Clean up DnD, use MIME-types
...
This is in preparation for allowing to drag trigger-regions
or trigger-slots. Those will not use a static singleton
PublicEditor API.
Additionally this constrains Ardour-internal drags to Ardour
(via Gtk::TARGET_SAME_APP).
2022-01-10 21:29:29 +01:00
Robin Gareus
1078dc7eda
DnD-TV: Allow to specify TargetFlags
2022-01-10 20:40:46 +01:00
Robin Gareus
af69061644
Do not create clang-db when cross-compiling w/mingw
...
This breaks windows builds, since apparently build(bld) is
evaluated twice (once to write compile_commands.json and once
to compile), even though `obj` is reset.
eg. in libs/pbd/wscript
```
if bld.env['build_target'] == 'mingw':
obj.source += [ 'windows_special_dirs.cc' ]
```
results in
[ 65/1159] Compiling libs/pbd/windows_special_dirs.cc
[ 69/1159] Compiling libs/pbd/windows_special_dirs.cc
which then produces an error when linking:
```
/usr/bin/x86_64-w64-mingw32-ld: libs/pbd/windows_special_dirs.cc.2.o:libs/pbd/windows_special_dirs.cc:28: multiple definition of `PBD::get_win_special_folder_path[abi:cxx11](int)'; libs/pbd/windows_special_dirs.cc.2.o:libs/pbd/windows_special_dirs.cc:28: first defined here
```
2022-01-10 17:10:49 +01:00
Robin Gareus
16511974e2
Fix class/struct mismatch C++ ABI [-Wmismatched-tags]
2022-01-10 00:06:24 +01:00
Robin Gareus
30539716ca
Fix various Wcast-qual
...
g_atomic_int_get() requires a non-const pointer, however
many APIs are declared virtual const, so const_cast<> is
preferred over an API change.
2022-01-10 00:06:20 +01:00
Robin Gareus
2139b0391c
Update waf binary, using doc/updating_waf.txt
2022-01-09 18:46:24 +01:00
Remi Thebault
b8e1cd53ce
Prepare waf update to 2.0.23 and enable 'clang_compilation_database'
...
This enables the generation of build/compile_commands.json
which is a compilation database recognized by some IDE/editors
to provide compiler quality linting.
To name a few:
- Visual Studio Code
- VIM (with ALE plugin)
2022-01-09 18:45:50 +01:00
Ben Loftis
4f5779e67d
trigger_ui: allow grabbing() for Gate + Repeat (TODO: Repeat is borked)
2022-01-08 09:33:20 -06:00
Ben Loftis
a44ce7c075
trigger_ui: recover quantization:None menu entries
2022-01-07 18:06:31 -06:00
Ben Loftis
770ee07910
trigger_ui: use quantize_length_to_string() consistently
2022-01-07 18:05:38 -06:00
Ben Loftis
4146177da3
triggerbox: when asked to stop by the user, clips should extend to the next bar boundary (and no further)
2022-01-07 16:05:07 -06:00
Ben Loftis
8548626adf
triggerbox: Add n-bar quantizations (GUI part)
2022-01-07 16:05:07 -06:00
Ben Loftis
c157490311
triggerbox: fix N-bar quantization: bars are 1-based
2022-01-07 16:05:07 -06:00
Ben Loftis
4e5f171fe2
triggerbox: the default quantization for a clip should be 'bars'
2022-01-07 16:05:01 -06:00
John Emmas
6750c9b049
Disambiguate a pointer to CheckMenuItem
...
Windows itself offers its own version of CheckMenuItem
2022-01-07 10:34:11 +00:00
John Emmas
031dce4ba4
Minor fix to commit # 45df39bd0e from yesterday
...
class 'AutomatableSequence' was trying to access a member that's private to its base class
2022-01-07 10:29:31 +00:00
Ben Loftis
78b39284d8
triggerbox: workaround for midi import crash. TODO: investigate root cause
2022-01-06 21:17:54 -06:00
Ben Loftis
32880e0cdd
locations pane: hide CD checkbox for Cue Markers
2022-01-06 21:17:54 -06:00
Ben Loftis
e9081b0b7c
trigger_ui: re-add the ability to pick several clips at once
2022-01-06 21:17:53 -06:00
Paul Davis
2f9b84fd48
triggerbox: resolve MIDI notes whenever a MIDI cue is stopped
2022-01-06 16:50:55 -07:00
Paul Davis
2755847294
triggerbox UI: fix crash caused by uninitialized member variable
2022-01-06 16:50:26 -07:00
Paul Davis
caba23ff4f
remove misleading/out-of-date instructions in comment
2022-01-06 14:22:07 -07:00
Paul Davis
b909c07a2d
triggerbox: fix failure of triggers to end at the right time when something happens to stop them early
...
nframes needed to be reduced to reflect the expected transition time. This change also consolidates any adjustment to
nframes and dest_offset for "starts within the interval" cases.
2022-01-06 13:48:23 -07:00
Paul Davis
436b81be9a
NOOP: change code pattern to return early from conditional rather than leaving body inside true condition scope
2022-01-06 12:07:22 -07:00
Paul Davis
0baf0d859d
GUI side of cue behavior (makes it available in the ruler context menu)
2022-01-06 12:00:18 -07:00
Paul Davis
8bf494e5a8
change nature of CueBehavior enum to be bitwise
...
This allows us to OR-in the ImplicitlyIgnoreCues bits, and still toggle
FollowCues on and off to indicate user-requested behavior
2022-01-06 11:59:58 -07:00
Paul Davis
44d52133ae
triggerbox: ignore cue-marker cues if told to do so
2022-01-06 11:23:02 -07:00
Paul Davis
85b8816287
NOOP: remove spurious character in comment
2022-01-06 11:12:49 -07:00
Paul Davis
4e482076ea
add config param to control response to cue markers
2022-01-06 11:10:28 -07:00
Paul Davis
45df39bd0e
fix mysterious incorrect copy constructor call for AutomatableSequence
...
msvc calls this out, but gcc/clang do not. It is not clear why, and it might be worth understanding why
2022-01-06 10:36:50 -07:00
Paul Davis
a1c627aa24
triggerbox: minor changes after change in how timeline cues are implemented
2022-01-06 00:23:49 -07:00
Paul Davis
a187b5e1fb
triggerbox: reimplement timeline cues without session events
2022-01-06 00:23:27 -07:00
Paul Davis
7c35783d63
various fixes for cue marker creation, dragging, naming
2022-01-05 13:27:47 -07:00
Paul Davis
fd2f2f46cc
triggerbox: implement cue-triggering session event handling (sync with location markers)
...
Still requires handling tempo changes
2022-01-05 13:27:47 -07:00
Paul Davis
f1a81b303a
add several newer enums to libs/ardour/enums.cc
2022-01-05 13:27:47 -07:00
Paul Davis
acdc1cd707
extend/adjust Location API to handle cue markers
2022-01-05 13:27:47 -07:00
Paul Davis
93b30976e5
cue events: some basic handling framework for syncing cue markers with session events that implement them
...
This doesn't actually do anything yet
2022-01-05 13:27:47 -07:00
Paul Davis
5783664b9e
locations: provide Location::cue_change signal to notify about cue marker changes
2022-01-05 13:27:47 -07:00
Paul Davis
73ca08933d
fix default naming of cue markers
2022-01-05 13:27:47 -07:00
Paul Davis
54aa57a297
fix naming of unnamed cue locations
2022-01-05 13:27:47 -07:00
Paul Davis
1d2fa465d3
remove mistaken handling of cue marker bar events
2022-01-05 13:27:47 -07:00
Ben Loftis
7e65097ded
trigger_ui: corner button has menu to set ALL clips in the grid
...
...likely only useful for troubleshooting+development ... tbd
2022-01-04 16:45:11 -06:00
Ben Loftis
fdd92c82fb
trigger_ui: implement icons for new launch-styles and follow-actions
2022-01-04 16:45:11 -06:00
Paul Davis
8a49d274fb
fix luabindings for Editor.mouse_add_new_marker(), since API changed
2022-01-04 15:23:51 -07:00
Paul Davis
b1f73d25bf
actual GUI interaction for cue marker ruler
2022-01-04 15:23:51 -07:00