Commit graph

7664 commits

Author SHA1 Message Date
Paul Davis
76d42ab644 change SessionEvent::Immediate to -1, and ensure that clear_events() uses it rather than a hard-coded value
This fixes a design error of using zero as the flag for an "Immediate" event's action frame. Zero
is a perfectly legitimate action frame for an event (e.g. a Skip event), and using zero was causing
skip events with action-frame == 0 to be treated as immediate, not scheduled.
2014-12-21 11:45:53 -05:00
Tim Mayberry
dafcaec023 Limit Wiimote surface discovery to 5 connection attempts
If you don't connect a Wiimote then the connection attempts were
endless.
2014-12-21 12:53:00 +07:00
Paul Davis
282c563fce fix newly introduced deadlock when cloning MIDI regions 2014-12-20 14:09:39 -05:00
David Robillard
5d8021bf44 Maintain correct tracker state on MIDI overwrite.
This is a little hard-edged in that edits while rolling will prematurely chop
off any playing notes, but at least the state of things actually reflects
reality.  More sophisticated solution hopefully to come...
2014-12-20 01:13:25 -05:00
Colin Fletcher
db92d62c95 Revert "Change default for region selection after split on Mixbus"
This shouldn't be necessary: Mixbus should probably just have a different
value for the default in their source tree instead.

This (partially) reverts commit 631467f0bb:
I now realise that I accidentally rolled another fix (missing "region-" in
config variable name) in there too: sorry about that.
2014-12-19 21:16:02 +00:00
Colin Fletcher
631467f0bb Change default for region selection after split on Mixbus
Mixbus prefers that both the newly-created regions as well as the existing
selection are selected after splitting selected regions: make this the
default on Mixbus.
2014-12-19 17:12:05 +00:00
Colin Fletcher
d4a3141927 Add a config option to control region selection after split.
Add a configuration variable to choose the behaviour of the region
selection after splitting selected regions.

Add options to choose between all eight possible combinations of 'existing
unmodified selected regions', 'newly-created regions to left of split',
and 'newly-created regions to right of split', but comment out all but the
three least crazy ones for now. If anyone wants them, they're there.
2014-12-19 17:12:04 +00:00
Paul Davis
a494211e73 add ArdourCanvas::change_alpha()
Time to move away from rgba macros
2014-12-19 09:53:26 -05:00
Valeriy Kamyshniy
1b89055526 [Summary] Bug fix: mistakenly set states of freewheeling thread. 2014-12-18 17:07:37 -05:00
Paul Davis
74be550698 change Item::visible() to Item::self_visible(); add Item::visible() which returns accurate visibility
Child items will be hidden when their ancestors are hidden. The old ::visible() implementation didn't reflect this. In addition,
when changes are made to hidden items (new definition of visible/not visible), don't bother to request redraws, since this will
be done when the item becomes visible again.
2014-12-18 10:30:38 -05:00
David Robillard
7eab4c6f33 Don't assume compiler can avoid copy to const ref. 2014-12-18 04:03:39 -05:00
David Robillard
e584ae0bf9 Mute automation via normal mute button. 2014-12-18 02:26:51 -05:00
David Robillard
64490e88e4 No need to yell. 2014-12-18 02:26:34 -05:00
David Robillard
0f759e9a93 MIDI bounce. 2014-12-17 21:48:09 -05:00
David Robillard
d2cafbe95a Remove some aborts that don't really need to be.
Enforce PatchPrimaryKey sanity at the type level rather than attempting to
check for it everywhere.

Remove dead file.
2014-12-17 19:43:09 -05:00
David Robillard
a706755710 Fix various MIDI locking issues.
Attempt to make mistakes much less likely in the future by statically requiring
caller to pass scoped locks where necessary.
2014-12-17 16:07:29 -05:00
David Robillard
ec6626f06a Fix oops in previous commit.
Professionalism is overrated.
2014-12-17 02:10:01 -05:00
David Robillard
0c3f4bd995 Fix occasional crash when recording MIDI. 2014-12-17 01:49:46 -05:00
Paul Davis
12803c4255 use new parameter to limit minimum length of any range location 2014-12-16 13:06:13 -05:00
Paul Davis
94e2b61a86 add new parameter for minimum value of any range location 2014-12-16 13:06:05 -05:00
Paul Davis
0fdb846625 try alternate Glib:: API for conversion from UTF-8 to ascii in Mackie support code 2014-12-15 15:06:10 -05:00
Paul Davis
e3f376107e nominal fix for sending UTF-8 text to Mackie surface 2014-12-15 14:44:05 -05:00
Paul Davis
9831006c8e add getters for SVAModifier 2014-12-15 12:06:53 -05:00
Paul Davis
995bcd3aa0 fix typo 2014-12-15 09:29:04 -05:00
Paul Davis
aa57e9e032 more fixes to SVAModifier constructor(s) 2014-12-15 09:03:52 -05:00
John Emmas
9a454ab3d4 Add a newly introduced header file to our MSVC project (libpbd) 2014-12-15 10:26:06 +00:00
Paul Davis
3fa4063d9b fix up SVAModifier constructors 2014-12-14 23:41:31 -05:00
Paul Davis
427b93055f add SVAModifier to ArdourCanvas color code 2014-12-14 23:34:36 -05:00
Paul Davis
0fa5643d20 move ScopedFileDescriptor into libpbd and use it 2014-12-14 12:26:00 -05:00
John Emmas
1b3fb142f0 Only attempt to close our peakfile '_fd' if we have a valid handle
(yesterday's fix was needed in a 2nd place)
2014-12-14 10:39:29 +00:00
John Emmas
90010d098f Only attempt to close '_peakfile_fd' if we have a valid handle 2014-12-13 12:46:24 +00:00
David Robillard
ee38c44109 Structure MIDI device selector by manufacturer.
Unfortunately we store the state of models as simply model, so if there's ever
duplicate model names, we're somewhat screwed, but this makes the (previously
unmanageably huge) menu usable, while retaining the "model name as global
identifier" state unmodified.
2014-12-13 00:37:34 -05:00
John Emmas
ec0a74276a Remove (no longer needed) sources from our MSVC project (libpbd) 2014-12-12 09:08:16 +00:00
Paul Davis
050d46a33e Merge branch 'nofilemanager' 2014-12-10 18:29:41 -05:00
Paul Davis
a4273ee224 Revert "fix some cast warnings"
This reverts commit 17707b9674.
2014-12-10 18:29:00 -05:00
Paul Davis
294b99aabf remove file manager LRU cache from code.
This was a very clever attempt to fix a non-problem. If the platform doesn't have enough file descriptors available
then the platform is broken and we're not going to hack around trying to fix it.
2014-12-10 18:28:55 -05:00
Paul Davis
a25d945c3e fix some cast warnings 2014-12-10 18:27:11 -05:00
Paul Davis
17707b9674 fix some cast warnings 2014-12-10 18:13:12 -05:00
Paul Davis
3e27a71c71 simpler approach for Apple setrlimit() compatibility issue 2014-12-10 15:59:11 -05:00
Paul Davis
b91c7836de try some alternate, hard numbers when resetting open file limits on OS X 2014-12-10 15:27:32 -05:00
Paul Davis
a0fcf2fc66 remove ugly and unnecessary debugging output 2014-12-10 13:37:03 -05:00
John Emmas
2f300085ea Use DEBUG_THREAD_SELF when using DEBUG_TRACE with pthread IDs
(supports both normal pthreads usage and PTW32)
2014-12-10 16:56:33 +00:00
Paul Davis
635578b30b use correct conditional to choose between different DEBUG_THREAD_SELF macros 2014-12-10 11:07:18 -05:00
Paul Davis
c06c15596b add DEBUG_THREAD_SELF to allow use of DEBUG_TRACE with thread IDs on both normal pthreads platforms and PTW32 2014-12-10 09:34:32 -05:00
Ben Loftis
e66752cec1 add set-session-extents-from-edit-range 2014-12-09 16:18:47 -06:00
Paul Davis
1e0c1751a5 more DEBUG::Butler output, formatting corrections, and a warning on cerr if capture/playback buffers are too full/empty 2014-12-09 16:36:52 -05:00
Robin Gareus
724febc82c remove superfluous PBD/ARDOUR:: init calls
this reverts 339670b
2014-12-09 19:41:53 +01:00
Paul Davis
8e44a0bff7 add DEBUG::Butler and use it 2014-12-09 10:18:29 -05:00
Paul Davis
246a4f3018 correct install location for .mo files (i18n) and cleanup LOCALEDIR use a bit 2014-12-09 08:19:11 -05:00
Paul Davis
624a86c39d lots more color work, closer and closer to being ready for ... being taken apart again 2014-12-08 22:02:38 -05:00