36519 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Robin Gareus	cb548ede3d	Safeguard plugin window deletion when closing the session ... ..otherwise it may happen that the idle-signal arrives after the window has already been destroyed.	2022-11-02 16:23:43 +01:00
Paul Davis	8857abc028	ensure that freesound token dialog is always on top (of similar windows)	2022-11-02 09:19:16 -06:00
Mads Kiilerich	ef5b29c6dd	PulseAudio: group operations and their verification together ... Improves readability a bit. IMO.	2022-11-02 02:24:35 +01:00
Mads Kiilerich	b046ffe395	PulseAudio: drop idempotent dynamic cast	2022-11-02 02:24:35 +01:00
Mads Kiilerich	5bb7336c79	PulseAudio: consistent use of _buffer ... For consistency and readability, avoid using high level getter in low level code.	2022-11-02 02:24:35 +01:00
Mads Kiilerich	51501e5532	PulseAudio: don't set _run = false when stop() already did it	2022-11-02 02:24:35 +01:00
Mads Kiilerich	ba5ca2de05	PulseAudio: always log error reason in error handling ... It adds some new strings to translate. These strings might be so rare and technical that it is a bit pointless to translate them. But let's stay consistent...	2022-11-02 02:24:35 +01:00
Mads Kiilerich	3fbbef3038	PulseAudio: fix "already active" message emitted when not active ... Apparently just a missing fixup after copy-paste.	2022-11-02 02:24:34 +01:00
Mads Kiilerich	2666dfe900	PulseAudio: add missing return in error handling ... Don't try to continue if the initial uncorking fails.	2022-11-02 02:24:34 +01:00
Mads Kiilerich	06b3d5ba33	PulseAudio: spin waiting for enough capacity to write ... pa_threaded_mainloop_wait might wake up for several reasons. And there is no point (but possibly harm) in moving on before we have verified that PA actually is ready to receive our write without overflow.	2022-11-02 02:24:34 +01:00
Mads Kiilerich	27a2bf1f59	PulseAudio: clean up freewheeling transitions ... ae3c8b19c6 and 03a17df68c reworked the transitions to and from freewheeling. Some of it seems to have been experiments that tried several things out, and generally it seems to have worked. It left some commented out code. Clean that up.	2022-11-02 02:24:34 +01:00
Mads Kiilerich	04c24be2db	PulseAudio: don't drain the stream right after initial uncorking ... The draining was introduced in ae3c8b19c6, apparently as an experiment doing several changes. But the drain is outside the loop where freewheeling changes, so the fix must have worked for other reasons. There doesn't seem to be any benefit from draining at that point. The stream is already empty. If not, we could have flushed it. Draining right after uncorking will conceptualy create an intentional underflow, even though it isn't reported as such. PipeWire seems to (something like 6-12 months ago) have regressed in handling of that grey area, causing that *underflow* to cause a request for too much data, and thus causing constant *overflows* and unusable playback. This change makes PulseAudio playback work for me again.	2022-11-02 02:24:34 +01:00
Robin Gareus	f47e517c86	Fix duplicate undo crash ... Double-clicking on a line in internal edit mode adds a new point in the line. In this case LineDrag need not manage automation events because the "add" functions already do. see AutomationTimeAxisView::add_automation_event and AudioRegionView::add_gain_point_event	2022-11-02 02:05:58 +01:00
Robin Gareus	c84073e5cf	Print reversible command debug output ... Debug builds will assert, the PBD::warning will not be readable anywhere after that, so long it to stderr.	2022-11-02 00:47:09 +01:00
Robin Gareus	292cff7cfc	Prevent undo transaction crashes in optimized builds ... Worst case this will lead to undo operations not being saved rather than segfault (debug builds will still assert).	2022-11-02 00:45:06 +01:00
Ben Loftis	32d2b371c1	TouchOSC: add Clip_Launcher.tosc and update TransportController.tosc	2022-11-01 14:04:02 -05:00
Ben Loftis	c6dade9484	OSC: implement controls and feedback for a banked trigger grid controller ... (first iteration ... API may change)	2022-11-01 13:52:54 -05:00
Ben Loftis	bdf9cedb0e	triggers: implement grid banking in BasicUI so it can be shared (?)	2022-11-01 13:52:54 -05:00
Ben Loftis	0851d230cd	basic_ui: add convenience functions to access an NxM bank of triggers	2022-11-01 13:52:54 -05:00
Ben Loftis	4f5106ae82	triggers: add convenience function to report # of trigger channels	2022-11-01 13:52:54 -05:00
Ben Loftis	756e0beb1b	triggers: more session:: functions to access Triggers by index	2022-11-01 13:52:54 -05:00
Ben Loftis	c23210aae8	various fixes to prevent BasicUI diverging from GUI behaviors	2022-11-01 13:52:54 -05:00
Ben Loftis	e74a412bcb	rename some operations slaves -> assigned channels	2022-11-01 13:52:54 -05:00
Robin Gareus	d9ebc8e09f	Scale plugin Analysis UI ... This also increases the default font size and adds a -15,+15 dB range mode.	2022-11-01 18:00:59 +01:00
Gon Solo	bb27b24596	Fix warning about integer division. ... bugprone-integer-division: Result of integer division used in a floating point context; possible loss of precision.	2022-11-01 15:56:55 +01:00
Paul Davis	c9fe383813	dbl click on mixer strip name label/color button brings up color picker	2022-11-01 08:12:05 -06:00
Paul Davis	6832ad2af9	use correct name for recording note color	2022-11-01 08:12:05 -06:00
Paul Davis	ac1d2122dd	add recording note color back to Xccolors theme	2022-11-01 08:12:05 -06:00
Robin Gareus	c9a9f40987	Add API for Lua DSP to directly set Biquad coefficients	2022-11-01 14:51:07 +01:00
Robin Gareus	e819af1948	Fix clearing automation ... Due to refactoring in d41e66f169 and 83ad0a10b5 Automation > Clear re-displayed the line on mouse-over, even if there are no events. Then trying to interact with he line caused segfaults because the actual control points no longer exist.	2022-11-01 00:51:53 +01:00
Paul Davis	910b637326	xoclors updates from LAM	2022-10-31 17:05:55 -06:00
Paul Davis	6d1e4207de	bbt ruler: no more micro/minor mark distinction. all bars are equal between labels	2022-10-31 17:05:55 -06:00
Paul Davis	62540fb5af	tempo map: grid generation, fix use of barmod to insert bar points into return	2022-10-31 17:05:55 -06:00
Paul Davis	0ef10e4f5f	canvas: ruler never shows marks/text for points too close to display the label	2022-10-31 17:05:55 -06:00
Robin Gareus	19ab75f5e5	Do not destroy Lua DSP GUIs (they are always generic UIs)	2022-10-31 22:47:30 +01:00
Robin Gareus	d425bfc3ff	Update Lua Biquad filter	2022-10-31 22:47:30 +01:00
Robin Gareus	5599e136c0	Implement "vicanek" matched biquad filters	2022-10-31 22:47:30 +01:00
Paul Davis	6e3d3706dc	MIDI region combine: fix conceptual errors (GUI edition)	2022-10-31 14:22:17 -06:00
Paul Davis	d93c8d64bc	MIDI region combine: fix conceptual errors	2022-10-31 14:22:17 -06:00
Paul Davis	f4a57f83e6	evoral: Sequence::clear() needs to remove patch changes and sysexes too	2022-10-31 14:22:17 -06:00
Robin Gareus	fded5063d9	Yet another automation time-domain fix ... This issue was fixed in 6a55146fd but resurfaced in 489c9ace9.	2022-10-31 16:23:20 +01:00
cooltehno	17457fcc02	Update blueberry_milk-ardour.colors	2022-10-30 23:44:11 -06:00
Paul Davis	9c2c08973d	tempo map: fix incorrect computation of ::bbt_at() (#9049) ... This caused problems with TempoMap::get_grid() ("gone backwards").	2022-10-30 19:35:58 -06:00
David Robillard	bdacfb8724	Fix invalid use of Doxygen "@param" command ... This is never for inline references to parameters, only for starting parameter documentation blocks. The "@p" command is for this, although unfortunately Doxygen doesn't actually do anything with it and it's just an alias for code text.	2022-10-30 20:44:28 -04:00
Robin Gareus	96bab3ce46	NO-OP: doxygenize timepos_t::distance	2022-10-31 00:22:21 +01:00
Paul Davis	21e8885e00	region duplication: fix positioning of multi-region duplicates	2022-10-30 17:07:22 -06:00
Robin Gareus	77f28aa6f9	Fix time calculation in edit-note dialog #9045	2022-10-30 16:02:44 +01:00
Paul Davis	1eaaf4303b	jack backend: catch some possible errors in ::get_port_name()	2022-10-29 09:37:17 -06:00
Paul Davis	e06bd481a1	fix color of MIDI notes during capture so that they are visible	2022-10-28 16:41:15 -06:00
Paul Davis	492073e47d	fix display of MIDI notes during recording ... Note that the notes are almost invisible due to coloring	2022-10-28 16:39:38 -06:00