Commit graph

40884 commits

Author SHA1 Message Date
Paul Davis
c5c865f589 fix potentially unset variable (thanks clang!) 2024-10-17 15:06:04 -06:00
Paul Davis
e74f57c52b get playhead functioning during clip recording (MIDI) 2024-10-17 14:36:27 -06:00
Paul Davis
7b88ae2466 fix initial LR sizing of midi cue editor canvas sections 2024-10-17 13:37:21 -06:00
Paul Davis
2ff90a0557 probably fix an assert() logic error 2024-10-17 11:27:57 -06:00
Paul Davis
05cb6197a6 return to file-conditional for pre-release dialog 2024-10-17 07:49:25 -06:00
Paul Davis
c2094085e3 sort of get MIDI notes to extend during clip recording
Also, robustify MidiView against a missing MidiModel member variable
2024-10-17 07:44:33 -06:00
Paul Davis
7608d4ade2 API changes for clip recording in TriggerBox
Also, disarm all triggers when track-level rec-enable is disabled
2024-10-17 07:44:33 -06:00
Paul Davis
774f5f49da robustify MidiView against the condition where it has no MidiRegion 2024-10-17 07:44:33 -06:00
Paul Davis
e390c2c3dd trigger page should respond to rec-enable changes 2024-10-17 07:44:33 -06:00
Paul Davis
a8f58105a9 provide a class-level static PBD::Signal for Trigger (Slot) arming 2024-10-17 07:44:33 -06:00
Paul Davis
6b1659497d add #warning 2024-10-17 07:44:33 -06:00
Paul Davis
9ad08fa9a5 add input,output,rec-enable buttosn to trigger strip
With clip recording starting to function, these things now matter on the cue page
2024-10-17 07:44:33 -06:00
Paul Davis
d7e85de7c2 first somewhat version of show-clip-capture MIDI notes as they arrive 2024-10-17 07:44:33 -06:00
Paul Davis
bd0b5495c6 robustify MidiView so that it can be created without a MidiTrack 2024-10-17 07:44:33 -06:00
Paul Davis
35f16f1bb6 preparations for clip data display (MIDI) while recording (GUI edition) 2024-10-17 07:44:33 -06:00
Paul Davis
7c944687c9 preparations for clip data display (MIDI) while recording 2024-10-17 07:44:33 -06:00
Paul Davis
c03c3dd918 fix unused variable warning from clang 2024-10-17 07:44:32 -06:00
Paul Davis
67c6a9dbf4 fix lambda warning (unused captured this) 2024-10-17 07:44:32 -06:00
Paul Davis
dab9775223 fix bitwise-vs-logic AND (thanks, clang!) 2024-10-17 07:44:32 -06:00
Paul Davis
c2deacdd54 fix definition of Trigger::playable()
The recent change to only use the data object breaks GUI handling
of a PropertyChange signal after _region is set following a drag
and drop
2024-10-17 07:44:32 -06:00
Paul Davis
62a4df52c7 tentative steps in infrastructure for displaying clip data during capture 2024-10-17 07:44:32 -06:00
Paul Davis
6193535a31 apply a fade in & out to captured audio clip data, before writing to disk
This policy may need revising later.
2024-10-17 07:44:32 -06:00
Paul Davis
87ab0a9e0f add config vars to control max size of captured MIDI and audio clips 2024-10-17 07:44:32 -06:00
Paul Davis
8305ea5762 during MIDI clip recording, convert audio->beat time at capture time
This distributes whatever cost there is associated with the domain conversion across
multiple process() calls, rather than doing it all in the process() call where
capture finishes.
2024-10-17 07:44:32 -06:00
Paul Davis
01068fe306 further adventures in drag-refactoring do that LineDrag can be used in MidiCueEditor also 2024-10-17 07:44:32 -06:00
Paul Davis
302337e8fd resurrect a slightly modified pre-release dialog in prep for merge with master 2024-10-17 07:44:32 -06:00
Paul Davis
dfe3c48d0f use button.y and modifier state when adding a control point in the midi cue automation lane 2024-10-17 07:44:32 -06:00
Paul Davis
2afdeb519f refactor rubberband drags to take a functor for the no-drag condition
Also move code for adding automation line control points into automation line, rather
than in AutomationTimeAxisView (some work still required to finalize this)
2024-10-17 07:44:32 -06:00
Paul Davis
e6c0fcf98f refactor end-of-rb-selection for EditingContext
Whhat the main editor and the cue editor do with a click varies significantly
2024-10-17 07:44:32 -06:00
Paul Davis
db30a7d040 fix sprintf overflow warning from clang on macOS 2024-10-17 07:44:32 -06:00
Paul Davis
f3d099f83f fix unused variable warning from clang on macOS 2024-10-17 07:44:32 -06:00
Paul Davis
dd6b2c8c7f fix several set-not-used warnings from clang on macOS 2024-10-17 07:44:32 -06:00
Paul Davis
cbc0021182 fix typo (| instead of ||) 2024-10-17 07:44:32 -06:00
Paul Davis
b8fb779fa7 allow dragging in MIDI automation line in cue editor
Note: once this is cleaned up and checked with respect to snap and more,
the same should be done for MidiRegionView
2024-10-17 07:44:32 -06:00
Paul Davis
4b8c51574d refactor the "selectables" API to allow use within separate (e.g. cue) editors 2024-10-17 07:44:32 -06:00
Paul Davis
83ea6e18b5 get MIDI cue editor mouse mode buttons to reflect state at startup 2024-10-17 07:44:32 -06:00
Paul Davis
b02a930c04 remove debug output 2024-10-17 07:44:32 -06:00
Paul Davis
1961a9207c provide a better method to decide if a trigger(slot) is occupied
This is necessary with clip recording because for some short time after recording,
a trigger may be playable despite not yet having a region.

GUI edition.
2024-10-17 07:44:32 -06:00
Paul Davis
1e8b2c521c provide a better method to decide if a trigger(slot) is occupied
This is necessary with clip recording because for some short time after recording,
a trigger may be playable despite not yet having a region.

libs edition.
2024-10-17 07:44:32 -06:00
Paul Davis
e089953e78 get blinking rec status closer to correct for clip recording 2024-10-17 07:44:32 -06:00
Paul Davis
596c54d742 fix ups for record state in TriggerBox 2024-10-17 07:44:32 -06:00
Paul Davis
1146a4ad07 move RecordState enum from ARDOUR::Session to ARDOUR so we can use it in TriggerBox (GUI) 2024-10-17 07:44:32 -06:00
Paul Davis
d7d208dc34 move RecordState enum from ARDOUR::Session to ARDOUR so we can use it in TriggerBox (libs) 2024-10-17 07:44:32 -06:00
Paul Davis
90858279bc tweak drawing of clip recording rec-enable icon 2024-10-17 07:44:32 -06:00
Paul Davis
6ef4a74728 cleanup of bits of clip recording code 2024-10-17 07:44:32 -06:00
Paul Davis
4466563a89 avoid double delete of clip recording audio buffers 2024-10-17 07:44:32 -06:00
Paul Davis
25400a4936 fix appending new audio data during clip recording 2024-10-17 07:44:32 -06:00
Paul Davis
7455b99b45 account for clip recording when computing monitoring state 2024-10-17 07:44:32 -06:00
Paul Davis
a357575954 less debugging 2024-10-17 07:44:32 -06:00
Paul Davis
1e193d0363 GUI side of clip recording (recording indicators etc.) 2024-10-17 07:44:32 -06:00