Commit graph

18433 commits

Author SHA1 Message Date
Ben Loftis
932b07b7b0 Playlist UI tweaks: assign a pgroup when a playist is first recorded to
* this solves the problem where the first 'take' was not grouped because
 the user has not explicitly created a take for the group yet
2021-06-01 09:39:50 -05:00
Ben Loftis
28aa22e11a Playlist UI tweaks: Add pgroup_id field to playlists, to associate playlists created in the same operation (libardour) 2021-06-01 09:39:50 -05:00
Ben Loftis
f6d2229c47 Playlist UI tweaks: Update PlaylistSelector (libardour part)
* Add an option to use a playlist without stealing its ownership. (libardour)
* Tracks emit PlaylistAdded when a new playlist is created either by copying or by creating a new empty pl
2021-06-01 09:15:54 -05:00
Ben Loftis
7b2854b2fb Prefer storing playlist-IDs for frozen tracks; but if none is provided then search by name
* no version-check should be necessary because when opening an old session,
 playlists can be looked-up by discrete names and will be tracked by ID thereafter
2021-06-01 09:14:07 -05:00
David Robillard
71a414b4b0 Remove unused function (Wunused-function) 2021-05-30 20:09:35 -04:00
David Robillard
8d471e6761 Remove extraneous parentheses (Wparentheses-equality) 2021-05-30 20:09:35 -04:00
David Robillard
74e21e942e Remove unused variables (Wunused-variable) 2021-05-30 20:09:35 -04:00
David Robillard
1b4aaea92a Remove unused private fields (Wunused-private-field) 2021-05-30 20:09:35 -04:00
Robin Gareus
c57c230dfc
Fix loading old session w/missing playlist #8727 2021-05-30 18:54:45 +02:00
Robin Gareus
df0571892f Coreaudio: fix duplicates in device list
This is an edge-case only, some devices may
dis and reconnect with different IDs.
2021-05-29 17:54:39 +02:00
Damien Zammit
bdb5aec1cc ptimport: Fix crash when imported session has zero audio tracks 2021-05-29 12:54:10 +10:00
Paul Davis
3d15b61e37 fix Playlist::remove_gaps() for ExternalOverlap regions; add per-gap callback 2021-05-28 17:43:33 -06:00
Paul Davis
c8c506f702 fix bug in Locations::ripple() 2021-05-28 17:43:33 -06:00
Paul Davis
9766132a53 libardour: add Locations::ripple() 2021-05-28 17:43:33 -06:00
Robin Gareus
37acb07752 Fix previous commit 2021-05-28 22:51:12 +02:00
Robin Gareus
0f25086446
Misc fixes pertaining to plugin-scanning 2021-05-28 22:03:10 +02:00
Robin Gareus
79b50aebcd
Ignore all export xruns while not rolling
This fixes false positives with some backends, notably JACK2.
2021-05-28 21:22:10 +02:00
Paul Davis
fecce7c333 libardour: initial implementation of Playlist::remove_gaps()
This is probably a little naive and may need extending to cover cross-track scenarios
2021-05-28 12:35:30 -06:00
Paul Davis
3e56eedf11 libardour: add X_() macros around several Source XMLNode state property names 2021-05-27 17:17:40 -06:00
Paul Davis
d4bc60a388 libardour: infrastructure for cue-marker-only source undo/redo 2021-05-27 17:17:40 -06:00
Paul Davis
83100de133 NOOP: rearrange arg decl to follow conventions 2021-05-27 17:17:40 -06:00
Paul Davis
ca44f54ed6 libardour: small changes to cue marker API to return bool from Source modification methods 2021-05-27 17:17:40 -06:00
Todd Naugle
1a1e67f595 Use Posix style return values for sem wait when on windows.
0 on success, -1 on error
2021-05-27 15:17:15 -05:00
Todd Naugle
be6d0fa95c Do not use named semaphores on Windows since they are system wide
https://docs.microsoft.com/en-us/dotnet/standard/threading/semaphore-and-semaphoreslim#named-semaphores

Running multiple instances of Ardour or Ardour/Mixbus would fail in very
odd ways since they would signal each other. Unnamed sems are
correct for this use case.
2021-05-27 15:13:40 -05:00
Robin Gareus
e91fd1fce6
Add Lua binding to query plugin-presets and scalepoints 2021-05-27 16:56:24 +02:00
Robin Gareus
a829fa58b3
Fix another C++11ism 2021-05-26 04:14:18 +02:00
Robin Gareus
2cf4568d82
Fix C++11isms in 3fb9f47bf1 2021-05-26 03:55:29 +02:00
Robin Gareus
d839e9cf14
Consistent _nth_ API call 0-based index 2021-05-26 02:33:31 +02:00
Damien Zammit
3fb9f47bf1 ptimport: Fix importing of large sessions, no more crashing and faster 2021-05-25 20:37:39 +10:00
Paul Davis
3a1cfc837e libardour: API infrastructure for renaming cue markers 2021-05-24 20:23:06 -06:00
Paul Davis
c2a012545b API infrastructure for dragging region/cue markers 2021-05-24 12:26:21 -06:00
Robin Gareus
a6fc82537e
Fix assert in Waveview cache size
previous condition made no sense. effectively assert(bytes > 0).
2021-05-23 21:41:45 +02:00
Robin Gareus
42f4e64d5f
Fix a moderate memory leak
periodic calls ARDOUR_UI::update_clocks() -> AudioClock::set()
-> 2+ calls to UI::set_tip() can easily accumulate 50MB/hour
when rolling.
2021-05-22 22:11:42 +02:00
Robin Gareus
d703079f10
ace-fluidsynth: add bypass (ignore notes, but retain reverb) 2021-05-21 18:40:59 +02:00
Robin Gareus
ecbd8732de
NO-OP: clang-format 2021-05-21 18:39:39 +02:00
Ben Loftis
6733a847ee Fix Bounced region+filename (lib part)
Prior implementation:
  Bouncing a range and naming it "chorus" resulted in:
     ..a region per track, and they were all named "chorus"
     ...a file per track, with the name "chorus-{playlist name}"

New implementation:
   Bouncing a range and naming it "chorus" results in:
     ..a region per track, with the name "chorus-{playlist name}"
     ...a file with the same name as the region
2021-05-20 11:42:48 -05:00
Paul Davis
2e501fd77a ensure the BasicUI implementation of rewind/ffwd is the same as the ARDOUR_UI one 2021-05-19 18:32:00 -06:00
Paul Davis
17dbdffc45 infrastructure APIs for region/cue marker removal and clear 2021-05-18 20:59:37 -06:00
Robin Gareus
d8e0a29316
Fix A/B plugins, skip internal but visible plugins (e.g. LAN) 2021-05-19 02:10:33 +02:00
Paul Davis
60a972a7de implement region marker deletion 2021-05-18 18:01:38 -06:00
Len Ovens
a5a2f111ee Remove debug line 2021-05-18 14:32:38 -07:00
Len Ovens
0130f19e26 Fix positions before start and after end 2021-05-18 14:27:20 -07:00
Robin Gareus
0ee8b1706d
Fix event_inside_widget_window()
This fixes cases where a widget's parent isn't the
top-level window and additional offset has to be taken
into account.

So far this has not been an issue since this method was only
used for floating text entries.
2021-05-18 22:17:36 +02:00
Robin Gareus
8cd8d90483
Reported the jack2 xrun bug, now we stop telling users 2021-05-18 03:17:17 +02:00
Len Ovens
f9557d0d04 Remove unused code 2021-05-17 13:50:18 -07:00
Len Ovens
ab7c6e74e0 OSC, update marks list better. 2021-05-17 13:34:19 -07:00
Tobias Kannenberg
e4a6e981d9 fix OSC "/marker" feedback 2021-05-17 13:31:03 -07:00
Robin Gareus
d2916a1df8
Better version of previous commit 2021-05-17 21:31:53 +02:00
Robin Gareus
9d063943bb
Fix deadlock when changing tempo
since dcc0f1cb17 Playlist::freeze takes a RegionWriteLock,
so freeze() must not be called with a Lock already held.
2021-05-17 21:15:58 +02:00
Robin Gareus
98721b1267
Don't count jack[2] xruns during freewheel export for now
Pending further investigation after the 6.7 release.
2021-05-17 04:44:53 +02:00