Paul Davis
77bc293aee
add a variation on the EC_LOCAL_TEMPO_SCOPE macro
2025-09-11 15:14:14 -06:00
Paul Davis
901e32f17f
temporal: add stacktraces to DEBUG_TRACE output for start/end local tempo map
2025-09-01 11:17:24 -06:00
Paul Davis
f6ec3828ed
temporal: fix local tempo map depth mgmt when starting a local tempo map
2025-09-01 11:17:24 -06:00
Robin Gareus
060462a9f1
Fix struct/class tag mismatch
...
> 'TempoMapScope' defined as a struct here but previously declared
> as a class; this is valid, but may result in linker errors under
> the Microsoft C++ ABI [clang-diagnostic-mismatched-tags]
2025-08-29 17:22:41 +02:00
Paul Davis
7dadddb3dc
temporal: provide TempoMap::global_fetch()
...
This always returns a shared ptr to the global tempo map, without setting the
thread-local pointer
2025-08-23 22:35:16 -06:00
Paul Davis
bb13bd48b2
several more bbt_delta() unit tests
2025-08-22 10:59:06 -06:00
Paul Davis
27ffd1628d
temporal: remove iterative bbt_delta() since unit test shows breakage
2025-08-22 10:51:16 -06:00
Paul Davis
fd53cf87ed
temporal: new non-iterative implementation of Meter::bbt_delta()
2025-08-22 10:45:12 -06:00
Paul Davis
26e63fca9b
add unit test for Meter::bbt_delta()
2025-08-22 10:45:12 -06:00
Paul Davis
e9460bb372
temporal: fix unused variable warning in TempoMap::paste()
2025-08-20 17:43:45 -06:00
Paul Davis
de843db102
temporal: lots more DEBUG_TRACE statements for grid debugging
2025-08-20 17:43:34 -06:00
Paul Davis
607f3577bd
temporal: in the event of the most common logic failure, provide more info
...
TEMPORAL_MAP_ASSERT() doesn't give us any actual values or context.
2025-08-20 17:43:24 -06:00
Paul Davis
a8168f826d
remove incorrect bbt_delta() in BBT_Time, provide Meter::bbt_delta
...
There are two implementations here, the more efficient one (commented out) does
not work correctly yet.
2025-08-20 17:43:05 -06:00
Paul Davis
469f3e4d2a
unit tests: fix an unusual deadlock/block in TempoMap::write_copy()
...
this call works in other tests, no time to investigate it right now, and
technically the test doesn't require a write copy at all.
2025-08-19 10:53:06 -06:00
Paul Davis
69174b555e
unit tests: use std::cout for any debug output in tempo map cut buffer test
2025-08-19 10:53:06 -06:00
Paul Davis
1312e8f992
temporal: implement TempoMap::bbt_distance() but do not use it
...
This was implemented to try to fix paste() but was not needed. It might be
useful in the future, or just as an expression of the logic of this. Note that
the BBT_Offset it returns only has the beats field set, which is ... odd. So
this is likely not quite finished.
2025-08-19 10:53:06 -06:00
Paul Davis
29be601cce
temporal: undefine macro after use
2025-08-19 10:53:06 -06:00
Paul Davis
7c9b9ceb7e
temporal: show BBT marker point names in operator<<
2025-08-19 10:53:06 -06:00
Paul Davis
2aad1ac5f5
temporal: fix TempoMap::paste() to pass unit test
...
the BBT times of the newly inserted points during paste() are meaningless until
we recompute them using ::reset_starting_at(). So don't try to compute some
sort of likely value, just use the value from the cut buffer, and call
reset_starting_at() after every point inserted.
2025-08-19 10:53:06 -06:00
Paul Davis
f0111bcea5
temporal: BBT_Time cannot have any round_to_*() or round_up_to_*() methods
...
A meter (time signature) is required to do the math correctly for any operation that may
cross or reach the next bar boundary, which round_to_*() and round_up_to_*() may do.
2025-08-19 10:53:06 -06:00
Paul Davis
f010133c5f
slightly improve a DEBUG_TRACE message for DEBUG::Grid
2025-08-13 10:51:44 -06:00
Paul Davis
46f2dba306
temporal: fix Meter::to_quarters (BBT_Offset)
...
Because Paul can't do math
2025-08-13 10:51:44 -06:00
John Emmas
ca820d6380
Remove some unneeded DLL export specifiers (and repo some that were in the wrong place)
2025-08-13 11:22:06 +01:00
Paul Davis
b95c29770c
initialize scope owner in default TempoMap constructor
...
This constructor should not really exist, but it does.
2025-08-12 21:44:50 -06:00
Paul Davis
20b984384d
NO-OP: move TempoMap destructor in code to be after constructors
2025-08-12 21:44:50 -06:00
Paul Davis
b205c0bc4b
scoped tempo maps: logic fixes and some comment-documentation
2025-08-12 07:53:30 -06:00
Paul Davis
2fc669964e
Revert "A new class ('ScopedTempoMapOwner') exposes functions which need to be visible outside of libtemporal"
...
This reverts commit d3a15b11ba
2025-08-12 07:15:17 -06:00
John Emmas
d3a15b11ba
A new class ('ScopedTempoMapOwner') exposes functions which need to be visible outside of libtemporal
...
(and since there's no 'scope.cc', libtemporal itself needs to #include scope.h for those symbols to get exported)
2025-08-12 13:19:24 +01:00
Paul Davis
ec61deaa8a
macro to stop local tempo map code from doing anything
2025-08-11 18:05:24 -06:00
Paul Davis
dd41fddcad
temporal: fix up some logic relating to scoped tempo maps
2025-08-11 15:41:34 -06:00
Paul Davis
023290b99d
temporal: add sanity check to TempoMap::fetch()
...
Threads should never call ::fetch() if they have a local tempo map in
use.
2025-08-11 15:41:34 -06:00
Paul Davis
1ecbdf164d
moved scoped tempo map from GUI to libtemporal
2025-08-11 15:41:34 -06:00
Paul Davis
d7b490143a
add comment on why _superclock_ticks_per_second is initializedto zero
2025-08-06 15:06:14 -06:00
Paul Davis
b80b4b7869
remove debugging output
2025-08-05 11:42:23 -06:00
Paul Davis
b65adb59cd
temporal: fix some subtle misbehavior in TempoMap::cut_copy()
2025-08-05 11:37:35 -06:00
Paul Davis
0f1c5a9d7d
temporal: add new smf_*() API for building a tempo map from SMF info
2025-08-05 11:37:35 -06:00
Paul Davis
ba00dc0920
temporal: add TempoMap::duration() method
2025-08-05 11:37:35 -06:00
Paul Davis
b6f1ff336e
when adding a tempo/meter at end of map, no reset necessary
...
Also, the reset would malfunction which really ought to be fixed
2025-07-30 22:18:12 -06:00
Paul Davis
fc692f5680
Fix for timepos_t::earlier() - superclock_t vs.samplepos_t confusion
2025-06-17 14:03:43 -06:00
Paul Davis
b6e1846c39
temporal: fix implementation of timepos_t::operator+= (BBT_Offset const &)
...
TempoMap::bbtwalk_to_quarters() converts the distance of the walk into quarters, but
we need the endpoint of the walk
2025-05-13 12:16:11 -06:00
Paul Davis
0e42868d35
fix arithmetic error in Meter::to_quarters
2025-04-11 11:23:36 -06:00
Paul Davis
9f3a41b96b
manually revert fa376b709d and debef6ab
...
Quantizing superclocks to samples in libtemporal negates the whole purpose of superclocks,
and breaks a variety of things, not limited to moving forward to markers and the grid
2025-02-28 13:39:45 -07:00
Paul Davis
debef6ab25
lighter, simpler math for sample-aligned superclocks
2025-01-30 11:26:41 -07:00
Paul Davis
fa376b709d
add new sample_aligned_superclock() method and use it when converting Beats to superclock
...
There can never be fractional audio time, and since superclock_t is used to represent audio time, when we
convert from Beat time, we should never, ever return a superclock value that does not correspond to
an integer number of samples.
This fixes a number of bugs, including any use of ARDOUR::Filter which writes a new (audio) file
to disk that must be an integer number of samples long, but may be derived from and later used
by a region that had an audio-time duration that is slightly longer (less than one sample)
than the audio file
2025-01-29 17:40:57 -07:00
Paul Davis
baef68b1e6
clean up/improve API used in 5ebf8152e
2025-01-10 09:25:03 -07:00
Paul Davis
5ebf8152ec
temporal: tempo changes must be on meter-provided grid, not quarter notes
2025-01-09 22:30:17 -07:00
Paul Davis
207cd9ae5f
fix temporal test runner
...
must abort all write_copy() map operations
2025-01-09 22:30:17 -07:00
Paul Davis
5f943295fc
copying a tempo map should not bail out just because there is only 1 tempo & meter
2024-12-18 16:46:07 -07:00
Paul Davis
364598e94f
temporal: add round_up_to_bar() methods to Meter, Metric and TempoMap
2024-10-31 12:22:35 -06:00
Paul Davis
f8ddc827c7
NO-OP: tweak comemnt that still referenced frames instead of samples
2024-10-31 12:22:35 -06:00
